[Bug 32550] New: Points2Grid crashes on calculation
http://bugs.winehq.org/show_bug.cgi?id=32550 Bug #: 32550 Summary: Points2Grid crashes on calculation Product: Wine Version: 1.5.20 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: goonstk(a)yahoo.com Classification: Unclassified Created attachment 42955 --> http://bugs.winehq.org/attachment.cgi?id=42955 backtrace http://lidar.asu.edu/points2grid.html Points2Grid 1.3 crashes when using test.las file as an input file, selecting min, max, mean and inputting 10 as a grid resolution. The output file was changed to test2.las. Another las file used were taken from: http://www.minnelusa.com/sampledata.php This caused the program to crash. The backtrace is also attached. Any options selected and proceeding to press OK will cause the program to crash. R -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=32550 --- Comment #1 from Ronak <goonstk(a)yahoo.com> 2012-12-26 10:19:00 CST --- Worked on Windows 7 virtual machine. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=32550 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |00cpxxx(a)gmail.com Ever Confirmed|0 |1 --- Comment #2 from Bruno Jesus <00cpxxx(a)gmail.com> 2013-01-04 14:53:18 CST --- I can confirm this issue in wine-git. The app does atof(NULL) and wine raises an INVALID_PARAMETER exception. A hack like "if(!str) return 0.0" makes the program happy and produces results. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=32550 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://lidar.asu.edu/points | |2grid.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=32550 Michael Müller <michael(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael(a)fds-team.de --- Comment #3 from Michael Müller <michael(a)fds-team.de> --- Hi, I wrote a patch including tests. Can you check whether it solves the problem for you? The patch is available at: https://github.com/wine-compholio/wine-staging/blob/master/patches/msvcrt-at... Regards, Michael -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=32550 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #4 from Bruno Jesus <00cpxxx(a)gmail.com> --- (In reply to Michael Müller from comment #3)
Hi,
I wrote a patch including tests. Can you check whether it solves the problem for you?
Certainly does, thanks. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=32550 Piotr Caban <piotr.caban(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr.caban(a)gmail.com Component|-unknown |msvcrt --- Comment #5 from Piotr Caban <piotr.caban(a)gmail.com> --- (In reply to Michael Müller from comment #3)
https://github.com/wine-compholio/wine-staging/blob/master/patches/msvcrt- atof_strtod/0001-msvcrt-Avoid-crash-when-NULL-pointer-is-passed-to-at.patch How about sending it to wine?
-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=32550 --- Comment #6 from Michael Müller <michael(a)fds-team.de> --- (In reply to Piotr Caban from comment #5)
(In reply to Michael Müller from comment #3)
https://github.com/wine-compholio/wine-staging/blob/master/patches/msvcrt- atof_strtod/0001-msvcrt-Avoid-crash-when-NULL-pointer-is-passed-to-at.patch How about sending it to wine?
The patch is not completely correct. The tests only check the behavior for the msvcrt.dll but the patch modifies the code for all msvcrt* versions. They behave differently depending on the version. I will update the patch when I have time. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=32550 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |0cb5067698470d3beec827a9b41 | |b3d23d606eb44 Status|NEW |RESOLVED CC| |sebastian(a)fds-team.de Resolution|--- |FIXED --- Comment #7 from Sebastian Lackner <sebastian(a)fds-team.de> --- As it turns out this bug is already fixed in current Wine git (and was already fixed at the time when Michael provided the proposed patch). I bisected it to: --- snip --- commit 0cb5067698470d3beec827a9b41b3d23d606eb44 Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Apr 21 13:08:00 2014 +0200 msvcrt: Don't raise exception in _invalid_parameter. --- snip --- Michaels patch fixes some other corner case (initialization of *end), but this is completely unrelated to this bug report. @Michael: Could you update your patch accordingly? The tests / fix for the corner cases might still be useful, but the if(...) condition in MSVCRT_strtod_l seems wrong / unnecessary. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=32550 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #8 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.7.46. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org