[Bug 20310] New: DirectDraw transparency
http://bugs.winehq.org/show_bug.cgi?id=20310 Summary: DirectDraw transparency Product: Wine Version: 1.1.30 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: minor Priority: P3 Component: directx-ddraw AssignedTo: wine-bugs(a)winehq.org ReportedBy: radzio.cool(a)gmail.com I found game Original War doesn't look well because of broken transparency in DDraw. The function in DDraw, that should ignore the specific (currently blue) color and paint the rest, paints everything so the effect isn't nice as you get blue panels where you should see the background. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 Patryk Tenderenda <gothuk16(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gothuk16(a)gmail.com --- Comment #1 from Patryk Tenderenda <gothuk16(a)gmail.com> 2009-10-10 13:23:47 --- Hi, I have the same. I love this game, but with Wine i don't have as lot fun as with Windows. I think the same would be in some other DDraw apps but I don't seem to have any. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 --- Comment #2 from adres7(a)gmail.com 2009-10-11 03:29:37 --- Created an attachment (id=24024) --> (http://bugs.winehq.org/attachment.cgi?id=24024) Transparency bug -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 --- Comment #3 from adres7(a)gmail.com 2009-10-11 03:37:19 --- Created an attachment (id=24025) --> (http://bugs.winehq.org/attachment.cgi?id=24025) Transparency bug*2 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 --- Comment #4 from adres7(a)gmail.com 2009-10-11 03:40:42 --- Created an attachment (id=24026) --> (http://bugs.winehq.org/attachment.cgi?id=24026) Transparency bug*3 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 --- Comment #5 from adres7(a)gmail.com 2009-10-11 03:42:22 --- Created an attachment (id=24027) --> (http://bugs.winehq.org/attachment.cgi?id=24027) Log -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 adres7(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adres7(a)gmail.com --- Comment #6 from adres7(a)gmail.com 2009-10-11 03:45:59 --- I also confirmed this bug in Original War. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 Christian Costa <titan.costa(a)wanadoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |titan.costa(a)wanadoo.fr --- Comment #7 from Christian Costa <titan.costa(a)wanadoo.fr> 2009-10-11 05:16:11 --- App does color keying on the blue component of 565 surfaces. It sets correctly the low value to 31 but set the high value to zero (instead of 31). It seems windows accepts this case but conformance tests must be done to prove that. Here is a patch that fixes the transparency problem. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 --- Comment #8 from Christian Costa <titan.costa(a)wanadoo.fr> 2009-10-11 05:20:38 --- Created an attachment (id=24029) --> (http://bugs.winehq.org/attachment.cgi?id=24029) Fix transparency -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 Dmitry Timoshkov <dmitry(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|DirectDraw transparency |Game Original War doesn't | |look well because of broken | |transparency -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 --- Comment #9 from adres7(a)gmail.com 2009-10-11 08:16:52 --- Patch doesn't work for me: 1. Patching - ~/Pulpit/wine-1.1.31$ patch -p1 < patch.diff patching file dlls/wined3d/surface.c Reversed (or previously applied) patch detected! 2. Compiling with new 1.1.31 Wine. 3. Installing. 4. Run the game - bad blue transparency. Here you can download demo version 1.09 (~350MB): http://www.owsupport.com/?sect=downloads -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 --- Comment #10 from Radosław Piliszek <radzio.cool(a)gmail.com> 2009-10-11 10:06:19 --- Same here. Patch didn't help. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 Christian Costa <titan.costa(a)wanadoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24029|0 |1 is obsolete| | --- Comment #11 from Christian Costa <titan.costa(a)wanadoo.fr> 2009-10-11 14:57:12 --- Created an attachment (id=24038) --> (http://bugs.winehq.org/attachment.cgi?id=24038) Fix transparency v2 Previous patch was only working for version 1.0 of the demo. This one works for both versions. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 Radosław Piliszek <radzio.cool(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #12 from Radosław Piliszek <radzio.cool(a)gmail.com> 2009-10-11 15:52:44 --- Patch did well. Compiled clean 1.1.31 with patch2 on Mandriva 2009.1. Transparency's working fine now. Thanks. Hope it will be included in Wine 1.2. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|FIXED | --- Comment #13 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-10-11 16:00:00 --- (In reply to comment #12)
Patch did well. Compiled clean 1.1.31 with patch2 on Mandriva 2009.1. Transparency's working fine now. Thanks. Hope it will be included in Wine 1.2.
Not fixed, nothing was committed to Wine git repo. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 --- Comment #14 from adres7(a)gmail.com 2009-10-13 08:44:59 --- Fix transparency v2 works for me, too. Thanks. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 --- Comment #15 from adres7(a)gmail.com 2009-10-13 08:46:33 --- Created an attachment (id=24075) --> (http://bugs.winehq.org/attachment.cgi?id=24075) Works patch screen -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 --- Comment #16 from Radosław Piliszek <radzio.cool(a)gmail.com> 2009-10-13 11:35:39 --- So it definitely fixes the broken transparency thing. Great. But can anyone tell me if it's going to be applied in the next Wine release? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 --- Comment #17 from Christian Costa <titan.costa(a)wanadoo.fr> 2009-10-13 13:59:54 --- I need first to check Windows behaviour to see if the fix is right. I've written a test but have no Windows box at hand. If someone can run it for me that would be kind. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 --- Comment #18 from Christian Costa <titan.costa(a)wanadoo.fr> 2009-10-13 14:06:12 --- Created an attachment (id=24100) --> (http://bugs.winehq.org/attachment.cgi?id=24100) test Test this exe on windows with dsurface as argument and send the output. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 --- Comment #19 from Radosław Piliszek <radzio.cool(a)gmail.com> 2009-10-13 15:06:27 --- Created an attachment (id=24101) --> (http://bugs.winehq.org/attachment.cgi?id=24101) Test results. Seems like the test failed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 Christian Costa <titan.costa(a)wanadoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24100|0 |1 is obsolete| | --- Comment #20 from Christian Costa <titan.costa(a)wanadoo.fr> 2009-10-13 15:33:29 --- Created an attachment (id=24102) --> (http://bugs.winehq.org/attachment.cgi?id=24102) test 2 Could you try this one. It's more verbose. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 --- Comment #21 from Austin English <austinenglish(a)gmail.com> 2009-10-13 15:58:03 --- (In reply to comment #20)
Created an attachment (id=24102) --> (http://bugs.winehq.org/attachment.cgi?id=24102) [details] test 2
Could you try this one. It's more verbose.
C:\Documents and Settings\austin\Desktop>ddraw_crosstest.exe dsurface dsurface.c:297: X channel was not copied into the destination surface dsurface.c:298: Test failed: Destination data after blitting is not correct dsurface.c:336: Test failed: GetColorKey does not return the colorkey set with S etColorKey dsurface.c:380: Test failed: GetColorKey does not return the colorkey set with S etColorKey dsurface.c:424: Test failed: GetColorKey does not return the colorkey set with S etColorKey dsurface.c:484: Tests skipped: Failed to create surface dsurface: 48 tests executed (0 marked as todo, 4 failures), 1 skipped. This on XP, nvidia geforce 6200. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 --- Comment #22 from Christian Costa <titan.costa(a)wanadoo.fr> 2009-10-13 16:32:28 --- Created an attachment (id=24106) --> (http://bugs.winehq.org/attachment.cgi?id=24106) test -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 --- Comment #23 from Christian Costa <titan.costa(a)wanadoo.fr> 2009-10-13 16:33:35 --- It seems I sent the wrong exe. Please try the new one. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 Radosław Piliszek <radzio.cool(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24101|0 |1 is obsolete| | --- Comment #24 from Radosław Piliszek <radzio.cool(a)gmail.com> 2009-10-14 03:14:05 --- Created an attachment (id=24117) --> (http://bugs.winehq.org/attachment.cgi?id=24117) Test results. 2nd It gives some more info. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 --- Comment #25 from Christian Costa <titan.costa(a)wanadoo.fr> 2009-10-14 03:26:07 --- Ok. Thanks. The patch is correct but needs a slight modification. I will submit a patch (fix + conformance test) soon. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 --- Comment #26 from Christian Costa <titan.costa(a)wanadoo.fr> 2009-10-15 14:32:35 --- Patch commited. This bug can be mark as fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |xerox_xerox2000(a)yahoo.co.uk Resolution| |FIXED --- Comment #27 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> 2009-10-15 15:50:29 --- (In reply to comment #26)
Patch commited. This bug can be mark as fixed.
great -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #28 from Alexandre Julliard <julliard(a)winehq.org> 2009-10-23 13:19:31 --- Closing bugs fixed in 1.1.32. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20310 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|directx-ddraw |directx-d3d -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org