[Bug 29973] New: StarBurn doesn't recognize its default drive selection for erasing
http://bugs.winehq.org/show_bug.cgi?id=29973 Bug #: 29973 Summary: StarBurn doesn't recognize its default drive selection for erasing Product: Wine Version: 1.4-rc4 Platform: x86-64 URL: http://www.starburnsoftware.com/products/starburn/down load/download-starburn-free OS/Version: Linux Status: UNCONFIRMED Severity: minor Priority: P2 Component: comctl32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: RandomAccountName(a)mail.com CC: bunglehead(a)gmail.com Classification: Unclassified Regression SHA1: 59e59c6bf97540a1c8ca5c248a10b9114cce9608 Created attachment 39019 --> http://bugs.winehq.org/attachment.cgi?id=39019 Terminal output In StarBurn's erase disc dialog, a list of detected CD/DVD/Blu-Ray drives is provided, with one of those drives selected by default. However, just clicking next to erase the disc in the preselected drive fails with an error claiming no device was selected. It works after deselecting the drive and then selecting it again. This is a regression: 59e59c6bf97540a1c8ca5c248a10b9114cce9608 is the first bad commit commit 59e59c6bf97540a1c8ca5c248a10b9114cce9608 Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Thu Jul 23 23:50:12 2009 +0400 comctl32/listview: Don't alter selection mark in LVM_SETITEMSTATE. :040000 040000 3b933d2d7fd43bcb781f1d1ce8dbe9f79d8b7b3b f109d330ce3227ec4a3226ccaba0b790d421a078 M dlls Reverting the patch allows the default selection to be recognized properly. Steps to reproduce: 1. Ensure a mounted rewritable optical disc is available 2. Create a symlink at $WINEPREFIX/dosdevices/cdrom0 linked to the device node of the drive containing the disc 3. Install and run StarBurn 4. Right-click the drive at the bottom of the window and choose 'erase disc' 5. Click next -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29973 A Wine user <RandomAccountName(a)mail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29973 --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> 2012-02-25 03:10:17 CST --- Please attach +listview,+tid log, I'll take a look. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29973 --- Comment #2 from A Wine user <RandomAccountName(a)mail.com> 2012-02-25 04:45:52 CST --- Created attachment 39063 --> http://bugs.winehq.org/attachment.cgi?id=39063 +listview,+tid log -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29973 --- Comment #3 from Nikolay Sivov <bunglehead(a)gmail.com> 2012-02-27 04:52:33 CST --- (In reply to comment #2)
Created attachment 39063 [details] +listview,+tid log
Thanks. I probably see a problem from it, the thing is that item state is set to (LVIS_SELECTED|LVIS_FOCUSED) and in that case selection mark should be updated. However if I set it to LVIS_SELECTED only selection mark should be preserved (we have a test for that fixed by this commit). This needs more tests for LVS_SINGLESEL style too, and I feel like it's a bit late to fix this before release cause it could break other things uncovering more bugs. I'll take case of this once 1.4 is released. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29973 --- Comment #4 from Nikolay Sivov <bunglehead(a)gmail.com> 2012-03-25 03:16:23 CDT --- After some testing problem is in setting item state code in general, not only LVM_SETITEMSTATE is affectes, but LVM_SETITEM as well. When you set state that includes LVS_FOCUSED change selection mark should be updated too. Basically it looks like in some cases selection mark just follows focus, except when you use Ctrl+Up/Down/Left/Right to navigate - then only focus changes but selection mark is preserved. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29973 --- Comment #5 from Nikolay Sivov <bunglehead(a)gmail.com> 2012-05-22 00:47:12 CDT --- Created attachment 40261 --> http://bugs.winehq.org/attachment.cgi?id=40261 patch I finally got some time for this. Please try this patch, this needs more tests to be added but in general that's how it works. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29973 --- Comment #6 from Nikolay Sivov <bunglehead(a)gmail.com> 2012-06-11 15:15:30 CDT --- This is probably fixed with commit 6560d881511bc2affba709803275d086e8d41249. I'm unable to make it recognise RW disc, so I can't test that. Could someone retest? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29973 A Wine user <RandomAccountName(a)mail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |6560d881511bc2affba70980327 | |5d086e8d41249 Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #7 from A Wine user <RandomAccountName(a)mail.com> 2012-06-20 04:44:08 CDT --- Yes, it's working now, thanks. Sorry I couldn't test sooner. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29973 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #8 from Alexandre Julliard <julliard(a)winehq.org> 2012-06-22 13:29:52 CDT --- Closing bugs fixed in 1.5.7. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org