[Bug 26043] New: advapi32/security tests shows some leaks in valgrind
http://bugs.winehq.org/show_bug.cgi?id=26043 Summary: advapi32/security tests shows some leaks in valgrind Product: Wine Version: 1.3.13 Platform: x86 OS/Version: Linux Status: NEW Keywords: download, source, testcase Severity: minor Priority: P2 Component: advapi32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: austinenglish(a)gmail.com 28 bytes in 1 blocks are definitely lost at notify_alloc (heap.c:254) by RtlAllocateHeap (heap.c:1701) by GetNamedSecurityInfoW (security.c:5491) by GetNamedSecurityInfoA (security.c:5428) by test_GetNamedSecurityInfoA (security.c:2809) by func_security (security.c:3526) by run_test (test.h:556) by main (test.h:624) ... 116 bytes in 1 blocks are definitely lost at notify_alloc (heap.c:254) by RtlAllocateHeap (heap.c:1701) by HeapAlloc (heap.c:267) by GlobalAlloc (heap.c:360) by LocalAlloc (heap.c:960) by GetSecurityInfo (security.c:3102) by test_GetSecurityInfo (security.c:3331) by func_security (security.c:3531) by run_test (test.h:556) by main (test.h:624) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26043 --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> 2011-08-06 04:31:15 CDT --- There's no way to fix that properly. Native allows to return pointers as buffer offset without returning buffer pointer itself. So there's nothing to free in both cases. Probably it's ok to add some comment lines around: --- error = pGetNamedSecurityInfoA(windows_dir, SE_FILE_OBJECT,DACL_SECURITY_INFORMATION, NULL, NULL, &dacl, NULL, NULL); --- to use it as valgrind suppression. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26043 --- Comment #2 from Nikolay Sivov <bunglehead(a)gmail.com> --- All current leaks are fixable, expect the one that has this comment in a test file: --- /* If we don't ask for the security descriptor, Windows will still give us the other stuff, leaving us no way to free it. */ ret = pGetSecurityInfo(obj, SE_FILE_OBJECT, OWNER_SECURITY_INFORMATION | GROUP_SECURITY_INFORMATION | DACL_SECURITY_INFORMATION, &owner, &group, &pDacl, NULL, NULL); --- it's a purpose of a test to show that call still works, and API doesn't prevent a leak. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=26043 --- Comment #3 from Austin English <austinenglish(a)gmail.com> --- Fixed by https://source.winehq.org/git/wine.git/commitdiff/e543eeb42be157a5c6fb6bc178.... I've added a suppression for the GetSecurityInfo leak. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=26043 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |e543eeb42be157a5c6fb6bc1782 | |5d394af699aa4 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Austin English <austinenglish(a)gmail.com> --- Fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=26043 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.7.18. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org