[Bug 33375] New: Cannot test dlls with dashes in their name
http://bugs.winehq.org/show_bug.cgi?id=33375 Bug #: 33375 Summary: Cannot test dlls with dashes in their name Product: Wine Version: 1.5.19 Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: build-env AssignedTo: wine-bugs(a)winehq.org ReportedBy: fgouget(a)codeweavers.com Classification: Unclassified Created attachment 44165 --> http://bugs.winehq.org/attachment.cgi?id=44165 Patch to reproduce this bug No conformance test can be written for dlls that have a dash in their name. These will first run into a build error: echo "api-ms-win-security-base-l1-1-0_test.exe TESTRES \"api-ms-win-security-base-l1-1-0_test-stripped.exe.so\"" | LD_LIBRARY_PATH="../../../libs/wine:$LD_LIBRARY_PATH" ../../../tools/wrc/wrc --nostdinc --po-dir=../../../po -m32 -I. -I. -I../../../include -I../../../include -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -DWIDL_C_INLINE_WRAPPERS -o ../../../programs/winetest/api-ms-win-security-base-l1-1-0_test.res :1:5: Error: syntax error What surprises me is that the dot on the 'TESTRES' left-hand causes no problem while the dashes do. I tried quoting that string but it did not help. The next problem is that if the TESTRES left-hand is modified to work around that issue, then winetest.exe will not be able to find the corresponding dll anymore and will thus skip the test. Filtering the list of tests to run based on the command line will likely be broken too. I'm attaching a patch to reproduce this issue. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33375 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33375 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44165|0 |1 is obsolete| | Assignee|wine-bugs(a)winehq.org |fgouget(a)codeweavers.com --- Comment #1 from François Gouget <fgouget(a)codeweavers.com> --- Created attachment 50790 --> https://bugs.winehq.org/attachment.cgi?id=50790 Patch to reproduce the bug This still fails. The problem is that we still use the dll name as is to build the resource identifier despite dashes being forbidden. I've attached a new patch to reproduce this bug. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33375 --- Comment #2 from François Gouget <fgouget(a)codeweavers.com> --- I have sent a patch to fix this bug. https://www.winehq.org/pipermail/wine-patches/2015-February/137162.html -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33375 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man(a)post.com --- Comment #3 from super_man(a)post.com --- The patch partly merges against 1.9.12-git. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33375 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #4 from François Gouget <fgouget(a)codeweavers.com> --- This works now. The wtbsuite has a test case for this that confirms it. This test case runs fine on the TestBot (including on Wine VMs where WineTest.exe is rebuilt despite not being used for manually submitted jobs). I don't know when this got fixed though. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33375 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 6.5. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla