[Bug 13886] New: Focus is killed after unminimizing the window
http://bugs.winehq.org/show_bug.cgi?id=13886 Summary: Focus is killed after unminimizing the window Product: Wine Version: CVS/GIT Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: minor Priority: P4 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: dylan.ah.smith(a)gmail.com Steps to produce the bug: 1. Open up Wine's wordpad wine wordpad 2. Minimize the window 3. Restore the window Afterwards the window will have focus but the caret will not be shown. I tested this on KDE 3.5.9 and Gnome 2.22.2 with the same bug occurring on both. I tested wordpad in Windows XP SP3, and there was no issue there. I tested with WINEDLLOVERRIDES="riched20=n" and the bug occurred.
From this I believe that it isn't a wordpad, or richedit issue.
I added some MESSAGE statements to find the sequence of events that cause the cursor not to be shown, and this is what I found. 1. After the window is minimized WM_KILLFOCUS is sent to the richedit control as expected. 2. After the window is restored, WM_SETFOCUS is sent as expected, then another WM_KILLFOCUS is incorrectly sent which will cause the caret to be hidden and destroyed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 --- Comment #1 from Dylan Smith <dylan.ah.smith(a)gmail.com> 2008-06-13 10:18:06 --- I found out that it is the main window that got the focus at the end rather than the richedit control within the main window. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |programs Summary|Focus is killed after |In wordpad focus is killed |unminimizing the window |after unminimizing the | |window --- Comment #2 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2008-06-13 14:11:29 --- So this happens with Wine's wordpad only? Not Notepad or any other program? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 --- Comment #3 from Dylan Smith <dylan.ah.smith(a)gmail.com> 2008-06-13 14:53:31 --- The issue would not be noticeable in Notepad because when the window receives a WM_SETFOCUS event, it will immediately set the focus on the edit control. Wordpad does not do this, so the bug is visible. Maybe I am confused though, because I tried taking out the line that changed focus to the edit control in notepad's source, and then cross compiled it for Windows. After that the issue was noticeable in Windows. I will completely rebuild everything for the newest release candidate and then do some more testing. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 --- Comment #4 from Dylan Smith <dylan.ah.smith(a)gmail.com> 2008-06-13 16:51:54 --- Created an attachment (id=13980) --> (http://bugs.winehq.org/attachment.cgi?id=13980) Difference between notepad and wordpad regarding this issue. I have figured out why there is a difference between wordpad and notepad on this issue. Wordpad sets the focus on the richedit control on WM_ACTIVATE, but Notepad sets the focus on the edit control on WM_SETFOCUS. I have attached a patch shows the difference, and can be used in order to test the issue in notepad. With this patch the issue will be present under wine, but not in windows. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 --- Comment #5 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2008-06-13 23:06:12 --- IMO it's better to fix wordpad to follow what notepad does, and then investigate the WM_ACTIVATE problem separately (with test cases). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 --- Comment #6 from Dylan Smith <dylan.ah.smith(a)gmail.com> 2008-06-14 01:44:38 --- Created an attachment (id=13989) --> (http://bugs.winehq.org/attachment.cgi?id=13989) Workaround fix that makes wordpad work like notepad regarding this issue Well here is the workaround fix for this bug. It has wordpad handle this situation like notepad, but this really only masks the problem. This appears to be a user32 issue, and I am not familiar with that code. Could someone else make a test that will catch this bug, and either create a new bug report that identifies the problem more precisely or fix the bug. It appears as if user32/winpos.c:show_window() is significant, since the call to SetWindowPos at line 1051 causes the WM_ACTIVATE message to be sent to the main window, and the focus is changed back to the window at the end of the function (line 1100) with a call to SetFocus. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 --- Comment #7 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2008-06-14 04:13:38 --- Created an attachment (id=13993) --> (http://bugs.winehq.org/attachment.cgi?id=13993) Do not reset focus if it's in a child Does the attached patch help? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 --- Comment #8 from Dylan Smith <dylan.ah.smith(a)gmail.com> 2008-06-14 07:45:17 --- Dmitry Timoshkov, your patch fixes the problem. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch, source -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 --- Comment #9 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2008-09-12 00:56:06 --- That patch doesn't pass the tests, and appears to be not what Windows does. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|CVS/GIT |unspecified --- Comment #10 from Austin English <austinenglish(a)gmail.com> 2009-01-20 02:39:13 --- Removing deprecated CVS/GIT version tag. Please retest in current git. If the bug is still present in today's wine, but was not present in some earlier version of wine, please update version field to earliest known version of wine that had the bug. Thanks! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |nerv(a)dawncrow.de Ever Confirmed|0 |1 --- Comment #11 from André H. <nerv(a)dawncrow.de> 2009-07-21 13:09:40 --- confirming in wine 1.1.26 this also happens in virtual desktop mode -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 --- Comment #12 from Austin English <austinenglish(a)gmail.com> 2010-05-19 16:45:44 --- This is your friendly reminder that there has been no bug activity for 6 months. Is this still an issue in current (1.1.44 or newer) wine? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 --- Comment #13 from Dylan Smith <dylan.ah.smith(a)gmail.com> 2010-05-19 17:30:02 --- This is still an issue in the wine-1.1.44-322-g5cc00e8. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 Dylan Smith <dylan.ah.smith(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |1.1.26 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 --- Comment #14 from André H. <nerv(a)dawncrow.de> 2010-07-19 12:22:48 --- Still present in Wine 1.2 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx(a)gmail.com --- Comment #15 from Bruno Jesus <00cpxxx(a)gmail.com> 2011-09-08 17:55:55 CDT --- Still present in 1.3.27. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 Frédéric Delanoy <frederic.delanoy(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic.delanoy(a)gmail.com --- Comment #16 from Frédéric Delanoy <frederic.delanoy(a)gmail.com> 2012-03-29 05:04:05 CDT --- Still present in wine-1.5.0-204-ga179b50 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 Rafal Stanilewicz <washuu(a)eastnews.com.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |washuu(a)eastnews.com.pl --- Comment #17 from Rafal Stanilewicz <washuu(a)eastnews.com.pl> 2012-10-24 15:35:58 CDT --- 1.5.15 as well, confirming. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13886 --- Comment #18 from Frédéric Delanoy <frederic.delanoy(a)gmail.com> 2013-06-07 07:15:34 CDT --- Still in wine-1.5.31-225-gba40509 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=13886 --- Comment #19 from Frédéric Delanoy <frederic.delanoy(a)gmail.com> --- Still in wine-1.9.18-121-g4e9cc30 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=13886 winetest(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest(a)luukku.com --- Comment #20 from winetest(a)luukku.com --- Could be dupe or at least related to bug 27502. Could someone test if the patch fixes that bug too. It has source code, which hasn't been compiled. Also if you think it's dupe please mark it so. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=13886 joaopa <jeremielapuree(a)yahoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree(a)yahoo.fr --- Comment #21 from joaopa <jeremielapuree(a)yahoo.fr> --- Bug still occurs with wine-5.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs@winehq.org -
WineHQ Bugzilla