[Bug 10567] New: Return value mistake in msiexec.c
http://bugs.winehq.org/show_bug.cgi?id=10567 Summary: Return value mistake in msiexec.c Product: Wine Version: CVS/GIT Platform: All OS/Version: All Status: UNCONFIRMED Severity: trivial Priority: P2 Component: wine-programs AssignedTo: wine-bugs(a)winehq.org ReportedBy: patrick.a.moran(a)gmail.com Created an attachment (id=9334) --> (http://bugs.winehq.org/attachment.cgi?id=9334) A patch that corrects the return value I was just looking at the git source for msiexec.c, and noticed that in the msi_atou() function, it calculates the DWORD, then returns 0 instead of the calculated value. The file attached is a patch that simply returns the calculated return value instead of 0. Please be gentle, this is a lot of firsts for me. It's the first time I've ever used git, generated a patch, used a bugzilla, or really submitted anything but a human-language translation to an open-source project. If my patch is not of the correct format, just let me know and I'll fix it. Also I wasn't sure if this is the correct venue for submitting this patch. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10567 Zac Brown <zac(a)zacbrown.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zac(a)zacbrown.org --- Comment #1 from Zac Brown <zac(a)zacbrown.org> 2007-11-25 01:23:21 --- This should be submitted to the wine-patches list (wine-patches(a)winehq.org). - Zac -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10567 --- Comment #2 from Patrick <patrick.a.moran(a)gmail.com> 2007-11-25 01:30:02 --- (In reply to comment #1)
This should be submitted to the wine-patches list (wine-patches(a)winehq.org).
- Zac
Got it, thanks. How should I mark the resolution of this bug? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10567 --- Comment #3 from Zac Brown <zac(a)zacbrown.org> 2007-11-25 08:44:10 --- Probably the best way is to submit the patch and when its confirmed that it is in the tree, then you can change the resolution to "RESOLVED". Until then I'd leave it as an open bug as its technically not "fixed" till the patch is in the tree. Cheers, Zac -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10567 Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 Keywords| |patch --- Comment #4 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2007-11-25 11:24:36 --- Confirming. You can resolve this bug after your change gets into Wine tree. And close after the next release. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10567 Vijay Kamuju <infyquest(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #5 from Vijay Kamuju <infyquest(a)gmail.com> 2007-11-27 10:33:51 --- patch commited -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10567 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #6 from Dan Kegel <dank(a)kegel.com> 2008-01-28 05:44:56 --- Closing all RESOLVED FIXED bugs older than four weeks. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10567 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|CVS/GIT |unspecified -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10567 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Platform|All |Other OS/Version|All |other --- Comment #7 from Austin English <austinenglish(a)gmail.com> 2012-02-23 15:11:53 CST --- Removing deprecated 'All' Platform/OS. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org