[Bug 30559] New: Several MS apps started rendering some fonts incorrectly
http://bugs.winehq.org/show_bug.cgi?id=30559 Bug #: 30559 Summary: Several MS apps started rendering some fonts incorrectly Product: Wine Version: 1.5.3 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: gdiplus AssignedTo: wine-bugs(a)winehq.org ReportedBy: djelinski1(a)gmail.com CC: dmitry(a)baikal.ru Classification: Unclassified Created attachment 39983 --> http://bugs.winehq.org/attachment.cgi?id=39983 screenshots displaying bad and good version of ms sql server management studio Some text messages are rendered with incorrect font size. See attached screenshot. They used to be rendered correctly in 1.5.2. Regression testing pointed to: 9b5b04c1c1a7b32dd3e1e453b6d739082c4ccede is the first bad commit commit 9b5b04c1c1a7b32dd3e1e453b6d739082c4ccede Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Thu Apr 19 21:43:51 2012 +0900 gdiplus: Avoid saving negative values in pixel_size and emSize. :040000 040000 fbe9f7976722d731a139d11bd677de715e31d27c 832f54f4167361de8dfd319d3e1fea7ecdcd1a3a M dlls I have noticed incorrect fonts in MS SQL Server management studio express 2005, ms sql server 2008 installer, ms sql server management studio 2008 installer and ms sql server management studio 2008 R2 installer. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=30559 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download Status|UNCONFIRMED |NEW URL| |http://www.snelstart.nl/dow | |nload/SetupDemoSnelStart.ex | |e CC| |focht(a)gmx.net Summary|Several MS apps started |Several apps started |rendering some fonts |rendering some fonts |incorrectly |incorrectly (appear as huge | |font sizes have been used) Ever Confirmed|0 |1 --- Comment #1 from Anastasius Focht <focht(a)gmx.net> 2012-04-30 17:25:19 CDT --- Hello, I can confirm this with other apps as well (now I remember it when I saw the screenshot with huge font sizes). "SnelStart Classic" from: http://www.snelstart.nl/download/SetupDemoSnelStart.exe Requires: 'winetricks -q mdac28 dotnet20' prerequisite Reproduce: --- snip --- $ pwd /home/focht/.wine/drive_c/Program Files/SnelStart/V1000 ... wine ./SnelStart.exe --- snip --- select "demonstratieversie" (which probably means demo version) select a demo template on the left tree view "Demo SnelStart! Boek1" -> "ok" in following selection dialog click "Administratie Openen" the next dialog contains text with huge font size (messes dialog layout up) Reverting commit '9b5b04c1c1a7b32dd3e1e453b6d739082c4ccede' on top of current git master or 'winetricks gdiplus' works around. $ du -sh setup_SnelStartClassic_v10-02.exe 40M setup_SnelStartClassic_v10-02.exe $ sha1sum setup_SnelStartClassic_v10-02.exe 74bc18c7e7a069e3c9b5e0e6ff396beadeee1d1f setup_SnelStartClassic_v10-02.exe Regards -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=30559 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Regression SHA1| |9b5b04c1c1a7b32dd3e1e453b6d | |739082c4ccede --- Comment #2 from Anastasius Focht <focht(a)gmx.net> 2012-04-30 17:26:30 CDT --- Hello, filling more fields ... Regards -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=30559 --- Comment #3 from Wylda <wylda(a)volny.cz> 2012-05-05 13:21:57 CDT --- Created attachment 40047 --> http://bugs.winehq.org/attachment.cgi?id=40047 Hearts of iron 3 Loader of Hearts of iron 3 (hoi3.exe) is unusable since commit mentioned in comment #0. Normally there should be relatively small window with buttons like "Start HoI3". Instead the window is 1920x1200 and buttons are missing completely + string "Preorder NOW!" is out of NEWS box. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=30559 --- Comment #4 from Daniel Jelinski <djelinski1(a)gmail.com> 2012-05-07 15:32:49 CDT --- FYI I tested today's git with patches [1] and [2] applied, the fonts are smaller, but still way too large. [1] http://source.winehq.org/patches/data/86023 [2] http://source.winehq.org/patches/data/86024 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=30559 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28336 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=30559 --- Comment #5 from Dmitry Timoshkov <dmitry(a)baikal.ru> 2012-05-07 23:10:22 CDT --- (In reply to comment #4)
FYI I tested today's git with patches [1] and [2] applied, the fonts are smaller, but still way too large. [1] http://source.winehq.org/patches/data/86023 [2] http://source.winehq.org/patches/data/86024
What application did you test the patches with? I debugged the problem with SnelStart Classic, and the patches are supposed to fix the APIs used by it. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=30559 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28336 | --- Comment #6 from Anastasius Focht <focht(a)gmx.net> 2012-05-08 01:03:13 CDT --- Hello, another small example app to play with: http://www.soft82.com/get/download/Windows/MorphVOX_Pro_Voice_Changer Prerequisite: 'winetricks dotnet20' Ignore the message box with "error 2", it's not critical for install. Either tick "run app after install" or run the app manually. The app shows a registration dialog on startup. Currently the dialog and controls are way oversized. Without the patches it is even worse, it fills the whole screen. With 'winetricks gdiplus' everything is normal. Removing dependency to bug 28336 as it's for installer and not the app itself. $ du -sh MorphVOXPro4_Install-1.exe 5.0M MorphVOXPro4_Install-1.exe $ sha1sum MorphVOXPro4_Install-1.exe ac4908ac5cddc786b24cff5e3e3428a616c6ccc7 MorphVOXPro4_Install-1.exe $ wine --version wine-1.5.3-188-gb80c71a Regards -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=30559 --- Comment #7 from Dmitry Timoshkov <dmitry(a)baikal.ru> 2012-05-08 02:50:32 CDT --- (In reply to comment #6)
another small example app to play with: http://www.soft82.com/get/download/Windows/MorphVOX_Pro_Voice_Changer
Thanks. Looks like I forgot to send a patch for dlls/gdi32/freetype.c which fixes returned font resolution from 300 to 96. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=30559 --- Comment #8 from Daniel Jelinski <djelinski1(a)gmail.com> 2012-05-08 14:50:22 CDT --- Created attachment 40099 --> http://bugs.winehq.org/attachment.cgi?id=40099 To the left with applied new patches, to the right with reverted patch Tested with [1],[2],[3],[4] applied, fonts look OK, but the entire window is stretched vertically. MS SQL Server Management Studio Express 2005: http://www.microsoft.com/download/en/details.aspx?id=8961 Prerequisites: winetricks dotnet20 recent version of Windows selected The application displays a connection window on startup. The connection window is a little too tall. These patches also fix bug 30474. [1] http://source.winehq.org/patches/data/86066 [2] http://source.winehq.org/patches/data/86068 [3] http://source.winehq.org/patches/data/86067 [4] http://source.winehq.org/patches/data/86070 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=30559 --- Comment #9 from Dmitry Timoshkov <dmitry(a)baikal.ru> 2012-05-08 18:18:03 CDT --- (In reply to comment #8)
Created attachment 40099 [details] To the left with applied new patches, to the right with reverted patch
Tested with [1],[2],[3],[4] applied, fonts look OK, but the entire window is stretched vertically.
MS SQL Server Management Studio Express 2005: http://www.microsoft.com/download/en/details.aspx?id=8961
Prerequisites: winetricks dotnet20 recent version of Windows selected
The application displays a connection window on startup. The connection window is a little too tall.
Changes in window height are expected since before the patches a way of calculating font height and other related metrics is very broken according to the tests. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=30559 --- Comment #10 from Dmitry Timoshkov <dmitry(a)baikal.ru> 2012-05-09 00:20:15 CDT --- (In reply to comment #8)
These patches also fix bug 30474.
They also may fix bug 30507. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=30559 --- Comment #11 from Daniel Jelinski <djelinski1(a)gmail.com> 2012-05-09 14:03:56 CDT --- (In reply to comment #9)
Changes in window height are expected since before the patches a way of calculating font height and other related metrics is very broken according to the tests.
I just compared the screenshot taken with your patches applied to the same screen with no patches, but with native gdiplus. They look pixel-to-pixel identical. I think this means that your patches are correct. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=30559 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |83e88af325c993fad3052cb9e29 | |fd137c332bb87 Status|NEW |RESOLVED Resolution| |FIXED --- Comment #12 from Anastasius Focht <focht(a)gmx.net> 2012-05-11 15:17:34 CDT --- Hello, this is fixed by commit series: http://source.winehq.org/git/wine.git/commitdiff/54b69043eb43f99b8c5dd85a3e6... (gdiplus: Derive GpFont from GpFontFamily.) http://source.winehq.org/git/wine.git/commitdiff/82a4c5a6a3f23f69f9b25be3bf3... (gdi32: Set tmDigitizedAspectX/Y to 96 instead of 300 for consistency.) http://source.winehq.org/git/wine.git/commitdiff/2c93bf7e4e469b36d3244f5a5f3... (gdiplus: Retrieve LOGFONT from a GpFont using GdipGetLogFontW instead of accessing... ) http://source.winehq.org/git/wine.git/commitdiff/915cd7b5b27381b2899b0402458... (gdiplus: Use appropriate accessors to calculate font height instead of accessing... ) http://source.winehq.org/git/wine.git/commitdiff/c626528a91505292487a4a3b727... (gdiplus: Use OUTLINETEXTMETRIC instead of LOGFONT to store GpFont metrics.) http://source.winehq.org/git/wine.git/commitdiff/83e88af325c993fad3052cb9e29... (gdiplus: Fetch font family metrics from truetype font data.) I tested some of the apps referenced here and they look good. This series will probably fix other UI issues not explicitly reported as well. Thanks Dmitry for your work. Regards -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=30559 --- Comment #13 from Daniel Jelinski <djelinski1(a)gmail.com> 2012-05-19 13:29:31 CDT --- Submitted bug 30728 for problem described in comment 8 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=30559 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #14 from Alexandre Julliard <julliard(a)winehq.org> 2012-05-25 13:40:58 CDT --- Closing bugs fixed in 1.5.5. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org