[Bug 25790] New: WM_SETTEXT handler for the user32 buttons generates WM_CTLCOLOR* inconsistent with Windows user32
http://bugs.winehq.org/show_bug.cgi?id=25790 Summary: WM_SETTEXT handler for the user32 buttons generates WM_CTLCOLOR* inconsistent with Windows user32 Product: Wine Version: 1.3.11 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: user32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: exclusion(a)gmail.com Created an attachment (id=32868) --> (http://bugs.winehq.org/attachment.cgi?id=32868) Test source Wine behavior when processing SetWindowText (WM_SETTEXT) doesn't exactly replicate Windows regarding WM_CTLCOLOR* messages. I found two inconsistencies and made the test (see attachments). First inconsistency: Windows doesn't generate WM_CTLCOLORSTATIC when WM_SETTEXT invoked for a PushButton and alike. Instead it generate WM_CTLCOLORBTN. In Windows I get: DialogBox.WindowProc: before SetWindowText DialogBox.WindowProc(WM_CTLCOLORBTN) DialogBox.WindowProc(WM_CTLCOLORBTN) DialogBox.WindowProc: after SetWindowText In Wine: DialogBox.WindowProc: before SetWindowText DialogBox.WindowProc(WM_CTLCOLORSTATIC) DialogBox.WindowProc(WM_CTLCOLORBTN) DialogBox.WindowProc: after SetWindowText Looking at http://msdn.microsoft.com/en-us/library/bb761849%28VS.85%29.aspx (WM_CTLCOLORBTN Message) and http://support.microsoft.com/kb/130952/en-us?fr=1 I believe that the WM_SETTEXT handler for BS_PUSHBUTTON, BS_DEFPUSHBUTTON and BS_PUSHLIKE should get the hbrush with the WM_CTLCOLORBTN message. Second inconsistency: Windows doesn't generate WM_CTLCOLOR* when WM_SETTEXT invoked for the invisible controls. My test in Windows shows: DialogBox.WindowProc: before SetWindowText DialogBox.WindowProc: after SetWindowText In Wine: DialogBox.WindowProc: before SetWindowText DialogBox.WindowProc(WM_CTLCOLORBTN) DialogBox.WindowProc: after SetWindowText These inconsistencies can be critical when an application doesn't expect to get these WM_CTLCOLOR* and tries to handle it before doing some initialization. In particular, Trillian 3.1 crashes when opening Trillian Preferences, Message Windows. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25790 --- Comment #1 from Alexander LAW <exclusion(a)gmail.com> 2011-01-16 03:36:44 CST --- Created an attachment (id=32869) --> (http://bugs.winehq.org/attachment.cgi?id=32869) Test exe -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25790 Alexander LAW <exclusion(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.winehq.org/show | |_bug.cgi?id=437 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25790 --- Comment #2 from Alexander LAW <exclusion(a)gmail.com> 2011-01-16 03:40:46 CST --- Created an attachment (id=32870) --> (http://bugs.winehq.org/attachment.cgi?id=32870) Proposed patch for the issue -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25790 Jerome Leclanche <adys.wh(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh(a)gmail.com --- Comment #3 from Jerome Leclanche <adys.wh(a)gmail.com> 2011-02-04 23:40:20 CST --- http://source.winehq.org/patches/data/70889 Patch is pending. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25790 Michael <msd4824(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |msd4824(a)yahoo.com --- Comment #4 from Michael <msd4824(a)yahoo.com> 2012-12-11 16:42:39 CST --- Just wondering what the status is of this. Newer versions of Trillian still crash when trying to enter certain sections of the preferences, so it'd be nice to see this patch make it's way in. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25790 Wylda <wylda(a)volny.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wylda(a)volny.cz --- Comment #5 from Wylda <wylda(a)volny.cz> --- Created attachment 49719 --> https://bugs.winehq.org/attachment.cgi?id=49719 WM_CTLCOLORSTATIC is still there Screenshot comparing Wine vs WinXP showing, that WM_CTLCOLORSTATIC is still in wine-1.7.28. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25790 Wylda <wylda(a)volny.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch, source, testcase -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25790 Wylda <wylda(a)volny.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #6 from Wylda <wylda(a)volny.cz> --- Confirming. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25790 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25790 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |STAGED CC| |dmitry(a)baikal.ru, | |erich.e.hoover(a)wine-staging | |.com, michael(a)fds-team.de, | |sebastian(a)fds-team.de Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/user32-WM_CTLC | |OLORBTN -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25790 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.winehq.org/sho | |w_bug.cgi?id=5706 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25790 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.winehq.org/sho | |w_bug.cgi?id=14928 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25790 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.winehq.org/sho | |w_bug.cgi?id=14879 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25790 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish(a)gmail.com --- Comment #7 from Austin English <austinenglish(a)gmail.com> --- *** Bug 14928 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25790 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |bc3f40e21a4beaaabd2d865838b | |ef99a3d12f908 Status|STAGED |RESOLVED --- Comment #8 from Sebastian Lackner <sebastian(a)fds-team.de> --- Fixed with the following commits: http://source.winehq.org/git/wine.git/commit/35ab5f4499185f8df0504b95a99613f... http://source.winehq.org/git/wine.git/commit/bc3f40e21a4beaaabd2d865838bef99... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25790 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #9 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.9.9. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25790 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mstefani(a)redhat.com Target Milestone|--- |1.8.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25790 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.8.x |--- --- Comment #10 from Michael Stefaniuc <mstefani(a)redhat.com> --- Removing 1.8.x milestone from bugs included in 1.8.3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25790 Rosanne DiMesio <dimesio(a)earthlink.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |polesapart(a)gmail.com --- Comment #11 from Rosanne DiMesio <dimesio(a)earthlink.net> --- *** Bug 14879 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25790 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |focht(a)gmx.net URL| |https://web.archive.org/web | |/20101205141014/http://down | |load.adobe.com/pub/adobe/ma | |gic/indesign/win/3.x/idcstr | |yENG.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla