[Bug 24721] New: Explorer++ crashes when choosing to view large icons or extra large icons
http://bugs.winehq.org/show_bug.cgi?id=24721 Summary: Explorer++ crashes when choosing to view large icons or extra large icons Product: Wine Version: 1.3.4 Platform: x86-64 URL: http://www.explorerplusplus.com/download OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: shell32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: RandomAccountName(a)mail.com Created an attachment (id=31230) --> (http://bugs.winehq.org/attachment.cgi?id=31230) Don't return E_FAIL To reproduce, set Windows version to Win7 or Vista (otherwise these options are hidden by the program) and then go to view -> large icons (or extra large icons). Depending on which of those options is selected, it outputs one of the following lines: fixme:shell:SHGetImageList Unsupported image list 2 requested fixme:shell:SHGetImageList Unsupported image list 4 requested ...then crashes immediately. Hacking SHGetImageList to stop returning a failure after that fixme prevents the crash. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=24721 A Wine user <RandomAccountName(a)mail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=24721 --- Comment #1 from A Wine user <RandomAccountName(a)mail.com> 2010-10-12 13:11:06 CDT --- Created an attachment (id=31231) --> (http://bugs.winehq.org/attachment.cgi?id=31231) Full crash log -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=24721 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=24721 --- Comment #2 from A Wine user <RandomAccountName(a)mail.com> 2011-08-22 04:58:43 CDT --- Still present in wine-1.3.26 and Explorer++ 1.3. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=24721 Frédéric Delanoy <frederic.delanoy(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |frederic.delanoy(a)gmail.com Ever Confirmed|0 |1 --- Comment #3 from Frédéric Delanoy <frederic.delanoy(a)gmail.com> 2013-05-16 03:38:41 CDT --- Confirmed with wine 1.5.30 and explorer++ 1.3.5 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=24721 --- Comment #4 from Frédéric Delanoy <frederic.delanoy(a)gmail.com> 2013-05-16 03:39:32 CDT --- (In reply to comment #3)
Confirmed with wine 1.5.30 and explorer++ 1.3.5
Windows version set to vista, using view > large icons -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=24721 Frédéric Delanoy <frederic.delanoy(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31231|0 |1 is obsolete| | --- Comment #5 from Frédéric Delanoy <frederic.delanoy(a)gmail.com> 2013-05-16 03:40:59 CDT --- Created attachment 44478 --> http://bugs.winehq.org/attachment.cgi?id=44478 wine 1.5.30 log, v1.3.5 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=24721 --- Comment #6 from Frédéric Delanoy <frederic.delanoy(a)gmail.com> 2013-05-16 03:41:58 CDT --- Created attachment 44479 --> http://bugs.winehq.org/attachment.cgi?id=44479 wine 1.5.30 backtrace, v1.3.5 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=24721 hanska2(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hanska2(a)luukku.com --- Comment #7 from hanska2(a)luukku.com --- http://source.winehq.org/git/wine.git/blob/8d93b9cee893b99d5bff2ea73602e33ed... 2177 /************************************************************************* 2178 * SHGetImageList (SHELL32.727) 2179 * 2180 * Returns a copy of a shell image list. 2181 * 2182 * NOTES 2183 * Windows XP features 4 sizes of image list, and Vista 5. Wine currently 2184 * only supports the traditional small and large image lists, so requests 2185 * for the others will currently fail. 2186 */ 2187 HRESULT WINAPI SHGetImageList(int iImageList, REFIID riid, void **ppv) 2188 { 2189 HIMAGELIST hLarge, hSmall; 2190 HIMAGELIST hNew; 2191 HRESULT ret = E_FAIL; 2192 2193 /* Wine currently only maintains large and small image lists */ 2194 if ((iImageList != SHIL_LARGE) && (iImageList != SHIL_SMALL) && (iImageList != SHIL_SYSSMALL)) 2195 { 2196 FIXME("Unsupported image list %i requested\n", iImageList); 2197 return E_FAIL; 2198 } 2199 2200 Shell_GetImageList(&hLarge, &hSmall); 2201 hNew = ImageList_Duplicate(iImageList == SHIL_LARGE ? hLarge : hSmall); 2202 2203 /* Get the interface for the new image list */ 2204 if (hNew) 2205 { 2206 ret = HIMAGELIST_QueryInterface(hNew, riid, ppv); 2207 ImageList_Destroy(hNew); 2208 } 2209 2210 return ret; 2211 } so the issue must still be 1.7.22 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=24721 --- Comment #8 from hanska2(a)luukku.com --- http://msdn.microsoft.com/en-us/library/windows/desktop/bb762185%28v=vs.85%2... I don't understand why they didnt finnish this function. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=24721 Michael Müller <michael(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael(a)fds-team.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=24721 --- Comment #9 from Michael Müller <michael(a)fds-team.de> --- I wrote a patch to implement extra large and jumbo icons. The patch is available at https://github.com/compholio/wine-compholio/blob/master/patches/shell32-Icon... The patch fixes the crash for Explorer++ and also works with the OSIcon Explorer test executable ( http://www.codeproject.com/Articles/50064/OSIcon , requires the original dot net 2.0). The OSIcon Explorer is able to display extra large and jumbo icons in the "Icons Associations" tab with the patch applied. Could you guys verify that the patch works for you and that you do not encounter any regressions? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=24721 --- Comment #10 from A Wine user <RandomAccountName(a)mail.com> --- (In reply to Michael Müller from comment #9)
Could you guys verify that the patch works for you and that you do not encounter any regressions?
I can confirm that the patch prevents the crash in Explorer++ for me, with no obvious regressions. Thanks. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=24721 Teras <teras(a)luukku.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |teras(a)luukku.com --- Comment #11 from Teras <teras(a)luukku.com> --- Michael Müller I tested your patch and it works for me. No crashes. wine-1.7.37-96-g1fdd692 (pure wine + this one patch) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=24721 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian(a)fds-team.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=24721 Michael Müller <michael(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |STAGED Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/shell32-Icons -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=24721 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man(a)post.com --- Comment #12 from super_man(a)post.com --- Still valid 1.9.12-git. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=24721 Louis Lenders <xerox.xerox2000x(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |trym(a)2.pl --- Comment #13 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- *** Bug 43900 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=24721 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wine-bugs(a)winehq.org |bunglehead(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=24721 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|STAGED |RESOLVED Fixed by SHA1| |51c9b47b8bc9f8518084c0896d0 | |eb451c316260 Resolution|--- |FIXED --- Comment #14 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Fixed by https://source.winehq.org/git/wine.git/?a=commit;h=e51c9b47b8bc9f8518084c089... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=24721 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bunglehead(a)gmail.com |wine-bugs(a)winehq.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=24721 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #15 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 3.5. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=24721 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mstefani(a)winehq.org Fixed by SHA1|51c9b47b8bc9f8518084c0896d0 |e51c9b47b8bc9f8518084c0896d |eb451c316260 |0eb451c316260 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org