[Bug 21144] New: cmd missing newline in output?
http://bugs.winehq.org/show_bug.cgi?id=21144 Summary: cmd missing newline in output? Product: Wine Version: 1.1.35 Platform: x86 URL: http://kegel.com/wine/cmdtest.tar.gz OS/Version: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: programs AssignedTo: wine-bugs(a)winehq.org ReportedBy: dank(a)kegel.com Even with Austin's recent patch http://www.winehq.org/pipermail/wine-patches/2009-December/083144.html applied, doing wget http://kegel.com/wine/cmdtest.tar.gz tar -xzvf cmdtest.tar.gz cd cmdtest sh cmdtest.sh shows that our cmd is missing a newline in its output: @@ -1,35 +1,22 @@ - -C:\fake>rem Easy cmd tests - ... +C:\fake>rem Easy cmd tests Looks like it needs to output another CRLF after the end of output of any command? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21144 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish(a)gmail.com --- Comment #1 from Austin English <austinenglish(a)gmail.com> 2009-12-23 19:53:13 --- Not all commands get newlines. See http://winezeug.googlecode.com/svn/trunk/appinstall/scripts/cmd.ahk. For example, 'echo on/off' should give no output at all. 'echo |' gives similar behavior. I'm sure there are others... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21144 --- Comment #2 from Dan Kegel <dank(a)kegel.com> 2009-12-25 09:35:05 --- Running with @echo off gets rid of the problem. I guess the command echoing code prints an extra newline before each command being echoed. Maybe changing WCMD_show_prompt like this would do the trick? (I'd try it but I'm on a netbook...) 327 q = out_string; + *q++ = '\r'; + *q++ = '\n'; 328 *q = '\0'; -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21144 --- Comment #3 from Austin English <austinenglish(a)gmail.com> 2009-12-29 04:09:19 --- (In reply to comment #2)
Running with @echo off gets rid of the problem. I guess the command echoing code prints an extra newline before each command being echoed. Maybe changing WCMD_show_prompt like this would do the trick? (I'd try it but I'm on a netbook...)
327 q = out_string; + *q++ = '\r'; + *q++ = '\n'; 328 *q = '\0';
Still fails 2 tests. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21144 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|programs |cmd -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21144 Jason Edmeades <us(a)edmeades.me.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |us(a)edmeades.me.uk --- Comment #4 from Jason Edmeades <us(a)edmeades.me.uk> 2010-01-06 18:26:41 --- Adding myself to the cmd bugs -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21144 Frédéric Delanoy <frederic.delanoy(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic.delanoy(a)gmail.com --- Comment #5 from Frédéric Delanoy <frederic.delanoy(a)gmail.com> 2011-07-20 14:16:48 CDT --- (In reply to comment #2)
Running with @echo off gets rid of the problem. I guess the command echoing code prints an extra newline before each command being echoed. Maybe changing WCMD_show_prompt like this would do the trick? (I'd try it but I'm on a netbook...)
327 q = out_string; + *q++ = '\r'; + *q++ = '\n'; 328 *q = '\0';
Can you please retry in current wine? I've added some changes regarded newlines recently. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21144 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #6 from Dan Kegel <dank(a)kegel.com> 2011-10-03 09:16:06 CDT --- Probably fixed, thanks. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21144 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Alexandre Julliard <julliard(a)winehq.org> 2011-10-10 13:14:17 CDT --- Closing bugs fixed in 1.3.30. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org