[Bug 50097] New: comctl32:monthcal fails on Wednesdays!!!
https://bugs.winehq.org/show_bug.cgi?id=50097 Bug ID: 50097 Summary: comctl32:monthcal fails on Wednesdays!!! Product: Wine Version: 5.20 Hardware: x86-64 OS: Windows Status: NEW Severity: normal Priority: P2 Component: comctl32 Assignee: wine-bugs(a)winehq.org Reporter: fgouget(a)codeweavers.com The failures are not systematic but over a two months period comctl32:monthcal failed 5 times and all were on Wednesdays! https://test.winehq.org/data/tests/comctl32:monthcal.html Wednesday 2020-09-09 Failed Wednesday 2020-09-16 Failed (*) Wednesday 2020-09-23 success Wednesday 2020-09-30 success Wednesday 2020-10-07 Failed Wednesday 2020-10-14 Failed Wednesday 2020-10-21 success Wednesday 2020-10-28 success Wednesday 2020-11-04 Failed Every time the two failures are: monthcal.c:2054: Test failed: 0: MCN_SELCHANGE should be sent monthcal.c:2045: Test failed: 1: MCN_SELCHANGE should be sent They happen on Windows 7, 8 and 10. (*) You may notice two failures for the 2020-09-15 WineTest. However a careful look at the log shows these WineTest runs occurred on Wednesday 2020-09-16 at 1 am! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50097 --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> --- It's probably because of this logic: mchit.pt.x = rc.right / 2; mchit.pt.y = rc.bottom / 2; So the day in the fourth column is used initially, which happens to be either Wednesday or Thursday in practice. Later test tries to fix that up by adjusting 'y' in a loop, that evidently does not work very well. It's also possible that while original pt.y does point to valid column, pt.x might miss valid day rectangle, failing initial hittesting. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50097 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source, testcase -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50097 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |190fbc750 Resolution|--- |FIXED CC| |zzhang(a)codeweavers.com Status|NEW |RESOLVED --- Comment #2 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- The bug should be fixed by 190fbc750 now. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50097 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1|190fbc750 |190fbc750094bb88a20a70d3f28 | |cd91b77790b62 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50097 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #3 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 7.22. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50097 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |7.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50097 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|7.0.x |--- --- Comment #4 from Michael Stefaniuc <mstefani(a)winehq.org> --- Drop 7.0.x target milestone from bugs that didn't make it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla