[Bug 39557] New: Dead code in IsDialogMessageW
https://bugs.winehq.org/show_bug.cgi?id=39557 Bug ID: 39557 Summary: Dead code in IsDialogMessageW Product: Wine Version: 1.7.54 Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs(a)winehq.org Reporter: alexhenrie24(a)gmail.com Distribution: --- IsDialogMessageW sets dlgCode to 0, then under VK_UP checks if (!(dlgCode & DLGC_WANTARROWS)). This if statement can never be true. https://source.winehq.org/git/wine.git/blob/cbaab82d086e36dacaa22c6adf80f911... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39557 Alex Henrie <alexhenrie24(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source CC| |julliard(a)winehq.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39557 Carlo Bramini <carlo.bramix(a)libero.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carlo.bramix(a)libero.it --- Comment #1 from Carlo Bramini <carlo.bramix(a)libero.it> --- In my opinion, 'dlgCode' is initialized on top of WM_KEYDOWN, before entering in the switch() statement related to virtual keys detection. If I have understood right, this bug is invalid and it should be closed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39557 Alex Henrie <alexhenrie24(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Alex Henrie <alexhenrie24(a)gmail.com> --- You're right; I misread the code. As of https://source.winehq.org/git/wine.git/commitdiff/d9c8effbf3555f37bfbb3866b7... dlgCode is no longer initialized twice, so it's less confusing now. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39557 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #3 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Closing Invalid. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org