[Bug 34465] New: process hacker 2.31 crashes in toolbar code
http://bugs.winehq.org/show_bug.cgi?id=34465 Bug #: 34465 Summary: process hacker 2.31 crashes in toolbar code Product: Wine Version: 1.7.1 Platform: x86 URL: http://processhacker.sourceforge.net/downloads.php OS/Version: Linux Status: NEW Keywords: download, source Severity: normal Priority: P2 Component: comctl32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: madewokherd(a)gmail.com Classification: Unclassified Created attachment 45884 --> http://bugs.winehq.org/attachment.cgi?id=45884 stack trace This requires a couple of winsta function stubs for bug 34317. It seems the program sends TB_GETBUTTONINFO to a toolbar with TBIF_TEXT set, but pszText and cchText set to 0. This causes a crash when we attempt to write to pszText. One would think that the solution is to respect cchText even when there is no text to return, but I got a crash when I tried to write a test that does this on Windows. It seems Windows always crashes given NULL/0 for pszText/cchText except when a string pointer is set for the button text.
From the application source code http://sourceforge.net/p/processhacker/code/5441/tree//2.x/trunk/plugins/Too... it looks to me like NULL/0 and the TBIF_TEXT flag will always be used, and I can't find a way that the text would be set to a string pointer without reading it in this way first. So I haven't been able to figure out how Process Hacker could work on windows when my test did not.
I don't think this happened in 2.30. This could easily be worked around in Process Hacker, but it appears to be a Wine bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34465 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish(a)gmail.com --- Comment #1 from Austin English <austinenglish(a)gmail.com> 2013-09-09 16:38:53 CDT --- Also happens in a 32-bit WINEPREFIX, fwiw. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34465 --- Comment #2 from Austin English <austinenglish(a)gmail.com> 2013-09-09 16:39:46 CDT --- Created attachment 45909 --> http://bugs.winehq.org/attachment.cgi?id=45909 toolbar,relay,seh,tid trace -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34465 Vincent Povirk <madewokherd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madewokherd(a)gmail.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34465 dmex04(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dmex04(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34465 --- Comment #3 from Austin English <austinenglish(a)gmail.com> --- Still in wine-1.7.36-28-ga679cae -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34465 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38103 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34465 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx(a)gmail.com, | |super_man(a)post.com --- Comment #4 from super_man(a)post.com --- Bruno could you look at this? You were able to find the problem at #35127 which seem to similar, but the location is different. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34465 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34317 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34465 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wine-bugs(a)winehq.org |bunglehead(a)gmail.com --- Comment #5 from Nikolay Sivov <bunglehead(a)gmail.com> --- I think I see what's wrong with our logic here, and how to stop test crashes on Windows. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34465 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Fixed by SHA1| |26067cc0b9e39ac80bd13f8c90d | |9c9948eb60fbb Resolution|--- |FIXED --- Comment #6 from Nikolay Sivov <bunglehead(a)gmail.com> --- Fixed with 26067cc0b9e39ac80bd13f8c90d9c9948eb60fbb. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34465 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bunglehead(a)gmail.com |wine-bugs(a)winehq.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34465 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 2.0-rc5. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34465 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.8.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34465 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.8.x |--- --- Comment #8 from Michael Stefaniuc <mstefani(a)redhat.com> --- Removing 1.8.x milestone from bugs included in 1.8.7. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org