[Bug 48410] New: The "Add syscall thunks for 64 bit" patch partly breaks USVFS
https://bugs.winehq.org/show_bug.cgi?id=48410 Bug ID: 48410 Summary: The "Add syscall thunks for 64 bit" patch partly breaks USVFS Product: Wine-staging Version: 5.0-rc3 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: qsniyg(a)mail.com CC: leslie_alistair(a)hotmail.com, z.figura12(a)gmail.com Distribution: --- This is the patch that breaks USVFS: https://github.com/wine-staging/wine-staging/blob/d36d63ac848dadbc2c8ffc933f... (discussion: https://github.com/ModOrganizer2/modorganizer/issues/372). I've only tested 64-bit, so it's possible https://github.com/wine-staging/wine-staging/blob/master/patches/winebuild-F... also affects it. Although USVFS works for the most part, loading DLLs fails, because LdrLoadDll (within ntdll) calls NtOpenFile (through open_dll_file), but for some reason, USVFS doesn't recognize that specific NtOpenFile call (even though it hooks other NtOpenFile calls that aren't called from ntdll without issue). I haven't looked through the patch in much detail, but from what I can tell I believe the reason why this patch breaks USVFS is because the calls to NtOpenFile from within ntdll use the direct function address, whereas with the patch, USVFS now hooks a new "wrapper" around the function, instead of the same address that ntdll calls internally. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48410 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gofmanp(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48410 --- Comment #1 from Paul Gofman <gofmanp(a)gmail.com> --- Created attachment 66184 --> https://bugs.winehq.org/attachment.cgi?id=66184 Test patch Does the attached patch (on top of Wine Staging with all patches applied) help? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48410 Jarrard Lo <overlord.jarrard(a)tutamail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |overlord.jarrard(a)tutamail.c | |om --- Comment #2 from Jarrard Lo <overlord.jarrard(a)tutamail.com> --- (In reply to Paul Gofman from comment #1)
Created attachment 66184 [details] Test patch
Does the attached patch (on top of Wine Staging with all patches applied) help?
I'll give this patch a go if I can on top of proton-tkg (easiest to build for me). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48410 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48410 --- Comment #3 from Jarrard Lo <overlord.jarrard(a)tutamail.com> --- (In reply to Jarrard Lo from comment #2)
(In reply to Paul Gofman from comment #1)
Created attachment 66184 [details] Test patch
Does the attached patch (on top of Wine Staging with all patches applied) help?
I'll give this patch a go if I can on top of proton-tkg (easiest to build for me).
Ok well tested it with proton-tkg staging build 5.0rc4 and it does appear to work. I know the patch was applied because tkg will actually prompt to apply it, and it passed without errors (too me a little while to figure out where it wanted the patch tho). I guess I should at some point compile a NON patched proton-tkg staging build to verify its working BECAUSE of this patch and not due to something else being touched by 5.0rc4/tkg. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48410 --- Comment #4 from Paul Gofman <gofmanp(a)gmail.com> --- This should be fixed in Staging 5.0-rc6. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48410 --- Comment #5 from Jarrard Lo <overlord.jarrard(a)tutamail.com> --- (In reply to Paul Gofman from comment #4)
This should be fixed in Staging 5.0-rc6.
very nice -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48410 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |68bfc31be4f2017345c2fa7f561 | |d732250192cc7 Status|UNCONFIRMED |RESOLVED --- Comment #6 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- Marking FIXED based on Comment 4. Please reopen if you can still reproduce. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48410 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Closing bugs fixed in Staging 5.15. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla