[Bug 36603] New: valgrind shows uninitialized memory use in winespool.drv/tests/info.c
https://bugs.winehq.org/show_bug.cgi?id=36603 Bug ID: 36603 Summary: valgrind shows uninitialized memory use in winespool.drv/tests/info.c Product: Wine Version: 1.7.19 Hardware: x86 OS: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: wineps.drv Assignee: wine-bugs(a)winehq.org Reporter: austinenglish(a)gmail.com ==21038== Conditional jump or move depends on uninitialised value(s) ==21038== at 0x5550802: get_special_root_hkey (registry.c:282) ==21038== by 0x5552E61: RegQueryValueExW (registry.c:1355) ==21038== by 0x49F9199: OpenPrinterW (info.c:2551) ==21038== by 0x49F901C: OpenPrinterA (info.c:2495) ==21038== by 0x49978C8: test_EnumForms (info.c:808) ==21038== by 0x49A2438: func_info (info.c:3031) ==21038== by 0x49A32B1: run_test (test.h:584) ==21038== by 0x49A369F: main (test.h:654) ==21038== Uninitialised value was created by a stack allocation ==21038== at 0x49F9091: OpenPrinterW (info.c:2532) ==21038== ==21038== Conditional jump or move depends on uninitialised value(s) ==21038== at 0x5550802: get_special_root_hkey (registry.c:282) ==21038== by 0x5552E61: RegQueryValueExW (registry.c:1355) ==21038== by 0x49F0C6E: get_dword_from_reg (info.c:493) ==21038== by 0x49F91CA: OpenPrinterW (info.c:2553) ==21038== by 0x49F901C: OpenPrinterA (info.c:2495) ==21038== by 0x49978C8: test_EnumForms (info.c:808) ==21038== by 0x49A2438: func_info (info.c:3031) ==21038== by 0x49A32B1: run_test (test.h:584) ==21038== by 0x49A369F: main (test.h:654) ==21038== Uninitialised value was created by a stack allocation ==21038== at 0x49F9091: OpenPrinterW (info.c:2532) ==21038== ==21038== Conditional jump or move depends on uninitialised value(s) ==21038== at 0x5550802: get_special_root_hkey (registry.c:282) ==21038== by 0x5552827: RegSetValueExW (registry.c:1212) ==21038== by 0x49F0D7E: set_reg_DWORD (info.c:510) ==21038== by 0x49F91F0: OpenPrinterW (info.c:2554) ==21038== by 0x49F901C: OpenPrinterA (info.c:2495) ==21038== by 0x49978C8: test_EnumForms (info.c:808) ==21038== by 0x49A2438: func_info (info.c:3031) ==21038== by 0x49A32B1: run_test (test.h:584) ==21038== by 0x49A369F: main (test.h:654) ==21038== Uninitialised value was created by a stack allocation ==21038== at 0x49F9091: OpenPrinterW (info.c:2532) ==21038== I do have a network printer available to wine. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36603 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|valgrind shows |valgrind shows |uninitialized memory use in |uninitialized memory use in |winespool.drv/tests/info.c |winspool.drv/tests/info.c -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36603 --- Comment #1 from Austin English <austinenglish(a)gmail.com> --- Also: ==15338== Syscall param write(buf) points to uninitialised byte(s) ==15338== at 0x4226CF3: __write_nocancel (syscall-template.S:81) ==15338== by 0x7BC7FD72: send_request (server.c:198) ==15338== by 0x7BC7FF91: wine_server_call (server.c:294) ==15338== by 0x7BC6348E: close_handle (om.c:355) ==15338== by 0x7BC634C2: NtClose (om.c:376) ==15338== by 0x5697421: RegCloseKey (registry.c:1083) ==15338== by 0x4F8E22C: OpenPrinterW (info.c:2558) ==15338== by 0x4F8E01C: OpenPrinterA (info.c:2495) ==15338== by 0x4E518C8: test_EnumForms (info.c:808) ==15338== by 0x4E5C438: func_info (info.c:3031) ==15338== by 0x4E5D2B1: run_test (test.h:584) ==15338== by 0x4E5D69F: main (test.h:654) ==15338== Address 0x4f6f9cc is on thread 1's stack ==15338== Uninitialised value was created by a stack allocation ==15338== at 0x4F8E091: OpenPrinterW (info.c:2532) ==15338== -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36603 --- Comment #2 from Bruno Jesus <00cpxxx(a)gmail.com> --- Created attachment 48662 --> https://bugs.winehq.org/attachment.cgi?id=48662 patch Please try the attached patch. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36603 --- Comment #3 from Austin English <austinenglish(a)gmail.com> --- (In reply to Bruno Jesus from comment #2)
Created attachment 48662 [details] patch
Please try the attached patch.
Solves all of the issues in this bug, thanks. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36603 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |valgrind -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36603 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |27280661524d3f66741cb8e7c7b | |27a3b46eca542 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Bruno Jesus <00cpxxx(a)gmail.com> --- Patch commited. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36603 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.7.20. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org