[Bug 17851] New: WSAAddressToStringA AF_INET6 implementation missing
http://bugs.winehq.org/show_bug.cgi?id=17851 Summary: WSAAddressToStringA AF_INET6 implementation missing Product: Wine Version: 1.0.1 Platform: All OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: winsock AssignedTo: wine-bugs(a)winehq.org ReportedBy: berni(a)birkenwald.de The well-known Torrent client application uTorrent gained IPv6 support in Version 1.8. When running within the Wine environment it displays [<ERROR>] instead of the literal IPv6 address for peers. According to http://forum.utorrent.com/viewtopic.php?pid=363137#p363137 uTorrent uses the WSAAddressToStringA function to format the address to a string. Looking into dlls/ws2_32/socket.c it's pretty obvious that the wine version only supports AF_INET (IPv4). Please support AF_INET6 in that function. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17851 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.utorrent.com/ Keywords| |download -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17851 Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Platform|All |Other -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17851 Kai Blin <kai.blin(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |ASSIGNED Ever Confirmed|0 |1 --- Comment #1 from Kai Blin <kai.blin(a)gmail.com> 2009-03-26 03:47:56 --- Yup, we don't handle IPv6 in WSAAddressToStringA/W yet. Looking into this. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17851 Jeff L <lats(a)yless4u.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lats(a)yless4u.com.au --- Comment #2 from Jeff L <lats(a)yless4u.com.au> 2009-04-13 04:28:35 --- Kai, I did not see the bug. I have created a patch for this condition. Do you wnat to have a look? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17851 --- Comment #3 from Kai Blin <kai.blin(a)gmail.com> 2009-04-13 05:14:54 --- Sure. Did you add some tests for this as well? That's where I got stuck. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17851 --- Comment #4 from Jeff L <lats(a)yless4u.com.au> 2009-04-13 05:28:54 --- Yes I have some that I am fine tuning. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17851 Jeff L <lats(a)yless4u.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|wine-bugs(a)winehq.org |lats(a)yless4u.com.au Status|ASSIGNED |NEW --- Comment #5 from Jeff L <lats(a)yless4u.com.au> 2009-04-27 05:00:47 --- http://www.winehq.org/pipermail/wine-patches/2009-April/072343.html http://www.winehq.org/pipermail/wine-patches/2009-April/072344.html implement the IPv6 code to fix this bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17851 --- Comment #6 from Bernhard Schmidt <berni(a)birkenwald.de> 2009-04-27 16:35:36 --- Created an attachment (id=20761) --> (http://bugs.winehq.org/attachment.cgi?id=20761) µTorrent 1.8.3 screenshot Jeff, thanks for creating the patch. Unfortunately it seems to have some issue, as it is printing out bogus information in µTorrent. Connections according to ss/netstat: ESTAB 0 0 2001:a60:f001:1:219:66ff:fe8b:a6e:56374 2002:4e5a:3338::4e5a:3338:34932 users:(("uTorrent.exe",21482,44),("wineserver",21485,94)) ESTAB 0 53876 2001:a60:f001:1:219:66ff:fe8b:a6e:48277 2002:775e:1ce9::775e:1ce9:19033 users:(("uTorrent.exe",21482,42),("wineserver",21485,92)) ESTAB 0 19996 2001:a60:f001:1:219:66ff:fe8b:a6e:53254 2002:5ebf:a61b::5ebf:a61b:17897 users:(("uTorrent.exe",21482,43),("wineserver",21485,93)) ESTAB 0 0 2001:a60:f001:1:219:66ff:fe8b:a6e:44704 2002:4bbb:3dc8::4bbb:3dc8:57324 users:(("uTorrent.exe",21482,39),("wineserver",21485,61)) I applied the four patches to the Ubuntu PPA package of Wine 1.1.20 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17851 Jeff L <lats(a)yless4u.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #7 from Jeff L <lats(a)yless4u.com.au> 2009-04-28 03:41:04 --- (In reply to comment #6)
Created an attachment (id=20761) --> (http://bugs.winehq.org/attachment.cgi?id=20761) [details] µTorrent 1.8.3 screenshot
Jeff,
thanks for creating the patch. Unfortunately it seems to have some issue, as it is printing out bogus information in µTorrent.
Connections according to ss/netstat:
ESTAB 0 0 2001:a60:f001:1:219:66ff:fe8b:a6e:56374 2002:4e5a:3338::4e5a:3338:34932 users:(("uTorrent.exe",21482,44),("wineserver",21485,94)) ESTAB 0 53876 2001:a60:f001:1:219:66ff:fe8b:a6e:48277 2002:775e:1ce9::775e:1ce9:19033 users:(("uTorrent.exe",21482,42),("wineserver",21485,92)) ESTAB 0 19996 2001:a60:f001:1:219:66ff:fe8b:a6e:53254 2002:5ebf:a61b::5ebf:a61b:17897 users:(("uTorrent.exe",21482,43),("wineserver",21485,93)) ESTAB 0 0 2001:a60:f001:1:219:66ff:fe8b:a6e:44704 2002:4bbb:3dc8::4bbb:3dc8:57324 users:(("uTorrent.exe",21482,39),("wineserver",21485,61))
I applied the four patches to the Ubuntu PPA package of Wine 1.1.20
I changed inet_ntop to WS_inet_ntop which meant that those patches were dependent on the following. The following patches have just been accepted into the tree and should fix the problem. http://www.winehq.org/pipermail/wine-cvs/2009-April/054960.html http://www.winehq.org/pipermail/wine-cvs/2009-April/054961.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17851 --- Comment #8 from Bernhard Schmidt <berni(a)birkenwald.de> 2009-04-28 14:17:04 --- okay, _almost_ fixed :-) With those additional two patches the IP addresses in the peers tab are okay now, but the ones in the detailled logging aren't. [2009-04-28 21:11:08] [2001:0:d5c7:a2d6:0:b136:a274:8421]:60671: [BitTorrent 6.1.2 (51.8)]: Got Have 616 [2009-04-28 21:12:06] [2001:0:d5c7:a2d6:0:b136:a274:8421]:60671: [BitTorrent 6.1.2 (51.8)]: Got Have 825 [2009-04-28 21:12:48] [2001:0:d5c7:a2d6:0:b136:a274:8421]:60671: [BitTorrent 6.1.2 (51.9)]: Got Have 782 [2009-04-28 21:12:54] Incoming connection from [2bb1:c67b:f46f:807e:ece9:8c00::]:1792 [2009-04-28 21:13:19] [2001:0:cf2e:3096:0:fbd9:8354:d3f3]:48176: [µTorrent 1.8.2 (100.0)]: Sending 4 bytes of aggregated data the addresses with "Incoming connection" are broken, the other ones are fine. I suspect they use a different function to print it, do you see anything obvious in the code? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17851 --- Comment #9 from Bernhard Schmidt <berni(a)birkenwald.de> 2009-04-28 15:49:42 --- Disregard the last report for now. [2009-04-28 22:03:31] Incoming connection from [2bb1:c67b:f46f:807e:ece9:8c00::]:1792 [2009-04-28 22:07:07] Incoming connection from [2001:0:d5c7:a2d6:34a4:2c32:ae28:5d07]:59126 [2009-04-28 22:07:07] [2001:0:d5c7:a2d6:34a4:2c32:ae28:5d07]:59126: [Mainline 6.1.2 (0.0)]: Handshake completed [2009-04-28 22:11:44] Incoming connection from [2001:0:cf2e:3096:0:fbd9:8354:d3f3]:2174 As you can see there are cases where the neighbor IP is correctly printed. I also ran tcpdump and could not register a single IPv6 connection attempt when the event happened. Neither did the firewall. So I'd say the code is good. Thanks a lot. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17851 Jeff L <lats(a)yless4u.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #10 from Jeff L <lats(a)yless4u.com.au> 2009-05-01 06:41:20 --- Patches accepted 30/4/09 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17851 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #11 from Alexandre Julliard <julliard(a)winehq.org> 2009-05-08 12:50:42 --- Closing bugs fixed in 1.1.21. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org