[Bug 48043] New: user32:dce has a pair of random failures
https://bugs.winehq.org/show_bug.cgi?id=48043 Bug ID: 48043 Summary: user32:dce has a pair of random failures Product: Wine Version: unspecified Hardware: x86 OS: Windows Status: NEW Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs(a)winehq.org Reporter: fgouget(a)codeweavers.com Created attachment 65584 --> https://bugs.winehq.org/attachment.cgi?id=65584 user32:dce: Loop over the test_destroyed_window() for 2 random failures. user32:dce has a pair of random failures in test_destroyed_window(): dce.c:648: Test failed: wrong window dce.c:658: Test failed: DC for destroyed window not reused One either gets the first one alone or both together. See https://test.winehq.org/data/tests/user32:dce.html These happen at random on a wide range of Windows versions: wxppro, w2003std, w2008s64, fg-win7u64-*, w1064v1507, w1064v1607. On Windows 10 the same type of error sometimes happens in test_dc_attributes() on line 127 which is another "wrong window\n" check. The attached patch loops over test_destroyed_window() which is sufficient to make these failures systematic. This can hopefully help debug the issue and make sure these are fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48043 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source, testcase --- Comment #1 from François Gouget <fgouget(a)codeweavers.com> --- For reference the tests were introduced in this commit: commit 52d90e3ce0ed5a35bcb10723379a1702f8706cc8 Author: Alexandre Julliard <julliard(a)winehq.org> AuthorDate: Mon Jul 17 09:54:45 2017 +0200 user32/tests: Add some tests for WindowFromDC and destroyed windows. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48043 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |d76527373b6ae40439706352a92 | |97c4bf6878dee Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from François Gouget <fgouget(a)codeweavers.com> --- These got fixed, probably by this pair of commits: commit 89d67614ca1d020fae39aa09e852a7e2bea77783 Author: Zebediah Figura <z.figura12(a)gmail.com> AuthorDate: Mon Jan 6 10:00:00 2020 -0600 Commit: Alexandre Julliard <julliard(a)winehq.org> CommitDate: Mon Jan 6 20:23:02 2020 +0100 user32/tests: Relax WindowFromDC() tests a bit. Windows often reuses the DC handle for a different window (which may be in another process). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> commit d76527373b6ae40439706352a9297c4bf6878dee Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Mon Jan 6 10:00:01 2020 -0600 user32/tests: Get rid of the test for DC handle reuse. It may be useful for demonstrating cache behaviour, but fails too frequently on Windows to be reliable. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48043 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #3 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 6.10. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla