[Bug 52660] New: chunk allocator for GL uniform buffers kills performance in World of Warships
https://bugs.winehq.org/show_bug.cgi?id=52660 Bug ID: 52660 Summary: chunk allocator for GL uniform buffers kills performance in World of Warships Product: Wine Version: 7.4 Hardware: x86-64 URL: https://worldofwarships.eu/ OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-d3d Assignee: wine-bugs(a)winehq.org Reporter: janbraun(a)gmx.net Regression SHA1: 86f0ae8efb17ce688986971d24c3e25840a2beef Distribution: --- I've found and bisected a huge performance regresssion in World Of Warships: With 86f0ae8efb17ce688986971d24c3e25840a2beef "wined3d: Use the chunk allocator for GL uniform buffers." applied, my framerate is around 18-20fps during gameplay. With that patch reverted, it's back at >=60fps. The code moved around in the meantime, but simply commenting out the "case GL_UNIFORM_BUFFER:" in use_buffer_chunk_suballocation() restores performance on wine 7.4 (= current git HEAD) as well. I have the subjective impression that other games might be affected too (things feel a bit more sluggy), but certainly nowhere as severely as WoWS. I didn't further test/benchmark, however, because WoWS was such a nice reproducer. Running mesa-21.3.7 on amdgpu. Please holler if you need more info. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52660 Jan Braun <janbraun(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janbraun(a)gmx.net -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52660 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |z.figura12(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52660 Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download CC| |o.dierick(a)piezo-forte.be --- Comment #1 from Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> --- Hello, This may be linked to the performance regression introduced in bug 50235. I know the other bug affected World of Warships and The Elder Scrolls Online (and, as was reported by someone else, Sniper Elite 3). Before the recent rework of the Buffer Objects handling, I could revert two old commits and the performance was fixed. There has been too much change now and I can no longer revert those commits. Thanks for the bisect result. Regards. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52660 mirh <mirh(a)protonmail.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirh(a)protonmail.ch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52660 Ker noa <blue-t(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blue-t(a)web.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52660 Jan Braun <janbraun(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #2 from Jan Braun <janbraun(a)gmx.net> --- Fixed in wine-7.5 by eae36aab813a8627cb250d57a5bef0cf25bfb85c: "wined3d: Reuse deferred uploads heaps." -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52660 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |eae36aab813a8627cb250d57a5b | |ef0cf25bfb85c -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52660 --- Comment #3 from Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> --- Hello, I still have a performance issue in World of Warships with wine 7.5. I guess my issue was not related after all. Regards. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52660 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 7.6. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla