[Bug 39714] New: Halo some sounds in cut scenes don't play
https://bugs.winehq.org/show_bug.cgi?id=39714 Bug ID: 39714 Summary: Halo some sounds in cut scenes don't play Product: Wine Version: 1.8-rc2 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: SolisX007(a)yahoo.com Distribution: --- Halo some sounds in cut scenes don't play. I add a video of the issue. https://www.sendspace.com/file/1ilpfr -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 Lunknown <SolisX007(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|x86 |x86-64 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 --- Comment #1 from Lunknown <SolisX007(a)yahoo.com> --- You need to fast forward 30 sec in the video so you can hear where the problems starts. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 --- Comment #2 from Lunknown <SolisX007(a)yahoo.com> --- This is still an issue wine-1.8rc3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 --- Comment #3 from Lunknown <SolisX007(a)yahoo.com> --- This is still an issue in wine-1.8rc4. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 --- Comment #4 from Lunknown <SolisX007(a)yahoo.com> --- This is a regreession. wine-1.7.37 - is good. wine-1.738 - is bad. a83e8e88ea05822e21aace9e0b82060bfa1dc02f is the first bad commit commit a83e8e88ea05822e21aace9e0b82060bfa1dc02f Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sun Mar 1 14:04:56 2015 +0100 dsound: If 3d sound is disabled, just return (Coverity). :040000 040000 7e37c1b02a09ec98b095808162550d8aac51e32d a73592da95c592b5e1bb57d8c2e80141c22b8bc3 M dlls -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |marcus(a)jet.franken.de, | |sebastian(a)fds-team.de Regression SHA1| |a83e8e88ea05822e21aace9e0b8 | |2060bfa1dc02f -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aeikum(a)codeweavers.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |directx-dsound -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 --- Comment #5 from Lunknown <SolisX007(a)yahoo.com> --- Hello Everyone, Prince of Persia Warror Within also seems to have this issue in wine-1.8.2. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 --- Comment #6 from Lunknown <SolisX007(a)yahoo.com> --- This is still an issue on wine-1.9.10. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 --- Comment #7 from Lunknown <SolisX007(a)yahoo.com> --- This is still an issue on wine-1.9.11. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 --- Comment #8 from Lunknown <SolisX007(a)yahoo.com> --- This is still an issue on wine-1.9.12. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 fjfrackiewicz(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fjfrackiewicz(a)gmail.com --- Comment #9 from fjfrackiewicz(a)gmail.com --- (In reply to Lunknown from comment #8)
This is still an issue on wine-1.9.12.
Could you post the terminal output for the game for Wine 1.9.12. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 --- Comment #10 from Lunknown <SolisX007(a)yahoo.com> --- Created attachment 54697 --> https://bugs.winehq.org/attachment.cgi?id=54697 Halo-Dsound-wine-1.9.12 Ok this the log for wine-1.9.12. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 winetest(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest(a)luukku.com --- Comment #11 from winetest(a)luukku.com --- Is that truly the commit that broke the game? The only change it did was - break; + return; Maybe the commit should be reverted? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 --- Comment #12 from Lunknown <SolisX007(a)yahoo.com> --- Hello Winetest, Yes i believe i did reverted the commit to check if that was what was causing the issue. As this was part of the wine regression testing. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 winetest(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx(a)gmail.com --- Comment #13 from winetest(a)luukku.com --- Bruno any thoughts? Since the commit is so tiny change. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 --- Comment #14 from Bruno Jesus <00cpxxx(a)gmail.com> --- Can you reproduce the issue with the demo? http://www.fileplanet.com/131697/download/Halo-%5BPC%5D-Demo -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #15 from Bruno Jesus <00cpxxx(a)gmail.com> --- Confirming using the CD version of the game. Clearly returning early is affecting the game. Coverity is not wrong, Wine is using garbage memory in the calculations (printf tested) but at least you can hear the sounds. The game is much more silent due to the patch. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 --- Comment #16 from Bruno Jesus <00cpxxx(a)gmail.com> --- Created attachment 56615 --> https://bugs.winehq.org/attachment.cgi?id=56615 patch Patch to make sound work. No idea if using zero is right or not, just work. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 --- Comment #17 from Andrew Eikum <aeikum(a)codeweavers.com> --- Created attachment 56623 --> https://bugs.winehq.org/attachment.cgi?id=56623 dsound: Use the value from SetVolume when 3D processing is disabled This should fix it. In IDirectSoundBufferImpl_SetVolume, we set ds3db_lVolume but not volpan.lVolume in the 3D buffer case. DSOUND_Calc3DBuffer should recalculate lVolume from the value given to SetVolume(), but in the early-return case, we instead drop the value given to SetVolume() and retain the previously set volume, which in this case happens to be muted. This patch sets the lVolume value in DSOUND_Calc3DBuffer correctly in the early-return case. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 --- Comment #18 from winetest(a)luukku.com --- (In reply to Andrew Eikum from comment #17)
Created attachment 56623 [details] dsound: Use the value from SetVolume when 3D processing is disabled
This should fix it. In IDirectSoundBufferImpl_SetVolume, we set ds3db_lVolume but not volpan.lVolume in the 3D buffer case. DSOUND_Calc3DBuffer should recalculate lVolume from the value given to SetVolume(), but in the early-return case, we instead drop the value given to SetVolume() and retain the previously set volume, which in this case happens to be muted. This patch sets the lVolume value in DSOUND_Calc3DBuffer correctly in the early-return case.
Fix was committed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |d961f5ac7e75ccb1a5aac4f2059 | |6bf954f2d8500 --- Comment #19 from Bruno Jesus <00cpxxx(a)gmail.com> --- Fixed by d961f5ac7e75ccb1a5aac4f20596bf954f2d8500. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #20 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 2.0-rc4. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.8.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39714 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.8.x |--- --- Comment #21 from Michael Stefaniuc <mstefani(a)redhat.com> --- Removing 1.8.x milestone from bugs included in 1.8.7. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org