[Bug 27828] New: MyVirtualRoom doen't start (fixme:wininet:InternetSetOptionW Option 38 STUB)
http://bugs.winehq.org/show_bug.cgi?id=27828 Summary: MyVirtualRoom doen't start (fixme:wininet:InternetSetOptionW Option 38 STUB) Product: Wine Version: 1.3.23 Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: wininet AssignedTo: wine-bugs(a)winehq.org ReportedBy: xerox_xerox2000(a)yahoo.co.uk A user reported trouble with this app on the userforum. After starting the app it returns to the console immediately, with some fixme's: fixme:process:GetLogicalProcessorInformation ((nil),0x33fd80): stub fixme:wininet:INET_QueryOption INTERNET_OPTION_CONNECTED_STATE: semi-stub fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_CONNECTED_STATE: STUB fixme:wininet:InternetSetOptionW Option 38 STUB fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_CONNECTED_STATE: STUB Returning TRUE in InternetSetOptionW for Option 38 (INTERNET_OPTION_PROXY) like in hack below makes the app start fine. Maybe a wininet-guru could fix this bug by some minimal implementation of this option. diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c index c865368..d965aa0 100644 --- a/dlls/wininet/internet.c +++ b/dlls/wininet/internet.c @@ -2622,6 +2622,9 @@ BOOL WINAPI InternetSetOptionW(HINTERNET hInternet, DWORD case INTERNET_OPTION_DISABLE_AUTODIAL: FIXME("Option INTERNET_OPTION_DISABLE_AUTODIAL; STUB\n"); break; + case INTERNET_OPTION_PROXY: + FIXME("Option INTERNET_OPTION_PROXY; STUB\n"); + break; case INTERNET_OPTION_HTTP_DECODING: FIXME("INTERNET_OPTION_HTTP_DECODING; STUB\n"); SetLastError(ERROR_INTERNET_INVALID_OPTION); -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27828 Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://software-files- URL| |l.cnet.com/s/software/11/14 | |/59/57/MyVirtualHomeSetup.e | |xe?e=1311021926&h=416b6faa1 | |a07bba50e4b8212beacf551&lop | |=link&ptype=1901&ontid=6677 | |&siteId=4&edId=3&spi=93f2c3 | |a3759d00e758fba6fc1e67558a& | |pid=11145957&psid=10967827& | |fileName=MyVirtualHomeSetup | |.exe Summary|MyVirtualRoom doen't start |MyVirtualHome doen't start |(fixme:wininet:InternetSetO |(fixme:wininet:InternetSetO |ptionW Option 38 STUB) |ptionW Option 38 STUB) --- Comment #1 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> 2011-07-18 15:41:24 CDT --- fixed typo in title + added downloadlink -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27828 --- Comment #2 from Juan Lang <juan_lang(a)yahoo.com> 2011-07-18 17:00:08 CDT --- A minimal implementation shouldn't be so terribly hard: set the appinfo_t's accessType, proxy, and proxyBypass to whatever's passed in. Still, doing so will take a little bit of drudge work: 1. You'd probably want to add a function APPINFO_SetOption, next to APPINFO_QueryOption in internet.c. Use it to handle setting the appinfo_t's proxy settings. 2. Add APPINFO_SetOption to APPINFOVtbl. 3. For each SetOption function, call APPINFO_SetOption through the appinfo_t's vtbl. E.g., in http.c:HTTPREQ_SetOption, you'd call req->session->appInfo->hdr->vtbl->SetOption. E.g., in http.c:HTTPSESSION_SetOption, you'd call ses->appInfo->hdr->vtbl->SetOption. You could probably separate steps 1. and 2. into one patch, and step 3. into a second. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27828 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27828 Juan Lang <juan_lang(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal --- Comment #3 from Juan Lang <juan_lang(a)yahoo.com> 2011-07-18 19:42:57 CDT --- I don't believe this is minor, Austin: the app doesn't run without a code change, even if the code change is easy. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27828 --- Comment #4 from Austin English <austinenglish(a)gmail.com> 2011-07-19 10:47:04 CDT --- (In reply to comment #3)
I don't believe this is minor, Austin: the app doesn't run without a code change, even if the code change is easy.
'winetricks wininet' serves as an easy workaround, without a code change needed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27828 --- Comment #5 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> 2011-07-19 13:16:47 CDT --- (In reply to comment #2)
A minimal implementation shouldn't be so terribly hard: set the appinfo_t's accessType, proxy, and proxyBypass to whatever's passed in. Still, doing so will take a little bit of drudge work:
1. You'd probably want to add a function APPINFO_SetOption, next to APPINFO_QueryOption in internet.c. Use it to handle setting the appinfo_t's proxy settings. 2. Add APPINFO_SetOption to APPINFOVtbl. 3. For each SetOption function, call APPINFO_SetOption through the appinfo_t's vtbl.
E.g., in http.c:HTTPREQ_SetOption, you'd call req->session->appInfo->hdr->vtbl->SetOption. E.g., in http.c:HTTPSESSION_SetOption, you'd call ses->appInfo->hdr->vtbl->SetOption.
You could probably separate steps 1. and 2. into one patch, and step 3. into a second.
I had a look at code in http.c and internet.c ,but i think hacking in this field at least requires a bit of understanding about how wininet works and i never looked into this area of wine, so i don't know anything about it, so i'll leave it to someone else... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27828 --- Comment #6 from Juan Lang <juan_lang(a)yahoo.com> 2011-07-19 17:08:23 CDT --- Created an attachment (id=35611) --> (http://bugs.winehq.org/attachment.cgi?id=35611) Patch 1/2: Allow setting the proxy configuration for internet handles Here's patch 1 of what I mean. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27828 --- Comment #7 from Juan Lang <juan_lang(a)yahoo.com> 2011-07-19 17:10:36 CDT --- Created an attachment (id=35612) --> (http://bugs.winehq.org/attachment.cgi?id=35612) Patch 2/2: When setting proxy settings for a request or session, change them for their internet handle Here's patch 2 of what I mean. They're untested, other than to check whether they compile (I haven't gotten Wine to run on this new machine yet.) I'm also not certain this is entirely correct: it could be that setting the proxy settings for a request doesn't impact them for a subsequent request, for example. Tests would be needed. Louis, do these work for you? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27828 --- Comment #8 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> 2011-07-20 14:15:41 CDT ---
Louis, do these work for you?
Hi Juan, thanks for making the patches! What exectly do you mean with "do they work for you?". They do compile, but they don't fix the bug. Or is there soemthing else I should check after applying the patches? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27828 --- Comment #9 from Juan Lang <juan_lang(a)yahoo.com> 2011-07-20 14:36:43 CDT --- Ha, I wonder why they don't work? I just noticed I introduced a leak in patch 1.. out of practice. No, it's fine, if I'm serious about fixing this I need to download and test it myself. You might just send your stub in. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27828 --- Comment #10 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> 2011-07-20 14:46:06 CDT --- (In reply to comment #9)
Ha, I wonder why they don't work? I just noticed I introduced a leak in patch 1.. out of practice. No, it's fine, if I'm serious about fixing this I need to download and test it myself. You might just send your stub in.
Hi, don't know what the chances are of the stub to make it into git, but i'll give it a shot. Regards -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27828 --- Comment #11 from Juan Lang <juan_lang(a)yahoo.com> 2011-07-20 19:36:01 CDT --- Download link didn't work for me. Can you doublecheck it? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27828 Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|http://software-files- |http://download.cnet.com/My | |VirtualHome/3000-6677_4-109 | |67827.html URL|l.cnet.com/s/software/11/14 | |/59/57/MyVirtualHomeSetup.e | |xe?e=1311021926&h=416b6faa1 | |a07bba50e4b8212beacf551&lop | |=link&ptype=1901&ontid=6677 | |&siteId=4&edId=3&spi=93f2c3 | |a3759d00e758fba6fc1e67558a& | |pid=11145957&psid=10967827& | |fileName=MyVirtualHomeSetup | |.exe | --- Comment #12 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> 2011-07-21 02:34:39 CDT --- Here's the updated downlaod link. I think i copied the direct downloadlink that expires -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27828 --- Comment #13 from Juan Lang <juan_lang(a)yahoo.com> 2011-07-21 11:12:58 CDT --- Well, I see why my patches failed: it's calling InternetSetOptionW with a NULL handle, so I suppose it's expecting to set proxy settings globally. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27828 Juan Lang <juan_lang(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35611|0 |1 is obsolete| | --- Comment #14 from Juan Lang <juan_lang(a)yahoo.com> 2011-07-21 11:13:27 CDT --- (From update of attachment 35611) Introduces a leak, and doesn't fix the bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27828 Juan Lang <juan_lang(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35612|0 |1 is obsolete| | --- Comment #15 from Juan Lang <juan_lang(a)yahoo.com> 2011-07-21 11:13:41 CDT --- (From update of attachment 35612) Unrelated to the bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27828 --- Comment #16 from Juan Lang <juan_lang(a)yahoo.com> 2011-07-21 15:32:41 CDT --- I've written a patch that actually works, I'll try sending it in. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27828 --- Comment #17 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> 2011-07-21 16:32:21 CDT --- (In reply to comment #16)
I've written a patch that actually works, I'll try sending it in.
Cool, thanks -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27828 Juan Lang <juan_lang(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #18 from Juan Lang <juan_lang(a)yahoo.com> 2011-07-22 11:46:53 CDT --- Fixed by commit cfdce43de93bf66a126a297f85721a4e42b24755. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27828 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #19 from Alexandre Julliard <julliard(a)winehq.org> 2011-07-22 12:43:54 CDT --- Closing bugs fixed in 1.3.25. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org