[Bug 16777] New: EnumDisplaySettingsEx does not set DM_DISPLAYFLAGS
http://bugs.winehq.org/show_bug.cgi?id=16777 Summary: EnumDisplaySettingsEx does not set DM_DISPLAYFLAGS Product: Wine Version: 1.1.12 Platform: Other OS/Version: other Status: UNCONFIRMED Severity: minor Priority: P2 Component: winex11.drv AssignedTo: wine-bugs(a)winehq.org ReportedBy: excors(a)gmail.com I have a (non-public) application that says: EnumDisplaySettingsA(0, ENUM_CURRENT_SETTINGS, &dm); // [omitted error handling] // EnumDisplaySettings is documented to set the values of the following: const DWORD expectedFlags = DM_PELSWIDTH|DM_PELSHEIGHT|DM_BITSPERPEL|DM_DISPLAYFREQUENCY|DM_DISPLAYFLAGS; assert((dm.dmFields & expectedFlags) == expectedFlags); http://msdn.microsoft.com/en-us/library/ms533265(VS.85).aspx says: "The EnumDisplaySettings function sets values for the following five DEVMODE members: dmBitsPerPel, dmPelsWidth, dmPelsHeight, dmDisplayFlags, dmDisplayFrequency" so that behaviour is indeed documented. X11DRV_EnumDisplaySettingsEx initialises dmDisplayFlags to 0, but it does not add DM_DISPLAYFLAGS to dmFields, and so the application complains. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16777 --- Comment #1 from Austin English <austinenglish(a)gmail.com> 2009-01-03 19:00:27 --- Since you have the source code to that app, you should consider writing a conformance test to help fix it: http://wiki.winehq.org/WritingConformanceTests http://wiki.winehq.org/ConformanceTests -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16777 Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #2 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2009-01-03 19:16:16 --- Tests are not interesting here. Wine does set dmDisplayFlags so it should indicate as such. Should be a one liner patch. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16777 Dmitry Timoshkov <dmitry(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2009-01-05 10:42:59 --- This should be fixed now. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16777 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Alexandre Julliard <julliard(a)winehq.org> 2009-01-16 10:39:42 --- Closing bugs fixed in 1.1.13. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org