[Bug 57259] New: Keepass 2 automatic update dialog is broken
https://bugs.winehq.org/show_bug.cgi?id=57259 Bug ID: 57259 Summary: Keepass 2 automatic update dialog is broken Product: Wine Version: 9.18 Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: dark.shadow4(a)web.de Distribution: --- Created attachment 77175 --> https://bugs.winehq.org/attachment.cgi?id=77175 Screenshot Wine See screenshots. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57259 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |https://sourceforge.net/pro | |jects/keepass/files/KeePass | |%202.x/2.57/KeePass-2.57.zi | |p/download -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57259 --- Comment #1 from Fabian Maurer <dark.shadow4(a)web.de> --- Created attachment 77176 --> https://bugs.winehq.org/attachment.cgi?id=77176 Screenshot Windows -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57259 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zzhang(a)codeweavers.com Summary|Keepass 2 automatic update |Keepass 2 automatic update |dialog is broken |dialog is broken (uses | |Taskdialog) Component|-unknown |comctl32 --- Comment #2 from Fabian Maurer <dark.shadow4(a)web.de> --- Problem is in the line
taskdialog_get_button_size(dialog_info->command_links[i], dialog_width - x - h_spacing, &size);
It sends the message "BCM_GETIDEALSIZE" which goes down into "default_window_proc", the message never being handled. So the value for cy remains 0. Also, for some reason the buttons don't render as long as they have the "BS_COMMANDLINK" style. Zhiyi: Since you made the taskdialog, would you mind taking a look? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57259 --- Comment #3 from Fabian Maurer <dark.shadow4(a)web.de> --- I'm pretty sure, the underlying issue is that it uses the user32 button class instead of the comctl32 button class. Don't know why that would be the case though... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57259 --- Comment #4 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- (In reply to Fabian Maurer from comment #3)
I'm pretty sure, the underlying issue is that it uses the user32 button class instead of the comctl32 button class. Don't know why that would be the case though...
Probably because the application doesn't call InitCommonControls() so comctl32.dll is never loaded and the lack of a manifest to enable comctl32. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57259 --- Comment #5 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- (In reply to Fabian Maurer from comment #2)
Problem is in the line
taskdialog_get_button_size(dialog_info->command_links[i], dialog_width - x - h_spacing, &size);
It sends the message "BCM_GETIDEALSIZE" which goes down into "default_window_proc", the message never being handled. So the value for cy remains 0.
Also, for some reason the buttons don't render as long as they have the "BS_COMMANDLINK" style.
Zhiyi: Since you made the taskdialog, would you mind taking a look?
No problem. I will take a look when I have time. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57259 --- Comment #6 from Nikolay Sivov <bunglehead(a)gmail.com> --- This is working correctly if you have .NET installed. With wine-mono is does miss those buttons. I don't know if there is an easy way to test wine-mono on Windows, but this is not necessarily a comctl32 issue. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57259 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Keepass 2 automatic update |Keepass 2 automatic update |dialog is broken (uses |dialog is broken (uses |Taskdialog) |Taskdialog) | |EnableVisualStyles() from | |WinForms evidently doesn't | |work Component|comctl32 |mscoree -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57259 Esme Povirk <madewokherd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source CC| |madewokherd(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57259 --- Comment #7 from Esme Povirk <madewokherd(a)gmail.com> --- Seems like System.Windows.Forms.dll is supposed to have a manifest resource that enables them: https://gitlab.winehq.org/mono/winforms/-/blob/wine-mono/src/System.Windows.... So probably just a matter of fixing the build to include this. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57259 --- Comment #8 from Esme Povirk <madewokherd(a)gmail.com> --- Fix pushed to Wine Mono: https://gitlab.winehq.org/mono/wine-mono/-/commit/52bd5bf8c04e14a722c0494304... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57259 Esme Povirk <madewokherd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |d76b59d5c021ea5da49d1e1430c | |1d33bee874418 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #9 from Esme Povirk <madewokherd(a)gmail.com> --- Fixed in Wine Mono 10.3.0 and Wine 10.17. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57259 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #10 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 10.18. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla