[Bug 26113] New: gameux/gamestatistics shows a ton of valgrind warnings
http://bugs.winehq.org/show_bug.cgi?id=26113 Summary: gameux/gamestatistics shows a ton of valgrind warnings Product: Wine Version: 1.3.13 Platform: x86 OS/Version: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: gameux AssignedTo: wine-bugs(a)winehq.org ReportedBy: austinenglish(a)gmail.com Created an attachment (id=33291) --> (http://bugs.winehq.org/attachment.cgi?id=33291) valgrind log The first: Conditional jump or move depends on uninitialised value(s) at lstrlenW (winbase.h:2268) by GameStatisticsImpl_GetCategoryTitle (gamestatistics.c:830) by test_gamestatisticsmgr (gamestatistics.c:366) by func_gamestatistics (gamestatistics.c:446) by run_test (test.h:556) by main (test.h:624) Uninitialised value was created by a client request at mark_block_uninitialized (heap.c:208) by initialize_block (heap.c:239) by RtlAllocateHeap (heap.c:1702) by create_IGameStatistics (gamestatistics.c:1001) by GameStatisticsMgrImpl_GetGameStatistics (gamestatistics.c:1098) by test_gamestatisticsmgr (gamestatistics.c:344) by func_gamestatistics (gamestatistics.c:446) by run_test (test.h:556) by main (test.h:624) looks like a test failure that occurs under WINEDEBUG=warn+heap: gamestatistics.c:368: Test failed: getting category title failed But, there's more: 24 bytes in 3 blocks are definitely lost at notify_alloc (heap.c:254) by RtlAllocateHeap (heap.c:1701) by SysAllocStringLen (oleaut.c:235) by bstr_from_xmlChar (msxml_private.h:295) by domelem_getAttribute (element.c:1056) by GAMEUX_loadStatisticsFromFile (gamestatistics.c:514) by GAMEUX_loadGameStatistics (gamestatistics.c:630) by GameStatisticsMgrImpl_GetGameStatistics (gamestatistics.c:1107) by test_gamestatisticsmgr (gamestatistics.c:344) by func_gamestatistics (gamestatistics.c:446) by run_test (test.h:556) by main (test.h:624) ... 48 bytes in 3 blocks are definitely lost at notify_alloc (heap.c:254) by RtlAllocateHeap (heap.c:1701) by heap_alloc (msxml_private.h:420) by create_children_nodelist (nodelist.c:318) by node_get_child_nodes (node.c:246) by domelem_get_childNodes (element.c:262) by GAMEUX_loadStatisticsFromFile (gamestatistics.c:530) by GAMEUX_loadGameStatistics (gamestatistics.c:630) by GameStatisticsMgrImpl_GetGameStatistics (gamestatistics.c:1107) by test_gamestatisticsmgr (gamestatistics.c:344) by func_gamestatistics (gamestatistics.c:446) by run_test (test.h:556) by main (test.h:624) ... 120 bytes in 6 blocks are definitely lost at notify_alloc (heap.c:254) by RtlAllocateHeap (heap.c:1701) by SysAllocStringLen (oleaut.c:235) by bstr_from_xmlChar (msxml_private.h:295) by domelem_getAttribute (element.c:1056) by GAMEUX_loadStatisticsFromFile (gamestatistics.c:561) by GAMEUX_loadGameStatistics (gamestatistics.c:630) by GameStatisticsMgrImpl_GetGameStatistics (gamestatistics.c:1107) by test_gamestatisticsmgr (gamestatistics.c:344) by func_gamestatistics (gamestatistics.c:446) by run_test (test.h:556) by main (test.h:624) and a few possibly lost, as well. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26113 --- Comment #1 from Vincent Povirk <madewokherd(a)gmail.com> 2011-02-14 18:28:32 CST --- We should probably use HEAP_ZERO_MEMORY in create_IGameStatistics. We can't expect everything to be initialized by loading a file. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26113 --- Comment #2 from Austin English <austinenglish(a)gmail.com> 2011-02-14 19:02:04 CST --- (In reply to comment #1)
We should probably use HEAP_ZERO_MEMORY in create_IGameStatistics. We can't expect everything to be initialized by loading a file.
That gets rid of the first one, yeah. I'll send a patch. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26113 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |173f8d23b89ec32ba4298108d1e | |76d41fae8dc81 Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from Nikolay Sivov <bunglehead(a)gmail.com> 2012-08-27 04:43:23 CDT --- Austin, please reopen if this is not completely fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26113 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Alexandre Julliard <julliard(a)winehq.org> 2012-08-31 12:56:37 CDT --- Closing bugs fixed in 1.5.12. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org