[Bug 40474] New: Popup menus no longer close when clicking on a different window
https://bugs.winehq.org/show_bug.cgi?id=40474 Bug ID: 40474 Summary: Popup menus no longer close when clicking on a different window Product: Wine Version: 1.9.8 Hardware: x86 OS: Linux Status: NEW Keywords: regression Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs(a)winehq.org Reporter: sebastian(a)fds-team.de CC: madewokherd(a)gmail.com Regression SHA1: a9bff001a1e2c919b3f6e68d642abb8da957a2bf Distribution: --- Steps to reproduce: * Open Wines builtin "notepad" application. * Right click to open a popup menu. * Click on a different window (either Wine or native window). Expected result: * The popup menu should close again. Actual result: * The popup menu stays open until you click on the background of the same window which opened it. Bisecting returns the following commit: --- snip --- a9bff001a1e2c919b3f6e68d642abb8da957a2bf is the first bad commit commit a9bff001a1e2c919b3f6e68d642abb8da957a2bf Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Mon Mar 14 16:13:56 2016 -0500 user32: Set capture earlier on popup menus. Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- snip --- -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40474 --- Comment #1 from Vincent Povirk <madewokherd(a)gmail.com> --- Well, I feel stupid now. The X11 driver can't set the capture on a hidden window, and MENU_InitTracking is called before the popup menu is shown. Since I've proven unable to fix this limitation in the X11 driver, all I can suggest is reverting the patch. I don't know of any real programs that needed it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40474 --- Comment #2 from Sebastian Lackner <sebastian(a)fds-team.de> --- What exactly was the initial idea of that patch? Did it fix some specific bug? At least the tests do not show any difference when the patch is applied or not. If you think reverting the commit is the best option, feel free to send such a patch to the mailing list for further discussion. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40474 --- Comment #3 from Vincent Povirk <madewokherd(a)gmail.com> --- There are message tests showing that capture is set at this time, but the capture needs to be set on the owner of the popup window for the tests to pass (not currently possible because of the X11 limitation). This particular patch wasn't needed to fix a specific bug, I was just trying to make Wine's behavior as close to native as I could. I was working on a specific bug, but the fix didn't require this change. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40474 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |3cc6a1acc31161be0f14d81c588 | |faeb0022e2e6d Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Sebastian Lackner <sebastian(a)fds-team.de> --- Fixed with 3cc6a1acc31161be0f14d81c588faeb0022e2e6d. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40474 sworddragon2(a)aol.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sworddragon2(a)aol.com --- Comment #5 from sworddragon2(a)aol.com --- Hm, it would be convenient if this bugzilla would auto-link the metadata fields containing commit hashes and ideally doing the same on comments as many users would probably even not find http://source.winehq.org/git/wine.git/ . But searching this hash does currently not show any results for whatever reason. But thats not so important now, was just a bit nosy what actually got changed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40474 --- Comment #6 from Ken Thomases <ken(a)codeweavers.com> --- (In reply to sworddragon2 from comment #5)
Hm, it would be convenient if this bugzilla would auto-link the metadata fields containing commit hashes and ideally doing the same on comments as many users would probably even not find http://source.winehq.org/git/wine.git/ . But searching this hash does currently not show any results for whatever reason. But thats not so important now, was just a bit nosy what actually got changed.
It's a little non-obvious, because it seems like it would be giving help on the meaning of the field, but clicking on the "Fixed by SHA1" label takes you to the commit. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40474 --- Comment #7 from sworddragon2(a)aol.com --- Thanks for the hint as I have indeed thought that this combination of a question mark with an arrow is the help for the related metadata field. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40474 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #8 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.9.9. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org