[Bug 57987] New: The Queen of Heart 99 SE : Config.exe crashes when before saving and quitting
https://bugs.winehq.org/show_bug.cgi?id=57987 Bug ID: 57987 Summary: The Queen of Heart 99 SE : Config.exe crashes when before saving and quitting Product: Wine Version: 10.3 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comctl32 Assignee: wine-bugs(a)winehq.org Reporter: riyu12383(a)gmail.com Distribution: --- Created attachment 78237 --> https://bugs.winehq.org/attachment.cgi?id=78237 Backtrace of the crash Same game as https://bugs.winehq.org/show_bug.cgi?id=57283. Config.exe is used to edit the configuration settings such as the full-screen or windowed mode. However when pressing "OK" it crashes before saving. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57987 YuriK7 <riyu12383(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The Queen of Heart 99 SE : |The Queen of Heart 99 SE : |Config.exe crashes when |Config.exe crashes just |before saving and quitting |before saving and quitting -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57987 --- Comment #1 from YuriK7 <riyu12383(a)gmail.com> --- Proposed patch : https://gitlab.winehq.org/wine/wine/-/merge_requests/7622 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57987 --- Comment #2 from Nikolay Sivov <bunglehead(a)gmail.com> --- Could you attach +propsheet log? It's not clear to me why this would happen. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57987 --- Comment #3 from YuriK7 <riyu12383(a)gmail.com> --- Created attachment 78252 --> https://bugs.winehq.org/attachment.cgi?id=78252 Logs with propsheet debug channel Here's the logs with +propsheet. Naively I would think that NULL is returned because the window was closed too soon for the DoCommand function ? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57987 KRosUser <kyle.kcsoftwares(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.kcsoftwares(a)gmail.com --- Comment #4 from KRosUser <kyle.kcsoftwares(a)gmail.com> --- Similar weakness in PROPSHEET_Finish and proof of concept here https://jira.reactos.org/browse/CORE-9555 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57987 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #5 from Nikolay Sivov <bunglehead(a)gmail.com> --- (In reply to YuriK7 from comment #3)
Created attachment 78252 [details] Logs with propsheet debug channel
Here's the logs with +propsheet. Naively I would think that NULL is returned because the window was closed too soon for the DoCommand function ?
Yes, I think what happens is that Apply() involves calling back to the parent for notifications, and parent code has ability to destroy the dialog window. So what you get is WM_COMMAND (Apply) -> WM_NOTIFY to parent -> DestroyWindow/EndDialog -> WM_DESTROY cleans up -> return to the WM_COMMAND handler now with dialog data not longer available. I think it safe to assume we have to check for nulls basically everywhere when calling back is possible. But let's do one change at a time. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57987 --- Comment #6 from KRosUser <kyle.kcsoftwares(a)gmail.com> --- So you plan to have several MR coming for this ? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57987 --- Comment #7 from Nikolay Sivov <bunglehead(a)gmail.com> --- (In reply to KRosUser from comment #6)
So you plan to have several MR coming for this ?
Not right away. If we'll get reports with actual crashes, then sure. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57987 --- Comment #8 from KRosUser <kyle.kcsoftwares(a)gmail.com> --- Some evidence in the ReactOS context here : https://jira.reactos.org/browse/CORE-9555 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57987 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |affd5177bba907a015d1c6fc8ac | |9970731125268 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #9 from Nikolay Sivov <bunglehead(a)gmail.com> --- Marking fixed affd5177bba907a015d1c6fc8ac9970731125268. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57987 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #10 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 10.5. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla