[Bug 38221] New: Wrong parameter assignment in get_family_names_from_stream()
https://bugs.winehq.org/show_bug.cgi?id=38221 Bug ID: 38221 Summary: Wrong parameter assignment in get_family_names_from_stream() Product: Wine Version: 1.7.38 Hardware: x86 OS: Mac OS X Status: UNCONFIRMED Severity: normal Priority: P2 Component: dwrite Assignee: wine-bugs(a)winehq.org Reporter: isakov-sl(a)bk.ru File /dll/dwrite/font.c: line 786 In function HRESULT get_family_names_from_stream(IDWriteFontFileStream *stream, UINT32 index, DWRITE_FONT_FACE_TYPE facetype, IDWriteLocalizedStrings **names) there is an assignment names=NULL; There is no sense to assign a value to function parameter. I think there should be ~~~~ *names = NULL; ~~~~ -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38221 --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> --- Good catch. Would you care to send a patch or should I? (note that there's a bit more about it than fixing assignment). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38221 --- Comment #2 from Sergey <isakov-sl(a)bk.ru> --- (In reply to Nikolay Sivov from comment #1)
Good catch. Would you care to send a patch or should I? (note that there's a bit more about it than fixing assignment).
Yes, I made more patched but out of the bug. diff attached. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38221 --- Comment #3 from Sergey <isakov-sl(a)bk.ru> --- Created attachment 51021 --> https://bugs.winehq.org/attachment.cgi?id=51021 patch for parameter assignment -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38221 --- Comment #4 from Nikolay Sivov <bunglehead(a)gmail.com> --- (In reply to Sergey from comment #3)
Created attachment 51021 [details] patch for parameter assignment
That's not how it works. First of all patches are not picked up from bugzilla, second - unrelated changes should be split to several patches. And both dwrite changes are wrong. If you want to send them first read http://wiki.winehq.org/SubmittingPatches, and consider using #winehackers channel or wine-devel list, bugzilla is not meant to be used for patch reviews. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38221 --- Comment #5 from Sergey <isakov-sl(a)bk.ru> --- (In reply to Nikolay Sivov from comment #1)
Good catch. Would you care to send a patch or should I? (note that there's a bit more about it than fixing assignment).
I think it will be better you create and send appropriate patch. I just point you to a possible bug. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38221 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #6 from Nikolay Sivov <bunglehead(a)gmail.com> --- (In reply to Sergey from comment #5)
(In reply to Nikolay Sivov from comment #1)
Good catch. Would you care to send a patch or should I? (note that there's a bit more about it than fixing assignment).
I think it will be better you create and send appropriate patch. I just point you to a possible bug.
Okay, will do. Thanks for the report. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38221 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |5eccb1322d09362c5431911bcdc | |5a4d218ee98fb Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #7 from Nikolay Sivov <bunglehead(a)gmail.com> --- Fixed with 5eccb1322d09362c5431911bcdc5a4d218ee98fb. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38221 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #8 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.7.39. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org