[Bug 58800] New: tlReader 10.1.0.2004 toolbar has broken rendering
http://bugs.winehq.org/show_bug.cgi?id=58800 Bug ID: 58800 Summary: tlReader 10.1.0.2004 toolbar has broken rendering Product: Wine Version: unspecified Hardware: x86-64 URL: https://web.archive.org/web/20251013233829/https://tsh wanedje.com/builds/2004/tlReader_10.1.0.2004.exe OS: Linux Status: NEW Keywords: download Severity: normal Priority: P2 Component: comctl32 Assignee: wine-bugs(a)winehq.org Reporter: arethusa26(a)gmail.com CC: zzhang(a)codeweavers.com Regression SHA1: 541d9be5ecda1bc0c8fce22f1318bf5d72572327 Distribution: --- Created attachment 79445 --> http://bugs.winehq.org/attachment.cgi?id=79445 Broken toolbar rendering With the latest master (wine-10.16-212-g6124fea1dde), when loading the Manx-English dictionary (available from https://tshwanedje.com/downloads/files/Manx_English_Phil_Kelly_Dec2014.zip), the toolbar at the top of the tlReader application appears to have some rendering defects. Specifically, the background color of the toolbar has a darker color, and there is a stray horizontal line that is visible and appears to intersect the tops of the toolbar icons. Additionally, hovering the cursor over the icons results in a blue box that is drawn around a hovered icon but is not cleared when the cursor leaves the icon. With wine-10.16, the rendering of the toolbar seems to be more correct. The background color apparently resembles the color on Windows 10, no stray horizontal line is visible on the toolbar, and hovering over the toolbar icons with the cursor results in a blue box being drawn around a hovered icon that is cleared when the cursor leaves the icon. These behaviors are consistent with what is seen on Windows 10. Regression testing identified commit 541d9be5ecda1bc0c8fce22f1318bf5d72572327, which implemented the final modifications needed for comctl32 separation, as the change that introduced the broken toolbar rendering. However, it's not clear if the toolbar rendering issue is a new introduced problem or if it was previously hidden and now exposed with the comctl32 separation. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58800 --- Comment #1 from Andrew Nguyen <arethusa26(a)gmail.com> --- Created attachment 79446 --> http://bugs.winehq.org/attachment.cgi?id=79446 Good toolbar rendering -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58800 --- Comment #2 from Andrew Nguyen <arethusa26(a)gmail.com> --- Created attachment 79447 --> http://bugs.winehq.org/attachment.cgi?id=79447 Toolbar rendering on Windows 10 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58800 LingM <lingm+winebz(a)posteo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lingm+winebz(a)posteo.org --- Comment #3 from LingM <lingm+winebz(a)posteo.org> --- Stable download link for the dictionary: https://web.archive.org/web/20161125113440/https://tshwanedje.com/downloads/...
$ sha1sum Manx_English_Phil_Kelly_Dec2014.zip 0f28ae8cebcbd7bfc26dacb2bc492da680389530 Manx_English_Phil_Kelly_Dec2014.zip $ du -h Manx_English_Phil_Kelly_Dec2014.zip 6,9M Manx_English_Phil_Kelly_Dec2014.zip
-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58800 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wine-bugs(a)list.winehq.org |zzhang(a)codeweavers.com --- Comment #4 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Looking into this. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58800 --- Comment #5 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- The bad commit is 5e70fef5, not 541d9be5. commit 5e70fef56506c5584f05e1b01987cdf248311549 (HEAD) Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Oct 9 12:59:46 2025 +0200 setupapi: Use the actual source name when registering a manifest. The module name in the manifest may be different (e.g. comctl32 v6). dlls/setupapi/fakedll.c | 31 +++++++++++-------------------- 1 file changed, 11 insertions(+), 20 deletions(-) I will see what's wrong. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58800 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1|541d9be5ecda1bc0c8fce22f131 |5e70fef56506c5584f05e1b0198 |8bf5d72572327 |7cdf248311549 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58800 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1|5e70fef56506c5584f05e1b0198 |541d9be5ecda1bc0c8fce22f131 |7cdf248311549 |8bf5d72572327 --- Comment #6 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- (In reply to Zhiyi Zhang from comment #5)
The bad commit is 5e70fef5, not 541d9be5.
commit 5e70fef56506c5584f05e1b01987cdf248311549 (HEAD) Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Oct 9 12:59:46 2025 +0200
setupapi: Use the actual source name when registering a manifest.
The module name in the manifest may be different (e.g. comctl32 v6).
dlls/setupapi/fakedll.c | 31 +++++++++++-------------------- 1 file changed, 11 insertions(+), 20 deletions(-)
I will see what's wrong.
I was wrong. The bad commit is indeed 541d9be5. Somehow, I had to clean up the build dir for each commit to get the correct result. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58800 --- Comment #7 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Created attachment 79667 --> http://bugs.winehq.org/attachment.cgi?id=79667 PoC patch This bug occurs because wxWidgets expects a WM_ERASEBKGND message when handling the WM_PAINT message. See https://github.com/wxWidgets/wxWidgets/blob/master/src/msw/toolbar.cpp#L2248. The attached PoC patch fixes it. I will add tests and send a proper fix soon. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58800 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |f21e5d5ac72ea27854613b14c99 | |832e6de330b06 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #8 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Fixed by https://gitlab.winehq.org/wine/wine/-/merge_requests/9490. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58800 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|zzhang(a)codeweavers.com |wine-bugs(a)list.winehq.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58800 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #9 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 10.20. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla