[Bug 50163] New: Regression: Stack overflow in Mod Organizer 2
https://bugs.winehq.org/show_bug.cgi?id=50163 Bug ID: 50163 Summary: Regression: Stack overflow in Mod Organizer 2 Product: Wine Version: 5.22 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: msvcrt Assignee: wine-bugs(a)winehq.org Reporter: rtpublic1(a)gmail.com Distribution: --- Created attachment 68680 --> https://bugs.winehq.org/attachment.cgi?id=68680 Patch reverting the bad commit on top of 5.22 Since commit df2b13fa77172953fed6e15c65fd6380b2d2f0d3, Mod Organizer 2 experiences a stack overflow during startup in the Python plugin (enabled by default). df2b13fa77172953fed6e15c65fd6380b2d2f0d3 is the first bad commit commit df2b13fa77172953fed6e15c65fd6380b2d2f0d3 Author: Chip Davis <cdavis(a)codeweavers.com> Date: Wed Nov 18 17:26:33 2020 +0100 msvcrt: Increment refcounts for all locale data in _get_current_locale(). Signed-off-by: Chip Davis <cdavis(a)codeweavers.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> dlls/msvcr90/tests/msvcr90.c | 52 ++++++++++++++++++++------------------------ dlls/msvcrt/locale.c | 19 +++++++++++++--- 2 files changed, 39 insertions(+), 32 deletions(-) The previous commit (16598c2af6ddf0e32c5c72b9067cd2f40a470591) works. Also, reverting the bad commit on top of 5.22 works. The reverting patch is attached, just in case. Installer download: https://github.com/ModOrganizer2/modorganizer/releases/download/v2.3.2/Mod.O... $ md5sum Mod.Organizer-2.3.2.exe ca0b3a364bc5cac33299b14202e28620 Mod.Organizer-2.3.2.exe The installer tries to download "Visual C++ 2015-2019 Redistributable (x64)" and install it. Installation may or may not fail, I have not found any pattern here. If installing fails, click Ignore to continue. It does not affect the stack overflow either way. After installing, start C:\\Modding\\MO2\\ModOrganizer.exe. If you get asked to choose an "instance", select "Portable". The first time, you may get a crash with some .NET exception. That is a separate issue. Restart MO2, and it will ask you to disable the csharp plugin. Do so to avoid that crash. If you get a window asking to select a game, or asking, the stack overflow does not appear and the issue is gone. If you restart after the stack overflow, MO2 will ask to disable the python plugin (say no) and whether you wish to reinitialize the plugin (say yes to cause the crash again). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 --- Comment #1 from rtpublic1(a)gmail.com --- Created attachment 68681 --> https://bugs.winehq.org/attachment.cgi?id=68681 Console output when running v5.22 without reverting (stack overflow) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 --- Comment #2 from rtpublic1(a)gmail.com --- Created attachment 68682 --> https://bugs.winehq.org/attachment.cgi?id=68682 Console output when running v5.22 plus reverting the bad commit (no stack overflow) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 rtpublic1(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Regression SHA1| |df2b13fa77172953fed6e15c65f | |d6380b2d2f0d3 Distribution|--- |ArchLinux -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cdavis5x(a)gmail.com, | |piotr.caban(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 --- Comment #3 from Piotr Caban <piotr.caban(a)gmail.com> --- I guess it's because we don't increase the locale->locinfo->lc_category[i].wrefcount in get_current_locale. I'll test with the application before sending the patch. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ankouslash(a)yahoo.co.jp --- Comment #4 from Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> --- *** Bug 50170 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Regression: Stack overflow |Multiple applications crash |in Mod Organizer 2 |with a stack overflow (Mod | |Organizer 2, World of | |Tanks) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |o.dierick(a)piezo-forte.be Status|UNCONFIRMED |NEW Ever confirmed|0 |1 URL| |https://github.com/ModOrgan | |izer2/modorganizer/releases | |/tag/v2.3.2 Keywords| |download --- Comment #5 from Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> --- Hello, Also affects World of Tanks (duplicate bug 50170). Mod Organizer 2 is a smaller download. Adding link and download keyword and confirming. Regards. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabienmoal(a)wanadoo.fr --- Comment #6 from Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> --- *** Bug 50164 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Multiple applications crash |Multiple applications crash |with a stack overflow (Mod |with a stack overflow (Mod |Organizer 2, World of |Organizer 2, World of |Tanks) |Tanks, SWTOR) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 Piotr Caban <piotr.caban(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |aa8891783046459508f91f47cc5 | |88b35ee8dea4e Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #7 from Piotr Caban <piotr.caban(a)gmail.com> --- Both Mod Organizer and SWTOR is fixed by aa8891783046459508f91f47cc588b35ee8dea4e. I didn't test World of Tanks. Marking as fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 --- Comment #8 from Mario Motohashi <ankouslash(a)yahoo.co.jp> --- (In reply to Piotr Caban from comment #7)
Both Mod Organizer and SWTOR is fixed by aa8891783046459508f91f47cc588b35ee8dea4e. I didn't test World of Tanks. Marking as fixed.
WoT works as well. Thx -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 Vijay Kamuju <infyquest(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kjandrews0(a)gmail.com --- Comment #9 from Vijay Kamuju <infyquest(a)gmail.com> --- *** Bug 50185 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 Chris Xiong <chirs241097(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chirs241097(a)gmail.com --- Comment #10 from Chris Xiong <chirs241097(a)gmail.com> --- *** Bug 50178 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aros(a)gmx.com --- Comment #11 from Nikolay Sivov <bunglehead(a)gmail.com> --- *** Bug 50188 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Multiple applications crash |Multiple applications crash |with a stack overflow (Mod |with a stack overflow (Mod |Organizer 2, World of |Organizer 2, World of |Tanks, SWTOR) |Tanks, SWTOR, Audacity) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #12 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 6.0-rc1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winehq.org(a)eternaldusk.com --- Comment #13 from Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> --- *** Bug 50219 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |monsterovich(a)gmail.com --- Comment #14 from Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> --- *** Bug 50300 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dudul04(a)yahoo.fr --- Comment #15 from Alexandre Julliard <julliard(a)winehq.org> --- *** Bug 50165 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |n296869(a)rtrtr.com --- Comment #16 from Alexandre Julliard <julliard(a)winehq.org> --- *** Bug 50478 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |htl10(a)users.sourceforge.net --- Comment #17 from Alexandre Julliard <julliard(a)winehq.org> --- *** Bug 50476 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50163 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |focht(a)gmx.net URL|https://github.com/ModOrgan |https://web.archive.org/202 |izer2/modorganizer/releases |10201210332/https://github. |/tag/v2.3.2 |com/ModOrganizer2/modorgani | |zer/releases/download/v2.3. | |2/Mod.Organizer-2.3.2.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla