[Bug 22744] New: Incoming: missing textures, blocky characters
http://bugs.winehq.org/show_bug.cgi?id=22744 Summary: Incoming: missing textures, blocky characters Product: Wine Version: 1.1.44 Platform: x86 URL: http://download.cnet.com/Incoming-demo/3000-7563_4-100 18278.html OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: gyebro69(a)gmail.com Created an attachment (id=28039) --> (http://bugs.winehq.org/attachment.cgi?id=28039) console log Incoming (also known as Incoming: The Final Conflict) is a good old 3D shooter from 1998. It doesn't render textures correctly: characters in the menu are just colored blocks, in the main game whole textures are missing etc. Appdb link: http://appdb.winehq.org/objectManager.php?sClass=version&iId=6534 The demo also shows the same issues. According to Appdb the game rendered textures correctly around 0.9.15. That's a very old version. 0.9.38: the game doesn't even start for me, 0.9.61: the game shows the same problems as in the current 1.1.44. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 GyB <gyebro69(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 --- Comment #1 from GyB <gyebro69(a)gmail.com> 2010-08-29 12:03:35 CDT --- Created an attachment (id=30469) --> (http://bugs.winehq.org/attachment.cgi?id=30469) screenshot The same in Wine-1.3.1 I attached a screenshot showing the issue. Nvidia 7600 / driver 256.44 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 --- Comment #2 from Wylda <wylda(a)volny.cz> 2010-09-12 04:53:01 CDT --- Created an attachment (id=30708) --> (http://bugs.winehq.org/attachment.cgi?id=30708) Screen shot showing the problem
According to Appdb the game rendered textures correctly around 0.9.15.
Good catch. I normally don't watch attached screen shots at AppDB ;) As i don't like regression, i gave this one a try. Probably hardest regression test ever made... So some textures are missing and also notice from attached screen shot, that graphics is also distorted (missile locked airplane, unreadable font). 1. I did several regression tests between 0.9.15 and 0.9.41. Particular commit(wine-0.9.36-240-gd9fef10): commit d9fef10b71b9add27cfaeffa6d7e3ab42342bba7 Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Wed May 9 11:49:27 2007 +0200 ddraw: Some caps fixes. Cards at DirectX7 times did not support non power of 2 textures, and some games check the capatiblity flags incorrectly. Rollcage expects the D3DPTEXTURECAPS_POW2 (limitation) flag set and fails with the reference rasterizer which support NP2 textures and doesn't have the cap set. 2. There are another bug reports suffering from this commit, see bug 9665, bug 10133, bug 10164, bug 21878. 3. Revert of this patch after git checkout makes that problem go away (can't be tested directly). Attached hack proves correctness of regressions test. 4. Adding author of this patch to CC. --private keyword: bisected -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 --- Comment #3 from Wylda <wylda(a)volny.cz> 2010-09-12 04:56:03 CDT --- Created an attachment (id=30709) --> (http://bugs.winehq.org/attachment.cgi?id=30709) Hack for wine-1.3.2 Minimal fix/hack for wine-1.3.2 proving correctness of regression test above. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 Wylda <wylda(a)volny.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Status|UNCONFIRMED |NEW CC| |stefan(a)codeweavers.com, | |wylda(a)volny.cz Component|-unknown |directx-ddraw Version|1.1.44 |0.9.37. Ever Confirmed|0 |1 --- Comment #4 from Wylda <wylda(a)volny.cz> 2010-09-12 04:58:32 CDT --- Filling some fields... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 --- Comment #5 from Wylda <wylda(a)volny.cz> 2010-09-19 07:27:57 CDT --- This regression (bisected) is still present in wine-1.3.3. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 --- Comment #6 from Wylda <wylda(a)volny.cz> 2011-01-22 17:41:07 CST --- This regression (bisected) is still present in wine-1.3.12. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 --- Comment #7 from Wylda <wylda(a)volny.cz> 2011-06-20 16:07:14 CDT --- This regression (bisected) is still present in wine-1.3.22-255-g4c0c0d3. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 Christian Weiske <cweiske(a)cweiske.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cweiske(a)cweiske.de -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 --- Comment #8 from Wylda <wylda(a)volny.cz> 2011-07-15 16:01:17 CDT --- This regression (bisected) is still present in wine-1.3.24-174-g4b4dd30. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 GyB <gyebro69(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |d9fef10b71b9add27cfaeffa6d7 | |e3ab42342bba7 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 --- Comment #9 from Stefan Dösinger <stefan(a)codeweavers.com> 2011-10-15 10:34:09 CDT --- I don't have any luck with the demo download. I guess cnet wraps the demo in some app that uses IE to display some more ads and fails to run. I haven't found any alternative download, maybe the upx packer can get me the contents of that file. Otherwise it'll have to wait until I boot Windows again. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 --- Comment #10 from Austin English <austinenglish(a)gmail.com> 2011-10-17 12:31:30 CDT --- (In reply to comment #9)
I don't have any luck with the demo download. I guess cnet wraps the demo in some app that uses IE to display some more ads and fails to run. I haven't found any alternative download, maybe the upx packer can get me the contents of that file. Otherwise it'll have to wait until I boot Windows again.
That's bug 28601. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 --- Comment #11 from Stefan Dösinger <stefan(a)codeweavers.com> 2011-10-17 13:23:15 CDT --- The cnet downloader is indeed a "safe, trusted, and spyware free" app that puts the cnet logo on my screen and on my desktop, and wants to install a browser toolbar. But with the help of Windows I could download the actual Incoming demo, and I can reproduce the problem. The game uses Direct3D 1 with Executebuffers, but doesn't use d3drm.dll. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 --- Comment #12 from Stefan Dösinger <stefan(a)codeweavers.com> 2011-10-17 13:58:45 CDT --- The hack works for me, but what also works is not enumerating the RGB device at all. It seems that the game picks up the first device that is enumerated, and wants D3DPTEXTURECAPS_PERSPECTIVE set on the hal caps, otherwise it things the device doesn't support textures. Not setting D3DPTEXTURECAPS_PERSPECTIVE on the RGB device is correct, the d9fef10b71 added tests for that and those tests still exist and pass on Windows. I'll see if it is correct to enumerate the RGB device at all. Any changes will need to be checked against Rollcage, MotoRacer and GTA 2 and the other applications that have issues with the d3d device caps. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 Stefan Dösinger <stefan(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30709|0 |1 is obsolete| | --- Comment #13 from Stefan Dösinger <stefan(a)codeweavers.com> 2011-10-17 15:21:15 CDT --- Created attachment 36961 --> http://bugs.winehq.org/attachment.cgi?id=36961 ddraw: Set correct HEL and HAL color models Please give this patch a try. Disassembling the game's enumeration callback shows that the first thing it does is check if the hal descriptor's dcmColorModel field is 0 and ignores the device in that case. This way it skips the RGB emulation device and proceeds to the HAL device, which has the required D3DPTEXTURECAPS_PERSPECTIVE flag set. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 --- Comment #14 from GyB <gyebro69(a)gmail.com> 2011-10-17 21:09:51 CDT --- (In reply to comment #13)
Created attachment 36961 [details] ddraw: Set correct HEL and HAL color models
Please give this patch a try. Disassembling the game's enumeration callback shows that the first thing it does is check if the hal descriptor's dcmColorModel field is 0 and ignores the device in that case. This way it skips the RGB emulation device and proceeds to the HAL device, which has the required D3DPTEXTURECAPS_PERSPECTIVE flag set.
The patch worked here and textures now appear correctly. Tested with the GoG.com version of the game and wine-1.3.30-205-g472a8f7. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 Stefan Dösinger <stefan(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |9e0baa55cec232656048c972e94 | |a9dc2a15ec30b Status|NEW |RESOLVED Resolution| |FIXED --- Comment #15 from Stefan Dösinger <stefan(a)codeweavers.com> 2011-11-17 11:59:11 CST --- The patch is in Wine now, this bug should be fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #16 from Alexandre Julliard <julliard(a)winehq.org> 2011-11-18 13:04:23 CST --- Closing bugs fixed in 1.3.33. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|directx-ddraw |directx-d3d -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22744 --- Comment #17 from Wylda <wylda(a)volny.cz> 2011-12-03 06:45:21 CST --- Yups, fixed for me too :) Tested under 1.3.34. Thanks Stefan. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs@winehq.org