[Bug 45599] New: Support for FILE_FLAG_WRITE_THROUGH in CreateFile breaks Wargaming.net Game Center
https://bugs.winehq.org/show_bug.cgi?id=45599 Bug ID: 45599 Summary: Support for FILE_FLAG_WRITE_THROUGH in CreateFile breaks Wargaming.net Game Center Product: Wine-staging Version: unspecified Hardware: x86 URL: http://redirect.wargaming.net/WGC/Wargaming_Game_Cente r_Install_TWA_EU.exe OS: Linux Status: NEW Keywords: download, regression Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: dark.shadow4(a)web.de CC: leslie_alistair(a)hotmail.com, z.figura12(a)gmail.com Distribution: --- The program closes with the message "Unable to launch the application because of critical errors." Guilty patch is "ml-patches/0027-kernel32-Add-support-for-FILE_FLAG_WRITE_THROUGH-to-.patch" - reverting it fixes the issue. To test just run the installer and then run "drive_c/Program Files/Wargaming.net/GameCenter/wgc.exe" in a fresh(!) WINEPREFIX. Running the program without the guilty patch, and then with the guilty patch again seems to fix the issue, also. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45599 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |45593 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45599 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dmitry(a)baikal.ru -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45599 --- Comment #1 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- Apparently O_DIRECT adds strict requirement of an aligned buffer passed to write/pwrite and current code simply is not prepared for that. This patch set should be fixed by removing the server part (and completely omitting the O_DIRECT requirements as a result). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45599 varris(a)protonmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |varris(a)protonmail.com --- Comment #2 from varris(a)protonmail.com --- *** Bug 45604 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45599 --- Comment #3 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- (In reply to Dmitry Timoshkov from comment #1)
Apparently O_DIRECT adds strict requirement of an aligned buffer passed to write/pwrite and current code simply is not prepared for that. This patch set should be fixed by removing the server part (and completely omitting the O_DIRECT requirements as a result).
I assume you will post another set of patches at some point. I'd be happy to include them in staging if you want to get them tested before up-streaming them. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45599 --- Comment #4 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- I've dropped that set of patches from staging for the time being. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45599 --- Comment #5 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to Alistair Leslie-Hughes from comment #3)
(In reply to Dmitry Timoshkov from comment #1)
Apparently O_DIRECT adds strict requirement of an aligned buffer passed to write/pwrite and current code simply is not prepared for that. This patch set should be fixed by removing the server part (and completely omitting the O_DIRECT requirements as a result).
I assume you will post another set of patches at some point. I'd be happy to include them in staging if you want to get them tested before up-streaming them.
As I already pointed out the real culprit is the wineserver patch that has added O_DIRECT to the open() flags. Other patches in the series should be fine and don't need a resend. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45599 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |45613 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45599 --- Comment #6 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- Can this be closed now that the patchset has been dropped from Staging? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45599 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|45593 | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45599 zzzzzyzz(a)hacari.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zzzzzyzz(a)hacari.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45599 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |39cafb1db19c9de19fea69b582e | |e703ef7c557e7 Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #7 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- Marking FIXED as the issue was solved by dropping the patches from staging. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45599 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #8 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Closing Fixed Staging bugs. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org