[Bug 51971] New: postgresql-9.3 installer needs scrrun:folder_CreateTextFile implementation
https://bugs.winehq.org/show_bug.cgi?id=51971 Bug ID: 51971 Summary: postgresql-9.3 installer needs scrrun:folder_CreateTextFile implementation Product: Wine Version: 6.20 Hardware: x86-64 URL: https://web.archive.org/web/20211009084355if_/https:// get.enterprisedb.com/postgresql/postgresql-9.3.25-1-wi ndows-x64.exe OS: Linux Status: NEW Keywords: download Severity: normal Priority: P2 Component: scrrun Assignee: wine-bugs(a)winehq.org Reporter: sloper42(a)yahoo.com Distribution: --- This is followup from https://bugs.winehq.org/show_bug.cgi?id=51911 Test with postgresql-9.3 installer from [1]. It runs a script during installation similar to https://github.com/three-plus-three/tpt_env_amd64/blob/master/postgresql/ins... that reports non-critical error to main install, script itself terminates. This part ' Execute a command Function DoCmd(strCmd) Dim objBatchFile Set objBatchFile = objTempFolder.CreateTextFile(strBatchFile, True) objBatchFile.WriteLine "@ECHO OFF" ... leads to fixme:scrrun:folder_CreateTextFile (0000000000075E90)->(L"rad36105.tx" ffffffff 0 000000000064EF60): stub [1] https://www.enterprisedb.com/postgresql-tutorial-resources-training?cid=340 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51971 --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> --- This should be easy to implement, we have CreateTextFile() variant that takes full path already. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51971 --- Comment #2 from Robert Wilhelm <sloper42(a)yahoo.com> --- Nikolay, I plan to submit a patch during next days if you do not beat me :-) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51971 --- Comment #3 from Nikolay Sivov <bunglehead(a)gmail.com> --- Please do, I'm not going to. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51971 Robert Wilhelm <sloper42(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #4 from Robert Wilhelm <sloper42(a)yahoo.com> --- I submitted some patches for review: https://source.winehq.org/patches/data/220836 https://source.winehq.org/patches/data/220837 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51971 --- Comment #5 from Nikolay Sivov <bunglehead(a)gmail.com> --- Robert, is this now fixed? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51971 Robert Wilhelm <sloper42(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |4c04fb00f03a40d122bb4d8ae73 | |a1d8be3b3b677 --- Comment #6 from Robert Wilhelm <sloper42(a)yahoo.com> --- This is now fixed with https://source.winehq.org/git/wine.git/commit/4c04fb00f03a40d122bb4d8ae73a1d... Nikolay, thanks for the reviews. Hoever there are other issues which need fixes: 1) strBatchFile = Replace(objFso.GetTempName, ".tmp", ".bat") is not working, because GetTempName returns "rad12345.tx". This should be trivial to change. 2) When executing the *.bat file, it runs into https://bugs.winehq.org/show_bug.cgi?id=44063 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51971 --- Comment #7 from Nikolay Sivov <bunglehead(a)gmail.com> --- (In reply to Robert Wilhelm from comment #6)
This is now fixed with https://source.winehq.org/git/wine.git/commit/ 4c04fb00f03a40d122bb4d8ae73a1d8be3b3b677
Nikolay, thanks for the reviews.
Hoever there are other issues which need fixes:
1)
strBatchFile = Replace(objFso.GetTempName, ".tmp", ".bat") is not working, because GetTempName returns "rad12345.tx". This should be trivial to change.
Looks like it, I don't know why it's using .txt right now. Also note that it's truncated to .tx, because swprintf() buffer length is 1 char too short. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51971 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #8 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 6.23. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla