[Bug 34108] New: Rally Trophy: Controller configuration is very buggy
http://bugs.winehq.org/show_bug.cgi?id=34108 Bug #: 34108 Summary: Rally Trophy: Controller configuration is very buggy Product: Wine Version: 1.6 Platform: x86-64 URL: http://games.softpedia.com/get/Games-Demo/Rally-Trophy .shtml OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-dinput AssignedTo: wine-bugs(a)winehq.org ReportedBy: jettis(a)gmail.com Classification: Unclassified Created attachment 45353 --> http://bugs.winehq.org/attachment.cgi?id=45353 Rally Trophy log trace+dinput Rally Trophy uses DirectInput's device configuration window. There are some bugs that make device configuration difficult and for example a racing wheel impossible to use. Device configuration usually doesn't show the currently mapped keys for keyboard especially when a racing wheel is connected. If it shows they are only default keys and not the currently mapped keys. If a function is already mapped to a key by you, you can't change it to an another key anymore. For example you set 'shift up' to 's' key and go to play, then you go back to device configuration and set 'shift up' to 'd' key and again go to play. You will notice that 'd' key does not change a gear. In full version of Rally Trophy the key mappings are saved, but in Rally Trophy Demo in wine they are not. The keys are always the default ones when you start the game. In Windows you can select a player (Pelaaja 1/Player 1) for the device when you want to use it. Wine does not see the player and shows only a blank list, so you can't get a racing wheel in to use. However a racing wheel becomes usable if keyboard and mouse enumeration is deleted from IDirectInput8AImpl_EnumDevicesBySemantics from wine's code. Logs are made with these steps: 1. Start the game 2. Go to device configuration 3. Set key 's' to 'shift up' 4. Go to in game 5. Close the game with alt+f4 A racing wheel is connected when logging. Tested wine version is the latest git. Demo can be downloaded from: http://games.softpedia.com/get/Games-Demo/Rally-Trophy.shtml -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34108 --- Comment #1 from jettis(a)gmail.com 2013-07-21 17:56:53 CDT --- Created attachment 45354 --> http://bugs.winehq.org/attachment.cgi?id=45354 Rally Trophy Demo log trace+dinput -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34108 jettis(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34108 --- Comment #2 from jettis(a)gmail.com --- Created attachment 52531 --> https://bugs.winehq.org/attachment.cgi?id=52531 Patch trying to fix problems with controller configuration for Rally Trophy Fixes multiple problems with controller configuration to get wheel working and configurable with both full version and demo of Rally Trophy. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34108 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch CC| |sebastian(a)fds-team.de --- Comment #3 from Sebastian Lackner <sebastian(a)fds-team.de> --- (In reply to jettis from comment #2)
Created attachment 52531 [details] Patch trying to fix problems with controller configuration for Rally Trophy
Fixes multiple problems with controller configuration to get wheel working and configurable with both full version and demo of Rally Trophy.
Is this your own patch? If the answer is yes, and you think its a proper way to fix those issues, please send your changes to the wine-patches mailing list for reviewing and inclusion into wine. You can find more information about submitting patches here: http://wiki.winehq.org/SubmittingPatches C++ style comments ("// ...") are not allowed for example, but that should be easy to fix. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34108 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man(a)post.com --- Comment #4 from super_man(a)post.com --- The patch applies almost cleanly against current wine-git patching file dlls/dinput/config.c patching file dlls/dinput/device.c Hunk #8 FAILED at 876. Hunk #9 succeeded at 1288 (offset 20 lines). 1 out of 9 hunks FAILED -- saving rejects to file dlls/dinput/device.c.rej patching file dlls/dinput/device_private.h Hunk #1 succeeded at 249 (offset 1 line). patching file dlls/dinput/dinput_main.c Hunk #1 succeeded at 560 (offset 33 lines). Hunk #2 succeeded at 597 (offset 33 lines). Hunk #3 succeeded at 926 (offset 33 lines). Hunk #4 succeeded at 960 (offset 33 lines). Hunk #5 succeeded at 1012 (offset 33 lines). Hunk #6 succeeded at 1036 (offset 33 lines). Hunk #7 succeeded at 1103 (offset 33 lines). Hunk #8 succeeded at 1142 (offset 33 lines). patching file dlls/dinput/dinput_private.h patching file dlls/dinput/joystick.c -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34108 jettis(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52531|0 |1 is obsolete| | --- Comment #5 from jettis(a)gmail.com --- Created attachment 54200 --> https://bugs.winehq.org/attachment.cgi?id=54200 Patch trying to fix problems with controller configuration for Rally Trophy A little bit of further development for the previous patch. It's my own work. Working well for me but I'm sure it still needs some fixes to do. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34108 --- Comment #6 from super_man(a)post.com --- If I were you I would send the patch into wine-patches list for review. And I would split the patch. It's too huge patchset to apply like that. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34108 winetest(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx(a)gmail.com, | |winetest(a)luukku.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34108 --- Comment #7 from winetest(a)luukku.com --- I searched my Logitech F710 controller. So I could help with controller bugs. But I have no clue how I supposed to start working with this. Kernel sees it... [ 4775.584627] usb 1-12.2: new full-speed USB device number 13 using xhci_hcd [ 4775.691381] usb 1-12.2: New USB device found, idVendor=046d, idProduct=c219 [ 4775.691383] usb 1-12.2: New USB device strings: Mfr=1, Product=2, SerialNumber=0 [ 4775.691385] usb 1-12.2: Product: Logitech Cordless RumblePad 2 [ 4775.691385] usb 1-12.2: Manufacturer: Logitech [ 4775.694328] input: Logitech Logitech Cordless RumblePad 2 as /devices/pci0000:00/0000:00:14.0/usb1/1-12/1-12.2/1-12.2:1.0/0003:046D:C219.000C/input/input27 [ 4775.748907] logitech 0003:046D:C219.000C: input,hidraw5: USB HID v1.11 Gamepad [Logitech Logitech Cordless RumblePad 2] on usb-0000:00:14.0-12.2/input0 [ 4775.748910] hid_logitech: Force feedback for Logitech force feedback devices by Johann Deneux <johann.deneux(a)it.uu.se> Starting the game and going into controller options --> I get a somekind of wine controller setup, but I can't change any options with mouse the mouse isnt visible on top of the window. So the settings are all default (incorrect?). I am not sure anymore how the testing went but only few keys were working I did try the patch. wine 2.0-git. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34108 --- Comment #8 from jettis(a)gmail.com --- This patch doesn't fix the invisible mouse on controller setup, but even if the mouse is invisible you can still use that. Or you can move controller settings next to some other window and make that other window active. Then the mouse won't disappear. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34108 joaopa <jeremielapuree(a)yahoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree(a)yahoo.fr --- Comment #9 from joaopa <jeremielapuree(a)yahoo.fr> --- I do not a have a controller to test. Does the bug still occur with current wine(4.0-rc1)? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34108 --- Comment #10 from jettis(a)gmail.com --- Some parts of the bug are fixed: - Racing wheel is now usable with default mappings - Keyboard keys that are configured can be used in game Still broken: - Configured keys are not shown in configuration when a wheel is connected - Racing wheel cannot be configured at all - Only unmapped keys can be mapped. Default key mappings cannot be changed or deleted. I have patches which should fix these. I will send them for review later. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34108 --- Comment #11 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- (In reply to jettis from comment #10)
I have patches which should fix these. I will send them for review later.
Any chance you could attach them? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34108 --- Comment #12 from jettis(a)gmail.com --- Created attachment 64275 --> https://bugs.winehq.org/attachment.cgi?id=64275 Patch to load joystick mappings -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34108 --- Comment #13 from jettis(a)gmail.com --- Created attachment 64276 --> https://bugs.winehq.org/attachment.cgi?id=64276 Patch to allow loading empty mappings -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34108 jettis(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54200|0 |1 is obsolete| | --- Comment #14 from jettis(a)gmail.com --- Created attachment 64277 --> https://bugs.winehq.org/attachment.cgi?id=64277 Patch to have user names and separate actionformats in device configuration -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34108 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Staged patchset| |https://github.com/wine-sta | |ging/wine-staging/tree/mast | |er/patches/dinput-joy-mappi | |ngs Ever confirmed|0 |1 Status|UNCONFIRMED |STAGED CC| |leslie_alistair(a)hotmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34108 --- Comment #15 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- (In reply to winetest from comment #7)
Starting the game and going into controller options --> I get a somekind of wine controller setup, but I can't change any options with mouse the mouse isnt visible on top of the window. So the settings are all default (incorrect?).
The missing cursor is now fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34108 --- Comment #16 from joaopa <jeremielapuree(a)yahoo.fr> --- Does the bug still occur with wine-10.1? Steps to reproduce in comment 0 are not informative to reproduce by myself. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34108 --- Comment #17 from jettis(a)gmail.com --- Yes the bug still occurs on wine-10.2. Seems also that there have happened regression as I can't set keys even for keyboard anymore. I could not get wine between 7.0 and 8.0 to compile, so could not do regression test at the moment. Steps to reproduce with a keyboard: 1. install Rally Trophy demo 2. start Rally Trophy 3. go to device configuration 4. select keyboard from device list 5. set key 's' to have action 'shift up' 6. save device configurations 7. go to in game with manual transmission 8. press key 's' in game and notice that gear does not change Steps to reproduce with a racing wheel attached: 1. install Rally Trophy demo 2. start Rally Trophy 3. go to device configuration 4. select your racing wheel device from device list 5. set some known button on your racing wheel to have action 'shift up' 6. save device configurations 7. go to in game with manual transmission 8. press that known button in game and notice that gear does not change (if that button did not have shift up action as a default action) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs@winehq.org -
WineHQ Bugzilla