[Bug 39867] New: Long path components (e.g. 250 character long) crash open/save dialogs
https://bugs.winehq.org/show_bug.cgi?id=39867 Bug ID: 39867 Summary: Long path components (e.g. 250 character long) crash open/save dialogs Product: Wine Version: 1.8 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comdlg32 Assignee: wine-bugs(a)winehq.org Reporter: whitequark(a)whitequark.org Distribution: --- To reproduce: 1. mkdir aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa 2. call GetOpenFileName and navigate to a directory containing the newly created one 3. Wine is aborted by stack smashing protection -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39867 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx(a)gmail.com --- Comment #1 from Bruno Jesus <00cpxxx(a)gmail.com> --- Please if possible attach some sample code to reproduce the issue. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39867 --- Comment #2 from whitequark(a)whitequark.org --- Created attachment 53241 --> https://bugs.winehq.org/attachment.cgi?id=53241 build as: i686-w64-mingw32-gcc openfile.c -lcomdlg32 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39867 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, testcase -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39867 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man(a)post.com --- Comment #3 from super_man(a)post.com --- (In reply to whitequark from comment #2)
Created attachment 53241 [details] build as: i686-w64-mingw32-gcc openfile.c -lcomdlg32
I can confirm the issue wine 1.9.7 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39867 --- Comment #4 from Bruno Jesus <00cpxxx(a)gmail.com> --- Created attachment 57197 --> https://bugs.winehq.org/attachment.cgi?id=57197 so-so patch The attached patch works but the problem is very deep inside many shell32 and commdlg32 functions that rely on MAX_PATH and FILENAME_MAX constants. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39867 winetest(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest(a)luukku.com --- Comment #5 from winetest(a)luukku.com --- There are 2-3 open bugs related to this. Could be just a bit difficult to find out of 6000 bugs. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39867 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fgouget(a)codeweavers.com Keywords| |patch, source -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39867 Kyle_Katarn <contact(a)kcsoftwares.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |contact(a)kcsoftwares.com --- Comment #6 from Kyle_Katarn <contact(a)kcsoftwares.com> --- Same as : https://bugs.winehq.org/show_bug.cgi?id=48980 ? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39867 KRosUser <kyle.kcsoftwares(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.kcsoftwares(a)gmail.com --- Comment #7 from KRosUser <kyle.kcsoftwares(a)gmail.com> --- Bug still there in 8.0.2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39867 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Severity|normal |minor CC| |dark.shadow4(a)web.de Status|UNCONFIRMED |NEW --- Comment #8 from Fabian Maurer <dark.shadow4(a)web.de> --- In windows there's a lot of assumptions that paths simply don't get that long. Is there any real application dependent on that behavior? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39867 --- Comment #9 from Fabian Maurer <dark.shadow4(a)web.de> --- *** Bug 48980 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39867 --- Comment #10 from KRosUser <kyle.kcsoftwares(a)gmail.com> --- No specific application but a simple user input crashes the application and Wine under Linux. Poor robustness. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39867 --- Comment #11 from whitequark(a)whitequark.org --- It's pretty easy to end up with a nested directory on Linux that has a path this long, especially since nothing on Linux minds it. Moreover, even Windows no longer has this limitation baked into the OS any more: https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-lim... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39867 --- Comment #12 from KRosUser <kyle.kcsoftwares(a)gmail.com> --- Could this MR provide some inspiration ? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39867 --- Comment #13 from KRosUser <kyle.kcsoftwares(a)gmail.com> --- (In reply to KRosUser from comment #12)
Could this MR provide some inspiration ?
https://gitlab.winehq.org/wine/wine/-/merge_requests/6657 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=39867 --- Comment #14 from KRosUser <kyle.kcsoftwares(a)gmail.com> --- Proposal for a fix : https://jira.reactos.org/secure/attachment/69056/comdlg32_filedlg-fix-02.pat... (from https://jira.reactos.org/browse/CORE-15288) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=39867 --- Comment #15 from Catherine <whitequark(a)whitequark.org> --- I don't think I agree that that's a "fix", it's a workaround at best and it will be frustrating to encounter for anyone working with long paths. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=39867 --- Comment #16 from KRosUser <kyle.kcsoftwares(a)gmail.com> --- Any better proposal for a fix ? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=39867 --- Comment #17 from KRosUser <kyle.kcsoftwares(a)gmail.com> --- https://bugs.winehq.org/show_bug.cgi?id=39688 looks the same -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=39867 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |n296869(a)rtrtr.com --- Comment #18 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- *** Bug 39688 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=39867 --- Comment #19 from KRosUser <kyle.kcsoftwares(a)gmail.com> --- Source for inspiration ? https://gitlab.winehq.org/wine/wine/-/merge_requests/8240 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla