[Bug 16165] New: Another Warhammer Online Patch Bug in wine 1.1.9
http://bugs.winehq.org/show_bug.cgi?id=16165 Summary: Another Warhammer Online Patch Bug in wine 1.1.9 Product: Wine Version: CVS/GIT Platform: PC URL: http://appdb.winehq.org/objectManager.php?sClass=version &iId=13139 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: nospam(a)thenerdshow.com Upon upgrading to wine 1.1.9 and running "winecfg" to update the .wine folder, warhammer refuses to patch. The error box that pops up says "The patch client was unable to retrieve the file [patcher.prod.sig] from the patch server. Please try the patch operation again in a short while." I removed wine version 1.1.9 from my computer and installed wine version 1.1.8 again and it works. Then I upgraded again to wine version 1.1.9 and it fails to patch. Downgrade and it works, upgrade and it does not. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16165 Henry Kroll <nospam(a)thenerdshow.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15331 Keywords| |regression -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16165 Henry Kroll <nospam(a)thenerdshow.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |winhttp --- Comment #1 from Henry Kroll <nospam(a)thenerdshow.com> 2008-11-22 20:00:36 --- e4f7809cc9969c693d910348315502892848aaf9 is first bad commit commit e4f7809cc9969c693d910348315502892848aaf9 Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Nov 20 14:50:58 2008 +0100 winhttp: Prefer builtin over native. It's obvious what's happening here. To go back to using native winhttp, we can just use DLLOVERRIDES. The character of this bug has changed. It is not a new bug but an existing bug with wine's builtin winhttp.dll so I will try to update it to reflect that. Of course, it would help wine better if we can find out what about builtin winhttp is causing the error with patching. Maybe some kind of encryption thing. Not sure where to start debugging that, packet sniffing, perhaps? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16165 Henry Kroll <nospam(a)thenerdshow.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Another Warhammer Online |Builtin winhttp.dll "unable |Patch Bug in wine 1.1.9 |to retrieve the file" | |(Warhammer Online) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16165 Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Builtin winhttp.dll "unable |Warhammer Online refuses to |to retrieve the file" |patch with builtin |(Warhammer Online) |winhttp.dll Version|CVS/GIT |1.1.9 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16165 Hans Leidekker <hans(a)meelstraat.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hans(a)meelstraat.net --- Comment #2 from Hans Leidekker <hans(a)meelstraat.net> 2008-11-23 04:26:39 --- Please attach a WINEDEBUG=+winhttp trace. Is there a free download? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16165 Henry Kroll <nospam(a)thenerdshow.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|regression | -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16165 Lucas Murray <lmurray(a)undefinedfire.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #3 from Lucas Murray <lmurray(a)undefinedfire.com> 2008-12-26 07:50:53 --- *** This bug has been confirmed by popular vote. *** -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16165 --- Comment #4 from Paul "TBBle" Hampson <Paul.Hampson(a)Pobox.com> 2008-12-30 08:34:28 --- Created an attachment (id=18326) --> (http://bugs.winehq.org/attachment.cgi?id=18326) Builtin winhttp debug log from running WAR Patcher under wine 1.1.11 WINEDEBUG=+winhttp wine warpatch.bin > warpatch-winhttp.log 2>&1 Just looking at the code that produces the "failed to resolve" error in winhttp (in 1.1.11, haven't checked git) we heap_free hostname, and then debugstr_a it for printf, in the failure path. I'm trying to quickly fix that and rebuild wine and see if I can get a better answer from the "failed to resolve" error output. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16165 Paul "TBBle" Hampson <Paul.Hampson(a)Pobox.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18326|0 |1 is obsolete| | --- Comment #5 from Paul "TBBle" Hampson <Paul.Hampson(a)Pobox.com> 2008-12-30 09:49:17 --- Created an attachment (id=18328) --> (http://bugs.winehq.org/attachment.cgi?id=18328) Builtin winhttp debug log from running WAR Patcher under wine 1.1.11 with patched netconn_resolve error logging Here's the same log run but with the error output in netconn_resolve corrected. I've submitted a patch to fix that. It clearly shows that it's trying to do a hostname lookup on hostname:port instead of just the hostname. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16165 Paul "TBBle" Hampson <Paul.Hampson(a)Pobox.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18328|application/octet-stream |text/plain mime type| | -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16165 Paul "TBBle" Hampson <Paul.Hampson(a)Pobox.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Paul.Hampson(a)Pobox.com --- Comment #6 from Paul "TBBle" Hampson <Paul.Hampson(a)Pobox.com> 2008-12-30 10:54:32 --- On slightly closer examination of the code, the issue is that the WinHttpCrackUrl implementation in Wine isn't filling in the nPort member of the URL_COMPONENTS structure, but is leaving the colon and port number in the host name string. The other parts that operate on the URL_COMPONENTS (WinHttpCreateUrl and the internal-to-url.c calc_length) do operate on nPort correctly (as far as I can see) so it's just WinHttpCrackUrl that needs fixing. I don't know if this is the only problem preventing use of built-in winhttp with the WAR patcher, so I won't bug this seperately. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16165 --- Comment #7 from Paul "TBBle" Hampson <Paul.Hampson(a)Pobox.com> 2008-12-30 11:01:45 --- attachment 17812 in bug 16453 comment 4 might be relevant to this... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16165 --- Comment #8 from Paul "TBBle" Hampson <Paul.Hampson(a)Pobox.com> 2008-12-30 11:08:54 --- Ignore comment 7, that patch has already been applied. The problem is that the caller of winhttp is incorrectly getting port 0 back from WinHttpCrackUrl and then is passing that 0 to WinHttpConnect. It's definately WinHttpCrackUrl that needs to be fixed. I'm surprised this hasn't shown up anywhere else, but I haven't found any other bugs that suggest the same issue has been hit. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16165 --- Comment #9 from Paul "TBBle" Hampson <Paul.Hampson(a)Pobox.com> 2008-12-31 00:53:58 --- I've submitted a patch to fix the port parsing in WinHttpCrackUrl to wine-patches: http://www.winehq.org/pipermail/wine-patches/attachments/20081231/9dd13b3f/a... (If you want to apply just that patch, it'll fail on tests/url.c. That's fine.) However, I then get a segfault later on in the connection process, still inside winhttp. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16165 --- Comment #10 from Paul "TBBle" Hampson <Paul.Hampson(a)Pobox.com> 2008-12-31 02:11:04 --- I've submitted a patch to fix the segfault as well: http://www.winehq.org/pipermail/wine-patches/attachments/20081231/428e5955/a... With this patch and the patch linked in comment 9, the builtin winhttp works fine with the WAR patcher. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16165 --- Comment #11 from Paul "TBBle" Hampson <Paul.Hampson(a)Pobox.com> 2008-12-31 09:07:39 --- Patches have gone into Wine master branch as of http://source.winehq.org/git/wine.git/?a=commit;h=04b8ec07a6e9c5888bc306939e... so I expect this bug will be fixed by Wine 1.1.12. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16165 Jeff Zaroyko <jeffz(a)jeffz.name> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #12 from Jeff Zaroyko <jeffz(a)jeffz.name> 2008-12-31 14:01:11 --- (In reply to comment #11)
Patches have gone into Wine master branch as of http://source.winehq.org/git/wine.git/?a=commit;h=04b8ec07a6e9c5888bc306939e... so I expect this bug will be fixed by Wine 1.1.12.
great! we can mark this fixed then -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16165 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #13 from Alexandre Julliard <julliard(a)winehq.org> 2009-01-02 10:34:15 --- Closing bugs fixed in 1.1.12. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16165 Bug 16165 depends on bug 15331, which changed state. Bug 15331 Summary: Warhammer Patch Bug! http://bugs.winehq.org/show_bug.cgi?id=15331 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |DUPLICATE -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org