[Bug 31805] New: dmime:performance tests shows lots of unitialized values in dmusic
http://bugs.winehq.org/show_bug.cgi?id=31805 Bug #: 31805 Summary: dmime:performance tests shows lots of unitialized values in dmusic Product: Wine Version: 1.5.13 Platform: x86 OS/Version: Linux Status: NEW Keywords: download, regression, source, testcase Severity: minor Priority: P2 Component: directx-dmusic AssignedTo: wine-bugs(a)winehq.org ReportedBy: austinenglish(a)gmail.com CC: titan.costa(a)gmail.com Classification: Unclassified Regression SHA1: 66a817f067ec8d53337001aff4c399e73c293aac ==28721== Conditional jump or move depends on uninitialised value(s) ==28721== at 0x5F07BA6: DMUSIC_CreateDirectMusicImpl (unicode.h:207) ==28721== by 0x5F087AD: ClassFactory_CreateInstance (dmusic_main.c:87) ==28721== by 0x492A28F: CoCreateInstance (unknwn.h:226) ==28721== by 0x515971E: IDirectMusicPerformance8Impl_Init (performance.c:286) ==28721== by 0x515987F: IDirectMusicPerformance8Impl_InitAudio (performance.c:930) ==28721== by 0x48EBB89: func_performance (performance.c:63) ==28721== by 0x48EC954: run_test (test.h:557) ==28721== by 0x48EAD22: main (test.h:627) ==28721== Uninitialised value was created by a stack allocation ==28721== at 0x5F07821: DMUSIC_CreateDirectMusicImpl (dmusic.c:408) it's a regression, introduced by: austin(a)debian:~/wine-git$ git bisect good 66a817f067ec8d53337001aff4c399e73c293aac is the first bad commit commit 66a817f067ec8d53337001aff4c399e73c293aac Author: Christian Costa <titan.costa(a)gmail.com> Date: Sun Sep 16 20:24:10 2012 +0200 dmusic: Create the list of available system ports at the beginning and use it to enumerate ports. :040000 040000 2c691a32d6952dd08affff7b735c9c128acb0e81 2c931c30a06b9a91f85aecd7f9c07e44e3ffb30e M dlls -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31805 --- Comment #1 from Christian Costa <titan.costa(a)gmail.com> 2012-09-27 04:16:34 CDT --- Does commenting out create_system_ports_list in DMUSIC_CreateDirectMusicImpl hides the problem? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31805 --- Comment #2 from Austin English <austinenglish(a)gmail.com> 2012-09-27 14:06:55 CDT --- (In reply to comment #1)
Does commenting out create_system_ports_list in DMUSIC_CreateDirectMusicImpl hides the problem?
Yes. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31805 --- Comment #3 from Christian Costa <titan.costa(a)gmail.com> 2012-09-27 16:04:43 CDT --- Does the attached patch help? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31805 --- Comment #4 from Christian Costa <titan.costa(a)gmail.com> 2012-09-27 16:06:30 CDT --- Created attachment 41861 --> http://bugs.winehq.org/attachment.cgi?id=41861 Fix try -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31805 --- Comment #5 from Austin English <austinenglish(a)gmail.com> 2012-09-27 16:19:01 CDT --- (In reply to comment #3)
Does the attached patch help?
No, problem remains. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31805 --- Comment #6 from Sven <sven.wine(a)gmail.com> 2012-09-29 10:15:29 CDT --- I just sent a patch for this bug (90411) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31805 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |86d589b2e1132a9e02446cc0018 | |c68630b07f232 Status|NEW |RESOLVED Resolution| |FIXED --- Comment #7 from Austin English <austinenglish(a)gmail.com> 2012-10-01 13:40:34 CDT --- Fixed by http://source.winehq.org/git/wine.git/commitdiff/86d589b2e1132a9e02446cc0018... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31805 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #8 from Alexandre Julliard <julliard(a)winehq.org> 2012-10-12 13:34:41 CDT --- Closing bugs fixed in 1.5.15. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs@winehq.org