[Bug 48849] New: FIXME logging can be omitted for supported cases of GetCurrentProcessorNumberEx

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48849

            Bug ID: 48849
           Summary: FIXME logging can be omitted for supported cases of
                    GetCurrentProcessorNumberEx
           Product: Wine
           Version: 5.5
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P2
         Component: ntdll
          Assignee: wine-bugs(a)winehq.org
          Reporter: perchrh-wine(a)pvv.org
      Distribution: ---

Created attachment 66766
  --> https://bugs.winehq.org/attachment.cgi?id=66766
Trivial patch

A program that uses GetCurrentProcessorNumberEx frequently becomes very verbose
under Wine. The reason is the FIXME(..) stub warning of this method in
dlls/ntdll/rtl.c.

This method is actually fully implemented for most cases, and the verbose
message can be thus omitted, while keeping the warning for those cases where
there actually is something missing in Wine's implementation. 
Specifically, this method is fully implemented for systems with less than 64
logical processors. 

API docs quote: "Processor groups are numbered starting with 0. Systems with
fewer than 64 logical processors always have a single group, Group 0."
Source: 
https://docs.microsoft.com/nb-no/windows/win32/procthread/processor-groups

The attached patch implements the mentioned behavior.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 48849] FIXME logging can be omitted for supported cases of GetCurrentProcessorNumberEx

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48849

Austin English <austinenglish(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #1 from Austin English <austinenglish(a)gmail.com> ---
Please send your patch to wine-patches, it won't be picked up from bugzilla.
For more info, see https://wiki.winehq.org/SubmittingPatches

Also, use /* C style comments */, not // C++.

Lastly, please remove the reference to microsoft docs, the links are known to
change and break, not to mention often being wrong ;).

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.