[Bug 42820] New: The Witness: MSAA causes black screen
https://bugs.winehq.org/show_bug.cgi?id=42820 Bug ID: 42820 Summary: The Witness: MSAA causes black screen Product: Wine Version: 2.6 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-d3d Assignee: wine-bugs(a)winehq.org Reporter: notasas(a)gmail.com Distribution: --- Created attachment 57887 --> https://bugs.winehq.org/attachment.cgi?id=57887 hack patch The multisampling option (enabled by default) is causing black screen. Józef has made a hack patch (in bug 40508 Comment 18 , attached here for convenience), but a proper solution is needed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Grazvydas Ignotas <notasas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fjfrackiewicz(a)gmail.com, | |joseph.kucia(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Andrew Eikum <aeikum(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aeikum(a)codeweavers.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Józef Kucia <joseph.kucia(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The Witness: MSAA causes |Multiple games (The |black screen |Witness, Just Cause 2) | |require D3D11 multisample | |textures -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Józef Kucia <joseph.kucia(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest(a)luukku.com --- Comment #1 from Józef Kucia <joseph.kucia(a)gmail.com> --- *** Bug 42921 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Józef Kucia <joseph.kucia(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.winehq.org/sho | |w_bug.cgi?id=42819 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 --- Comment #2 from Józef Kucia <joseph.kucia(a)gmail.com> --- Created attachment 58295 --> https://bugs.winehq.org/attachment.cgi?id=58295 D3D11 multisample textures + ATOC The attached patch should be good enough for The Witness. It's a dump of my WIP branch for multisample textures. It isn't really tested and a bit hacky. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Józef Kucia <joseph.kucia(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57887|0 |1 is obsolete| | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Matteo Bruni <matteo.mystral(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |haakobja(a)gmail.com --- Comment #3 from Matteo Bruni <matteo.mystral(a)gmail.com> --- *** Bug 43094 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Benjamin Hodgetts <ben(a)xnode.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ben(a)xnode.org --- Comment #4 from Benjamin Hodgetts <ben(a)xnode.org> --- This also appears to affect Toybox Turbos and Oceanhorn so I've linked those. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Józef Kucia <joseph.kucia(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.winehq.org/sho | |w_bug.cgi?id=43281 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 BieHDC <byi5000(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |byi5000(a)gmail.com --- Comment #5 from BieHDC <byi5000(a)gmail.com> --- VCB Why City and other games need this too -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Pekka Helenius <fincer89(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fincer89(a)hotmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 --- Comment #6 from Pekka Helenius <fincer89(a)hotmail.com> --- Rise of the Tomb Raider (ROTTR) seems to be affected, too: https://bugs.winehq.org/show_bug.cgi?id=43479#c20 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Shmerl <shtetldik(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shtetldik(a)gmail.com --- Comment #7 from Shmerl <shtetldik(a)gmail.com> --- (In reply to Józef Kucia from comment #2)
Created attachment 58295 [details] D3D11 multisample textures + ATOC
The attached patch should be good enough for The Witness. It's a dump of my WIP branch for multisample textures. It isn't really tested and a bit hacky.
Will it help for any texture issues in the Witcher 3? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 --- Comment #8 from Pekka Helenius <fincer89(a)hotmail.com> --- Not answering to the question but just saying that the patch in question seem to be deprecated. At least, I can't compile Wine 2.18 Staging with it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 --- Comment #9 from Pekka Helenius <fincer89(a)hotmail.com> --- I configured the patch for Wine 2.18 Staging. I did multiple test runs with and without the patch for Witcher 3. I have not played the game so much, just actually the initial room and the first staircase. I can't tell any differences. I did testing with ROTTR, too. No major differences either. Disclaimer: I don't know whether the current form of the patch code applies good enough to current Wine Staging version due to multiple D3D11 commits after the May when the patch was initially published. Wine devs have better understanding of this topic. I may add the re-adapted patch & debugging stuff later, if needed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 --- Comment #10 from Shmerl <shtetldik(a)gmail.com> --- (In reply to Pekka Helenius from comment #9)
I have not played the game so much, just actually the initial room and the first staircase. I can't tell any differences
Texture issues don't happen in the beginning, besides may be the opaque surface (bug 43158). Did you just rebase the patch on latest code? Is Józef still working on that multisample textures branch or the effort was scrapped? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 --- Comment #11 from Pekka Helenius <fincer89(a)hotmail.com> --- Ah okay, that's nice to know. I couldn't reproduce bug 43158. Yes, I just rebased the patch, nothing else really. Józef may be the only guy who can answer to your question. However, as I've checked submitted patches list on https://source.winehq.org/patches/ and Wine Staging patches on GitHub (https://github.com/wine-compholio/wine-staging/commits/master) I can't see any of them related to DX11 Multisampling. Obviously, I don't know anything about private/test patches which Wine devs may be working on, however. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 --- Comment #12 from Shmerl <shtetldik(a)gmail.com> --- (In reply to Pekka Helenius from comment #11)
Ah okay, that's nice to know. I couldn't reproduce bug 43158.
Yes, I just rebased the patch, nothing else really.
Can you please post the diff somewhere? I can test if it affects any known texture issues. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 --- Comment #13 from Pekka Helenius <fincer89(a)hotmail.com> --- Created attachment 59510 --> https://bugs.winehq.org/attachment.cgi?id=59510 Rebased D3D11 Multisample patch for Wine Staging 2.18 Rebased patch for Wine 2.18 Staging as a tar.xz attachment. I have splitted it into three parts. You must apply the patch files *after* Staging patches. I'm not the author of the patch code. The original code has been written by Józef Kucia. -------------------------- The only change I did was adding several brackets to if statements in /dlls/wined3d/texture.c (lines 464-499 in patch file "patch_multisample_wined3d-dll-staging218.patch") @@ -2794,11 +2813,31 @@ static HRESULT texture_init(struct wined3d_texture *texture, const struct wined3 as the compiler refused to compile the code otherwise. -------------------------- By my behalf, feel free to modify the code if necessary. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Lukas Jirkovsky <l.jirkovsky(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |l.jirkovsky(a)gmail.com --- Comment #14 from Lukas Jirkovsky <l.jirkovsky(a)gmail.com> --- I did a quick test of Pekka's patch with Wine Staging 2.19 with Witcher 3. I always had problems with sirens being invisible. Now they were no longer invisible, but they were bugged like alghouls mentioned in #43828. However, the change may as well be affected by updates I did since I last played TW3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Daniel Oom <oom.daniel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oom.daniel(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Matteo Bruni <matteo.mystral(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benclapp55(a)gmail.com --- Comment #15 from Matteo Bruni <matteo.mystral(a)gmail.com> --- *** Bug 44179 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Mathieu Comandon <strider(a)strycore.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |strider(a)strycore.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 tokktokk <fdsfgs(a)krutt.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fdsfgs(a)krutt.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Adam Bolte <abolte(a)systemsaviour.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abolte(a)systemsaviour.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 --- Comment #16 from Shmerl <shtetldik(a)gmail.com> --- Is the latest Wine release (3.2) fixing this? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Józef Kucia <joseph.kucia(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kimmo.myllyvirta(a)gmail.com --- Comment #17 from Józef Kucia <joseph.kucia(a)gmail.com> --- *** Bug 43281 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Józef Kucia <joseph.kucia(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.frank(a)gmx.de --- Comment #18 from Józef Kucia <joseph.kucia(a)gmail.com> --- *** Bug 43361 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Józef Kucia <joseph.kucia(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |fb6b3cc872077e641cf68165e04 | |012a95c94699d --- Comment #19 from Józef Kucia <joseph.kucia(a)gmail.com> --- Fixed by commit https://source.winehq.org/git/wine.git/?a=commit;h=fb6b3cc872077e641cf68165e... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #20 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 3.3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 --- Comment #21 from Matteo Bruni <matteo.mystral(a)gmail.com> --- *** Bug 44179 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42820 Matteo Bruni <matteo.mystral(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexterranova81(a)gmail.com --- Comment #22 from Matteo Bruni <matteo.mystral(a)gmail.com> --- *** Bug 45944 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org