[Bug 10204] New: Incorrectly raised FD_WRITE socket event
http://bugs.winehq.org/show_bug.cgi?id=10204 Summary: Incorrectly raised FD_WRITE socket event Product: Wine Version: 0.9.48. Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P3 Component: wine-net AssignedTo: wine-bugs(a)winehq.org ReportedBy: rraptorr(a)nails.eu.org Created an attachment (id=8812) --> (http://bugs.winehq.org/attachment.cgi?id=8812) FD_WRITE event on socket test program According to MSDN WSAEventSelect function description (http://msdn2.microsoft.com/en-us/library/ms741576.aspx), FD_WRITE event should be raised only once after: a) successful connection b) WSAEWOULDBLOCK error while in nonblocking mode. MSDN description: "The FD_WRITE network event is handled slightly differently. An FD_WRITE network event is recorded when a socket is first connected with connect/WSAConnect or accepted with accept/WSAAccept, and then after a send fails with WSAEWOULDBLOCK and buffer space becomes available. Therefore, an application can assume that sends are possible starting from the first FD_WRITE network event setting and lasting until a send returns WSAEWOULDBLOCK. After such a failure the application will find out that sends are again possible when an FD_WRITE network event is recorded and the associated event object is set." Unfortunately, it seems that in Wine 0.9.48 (and a few earlier versions too) this event is raised every time it is possible to write to the socket. I've created a simple test program (FD_WRITE-test.c) that shows this problem. When ran on Windows I get: lNetworkEvents: 2 lNetworkEvents: 0 but when ran on Wine: lNetworkEvents: 2 lNetworkEvents: 2 which means that FD_WRITE was raised twice and it shouldn't. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #1 from Janusz Dziemidowicz <rraptorr(a)nails.eu.org> 2007-10-30 05:44:14 --- Created an attachment (id=8866) --> (http://bugs.winehq.org/attachment.cgi?id=8866) Ugly hack for FD_WRITE event problem This is an ugly hack that fixes the problem. It allows me to run D2GS (Diablo 2 closed game server) on Wine. It is the first time ever I've looked into Wine source, so this patch probably breaks something somewhere. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Janusz Dziemidowicz <rraptorr(a)nails.eu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8812|application/octet-stream |text/plain mime type| | -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Janusz Dziemidowicz <rraptorr(a)nails.eu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|0.9.48. |0.9.50. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 James Hawkins <truiken(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|0.9.50. |0.9.48. --- Comment #2 from James Hawkins <truiken(a)gmail.com> 2007-12-02 18:07:18 --- Don't change the original reported version. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Juan Lang <juan_lang(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |juan_lang(a)yahoo.com --- Comment #3 from Juan Lang <juan_lang(a)yahoo.com> 2007-12-06 13:20:08 --- Any chance of making your test program into a regression test? Rather than the two printf's, you might do something like: ok(evs.lNetworkEvents & FD_WRITE, "Expected FD_WRITE to be set\n"); in the first case, and: todo_wine ok(!(evs.lNetworkEvents & FD_WRITE), "Expected FD_WRITE to be cleared\n"); in the second. Getting a regression test committed will increase the chances of getting a fix accepted, too. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Janusz Dziemidowicz <rraptorr(a)nails.eu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8812 is|0 |1 obsolete| | --- Comment #4 from Janusz Dziemidowicz <rraptorr(a)nails.eu.org> 2007-12-30 18:25:58 --- Created an attachment (id=9931) --> (http://bugs.winehq.org/attachment.cgi?id=9931) FD_WRITE event regression test Attached standalone regression test for this bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Janusz Dziemidowicz <rraptorr(a)nails.eu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9931|application/octet-stream |text/plain mime type| | -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Max <ignatich(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ignatich(a)gmail.com --- Comment #5 from Max <ignatich(a)gmail.com> 2008-03-12 00:27:34 --- Will this ever be fixed? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 my-email(a)seznam.cz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #6 from my-email(a)seznam.cz 2008-03-21 16:33:22 --- *** This bug has been confirmed by popular vote. *** -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 my-email(a)seznam.cz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |my-email(a)seznam.cz -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dank(a)kegel.com --- Comment #7 from Dan Kegel <dank(a)kegel.com> 2008-03-21 17:46:15 --- Janusz, please submit the regression test to wine-patches. Be sure to test it on windows and say which versions you tested with. Also be sure to put todo_wine around the parts that fail on Wine. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch, testcase -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Grzegorz Nakonieczny <naki(a)pvpgn.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |naki(a)pvpgn.pl -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #8 from Kai Blin <kai.blin(a)gmail.com> 2008-05-25 04:39:03 --- I think I've bumped into this as well while trying to make the winsock tests work in WinXP. I'll have to dig into this a bit more. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #9 from Max <ignatich(a)gmail.com> 2008-06-13 08:35:25 --- I still hope this will be fixed before 1.0. Please? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #10 from Dan Kegel <dank(a)kegel.com> 2008-06-13 10:04:36 --- Sorry, no time left. Hopefully it'll get fixed on the trunk one day. It would help if you knew of a popular application that was affected. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #11 from Juan Lang <juan_lang(a)yahoo.com> 2008-06-13 10:25:27 ---
It would help if you knew of a popular application that was affected.
He already mentioned one: the Diablo 2 game server. This one just needs a better shepherd, as it has a regression test and a patch (that may or may not be correct). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.pvpgn.pl/ Keywords| |download Summary|Incorrectly raised FD_WRITE |Can't create games on D2GS; |socket event |incorrectly raised FD_WRITE | |socket event --- Comment #12 from Dan Kegel <dank(a)kegel.com> 2008-06-13 10:40:49 --- Damn, and it was even linked in to the appdb. I've added it to the summary to be a bit more obvious, and added a download link. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #13 from Janusz Dziemidowicz <rraptorr(a)nails.eu.org> 2008-06-13 15:11:13 --- As an author of the patch I can say that it is most probably broken. It allows to run D2GS, but it breaks other things (some winsock tests start to fail). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #14 from Kai Blin <kai.blin(a)gmail.com> 2008-06-13 18:29:38 --- I didn't have time to look into this yet, but I'm not really sure the write event test cases are valid. They seem to fail on XP and above, at least. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #15 from Janusz Dziemidowicz <rraptorr(a)nails.eu.org> 2008-06-14 14:49:23 --- (In reply to comment #14)
I didn't have time to look into this yet, but I'm not really sure the write event test cases are valid. They seem to fail on XP and above, at least.
Could you describe what do you mean by "seem to fail"? I've just checked my standalone test program on Windows XP and it behaves as described in this bug entry (which means that it behaves differently than in Wine). I'm going to run Wine test on Windows XP using MinGW, to see if there aren't any problems with the test itself. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #16 from Janusz Dziemidowicz <rraptorr(a)nails.eu.org> 2008-06-14 16:14:50 --- I've just finished crosscompiling attached test case with latest Wine (1.0-rc5). It runs fine on Windows XP SP2 (11 tests executed, 0 failures) and fails on Wine (11tests executed, 1 failure). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #17 from Kai Blin <kai.blin(a)gmail.com> 2008-06-14 17:07:20 --- (In reply to comment #15)
(In reply to comment #14)
I didn't have time to look into this yet, but I'm not really sure the write event test cases are valid. They seem to fail on XP and above, at least.
Could you describe what do you mean by "seem to fail"? I've just checked my standalone test program on Windows XP and it behaves as described in this bug entry (which means that it behaves differently than in Wine). I'm going to run Wine test on Windows XP using MinGW, to see if there aren't any problems with the test itself.
Fail as in: http://test.winehq.org/data/062d61a5a4ba2d7972a0011387ceda64c79dd4e3/xp_P4XP... Which seems to be just the FD_WRITE event test. Also fails on Win2k3 http://test.winehq.org/data/062d61a5a4ba2d7972a0011387ceda64c79dd4e3/2003_jh... http://test.winehq.org/data/062d61a5a4ba2d7972a0011387ceda64c79dd4e3/2003_W2... and Vista http://test.winehq.org/data/062d61a5a4ba2d7972a0011387ceda64c79dd4e3/vista_M... So I'm talking about the wine test cases, not your standalone test. See the interesting discussion on bug #9777 as well. Wine does something fishy there, but I didn't get a fix for this right yet. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #18 from Janusz Dziemidowicz <rraptorr(a)nails.eu.org> 2008-06-14 17:26:52 --- (In reply to comment #17)
Fail as in:
http://test.winehq.org/data/062d61a5a4ba2d7972a0011387ceda64c79dd4e3/xp_P4XP...
Which seems to be just the FD_WRITE event test.
Also fails on Win2k3 http://test.winehq.org/data/062d61a5a4ba2d7972a0011387ceda64c79dd4e3/2003_jh...
http://test.winehq.org/data/062d61a5a4ba2d7972a0011387ceda64c79dd4e3/2003_W2...
and Vista http://test.winehq.org/data/062d61a5a4ba2d7972a0011387ceda64c79dd4e3/vista_M...
So I'm talking about the wine test cases, not your standalone test.
I've stated in my second comment that I've just checked Wine test too.
See the interesting discussion on bug #9777 as well. Wine does something fishy there, but I didn't get a fix for this right yet.
OK, I don't understand something here. I am talking about Wine test that I've written to support this bug entry, it is attached here (in file fd_write_event.c). It is not in Wine distribution. The test results you have attached are from file sock.c, which is distributed in Wine distribution, but has nothing to do with this bug (at least not directly). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #19 from Kai Blin <kai.blin(a)gmail.com> 2008-06-15 02:47:07 --- I misunderstood then. If your test case works on windows and breaks on Wine, I guess it's valid. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #20 from Grzegorz Nakonieczny <naki(a)pvpgn.pl> 2008-09-07 14:06:24 --- Still nothing about fixing this bug? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #21 from Dan Kegel <dank(a)kegel.com> 2008-09-07 16:35:16 --- Does this help? http://www.winehq.org/pipermail/wine-patches/2008-September/061017.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Kai Blin <kai.blin(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #22 from Kai Blin <kai.blin(a)gmail.com> 2008-09-08 03:57:54 --- I'll have time to look into this tomorrow. Thanks to Janusz for his work on diagnosing this bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Damjan Jovanovic <damjan.jov(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |damjan.jov(a)gmail.com --- Comment #23 from Damjan Jovanovic <damjan.jov(a)gmail.com> 2008-09-08 12:43:14 --- No Dan, my patch doesn't make the test cases here pass, I already tried. But, it might get D2GS working anyway. The latest Git already has it, for those willing to test. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #24 from Max <ignatich(a)gmail.com> 2008-11-24 09:37:59 --- More than year passed since this bug was opened and it's still not fixed. Yes, it still does not work in wine-1.1.9. I think last working wine version was 0.9.23 or very close to it. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #25 from Austin English <austinenglish(a)gmail.com> 2008-11-24 13:06:53 --- What patch broke it? A regression test would help: http://wiki.winehq.org/RegressionTesting -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Pontus Carlsson <PontusCarlsson(a)live.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |PontusCarlsson(a)live.se --- Comment #26 from Pontus Carlsson <PontusCarlsson(a)live.se> 2010-01-06 07:39:51 --- For you who want's D2GS to run properly, Janusz Dziemidowicz patch submission works flawlessly. So far it hasn't made any other program fail for me atleast. If this is your only usage for wine, I.e D2GS then it's safe to say this works! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Pas <pasthelod(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasthelod(a)gmail.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 infobox.oleg(a)wo.cz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |infobox.oleg(a)wo.cz --- Comment #27 from infobox.oleg(a)wo.cz 2010-08-22 13:03:41 --- Hi, tested with wine 1.3.0 and problem persists. I've tried to apply this patch to 1.3.0 and patching failed. I don't know why... I've tried to replicate the patch by manual editing but it did not work - I could not create and join game. I have wine from 0.9.x line patched and it works with my current client setup. Maintaining wine 0.9.x on the server is a pain, it won't even compile now. Is there a patch, which is known to succeed and work with wine 1.3.0? Thanks. Oleg -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Fredrik <freddalfier(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |freddalfier(a)hotmail.com --- Comment #28 from Fredrik <freddalfier(a)hotmail.com> 2010-08-23 02:15:35 --- (In reply to comment #27)
Hi,
tested with wine 1.3.0 and problem persists.
I've tried to apply this patch to 1.3.0 and patching failed. I don't know why... I've tried to replicate the patch by manual editing but it did not work - I could not create and join game. I have wine from 0.9.x line patched and it works with my current client setup. Maintaining wine 0.9.x on the server is a pain, it won't even compile now.
Is there a patch, which is known to succeed and work with wine 1.3.0?
Thanks. Oleg
Hi Oleg, it seems sock.c is completely rewritten for 1.3.0 and i can no longer see where this patch would be applied. However there is a patch from some package maintainer in the Archlinux user repository that I have used on the "Stable" version 1.2, and it works just fine. Download d2gs.patch from: http://aur.archlinux.org/packages.php?ID=34644 Hope it will work for you... / Fredrik -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #29 from infobox.oleg(a)wo.cz 2010-08-24 14:17:19 --- It helped! Thanks! I'll stick to wine-1.2 for now. Oleg -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Dmitry Timoshkov <dmitry(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P3 |P2 Status|ASSIGNED |NEW --- Comment #30 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2010-08-26 01:59:21 --- Marking as NEW. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mike.kaplinskiy(a)gmail.com --- Comment #31 from Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> 2010-09-12 00:48:55 CDT --- The only reason that FD_WRITE is raised again is because WSAEventSelect is called again. If you don't call it again (as you shouldn't really ever need to), all will be well. If the windows behavior is not to refire events when the mask changes, then we need to add a test for that. We'd need to add tests for both WSAEventSelect and WSAAsyncSelect, as well as switching between them. We may also want to test what happens if we add/remove events when re-selecting. As for that hack, it's not just ugly, it's completely incorrect (instead of saying "don't fire FD_WRITE again" it's more like "mark this socket as not writable ever again". This will cause some awesome overlapped failures.) For a hack, something like this should do a little better (in terms of killing other applications): diff --git a/server/sock.c b/server/sock.c index 04ae748..a1afeb3 100644 --- a/server/sock.c +++ b/server/sock.c @@ -972,7 +972,6 @@ DECL_HANDLER(set_socket_event) FILE_WRITE_ATTRIBUTES, &sock_ops) old_event = sock->event; sock->mask = req->mask; - sock->hmask &= ~req->mask; /* re-enable held events */ sock->event = NULL; sock->window = req->window; sock->message = req->msg; -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Grazvydas Ignotas <notasas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |notasas(a)gmail.com --- Comment #32 from Grazvydas Ignotas <notasas(a)gmail.com> 2010-11-08 17:58:41 CST --- The hack works here on wine-1.3.6-240-g791b22a, thanks. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Bushman <buszu1(a)wp.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |buszu1(a)wp.pl --- Comment #33 from Bushman <buszu1(a)wp.pl> 2010-11-23 18:33:29 CST --- Hi guys, anyone willing to write simple HOWTO for noobs like me, who have no idea about writing patches nor debugging stuff, how to apply a patch to work this around for d2gs? thanks in advance and i hope someone will find a solution that will fix it in trunk. Good luck! regards, Bushman PS: i can do testing if required. Ubuntu 10.04 Wine 1.2 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Dr. Anonymous <dr_anonymous(a)freemail.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dr_anonymous(a)freemail.hu --- Comment #34 from Dr. Anonymous <dr_anonymous(a)freemail.hu> 2011-05-08 03:46:10 CDT --- Hi! I have ran into this Diablo 2 Closed Server thing yesterday, but failed at the D2GS.EXE. After several failed attempts, I came here to see, what if just WINE is the culprit in this issue. And it was. :3 At least I have configured up the server correctly, except it can not run because that stupid FD_WRITE thing. D2GS is closed source, but meanwhile I found something: http://www.koders.com/info.aspx?c=ProjectInfo&pid=XMU6UUQHA2SGMV48TY9KNNPNWH... What is this? Can this be used for to make the bugfix? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #35 from infobox.oleg(a)wo.cz 2011-05-08 16:56:52 CDT --- (In reply to comment #34)
D2GS is closed source, but meanwhile I found something: http://www.koders.com/info.aspx?c=ProjectInfo&pid=XMU6UUQHA2SGMV48TY9KNNPNWH... What is this? Can this be used for to make the bugfix?
This seems to be D2GS.exe source code. I don't know, if it can be used to solve the problem, but source for D2GS is itself invaluable (if it is real source). As I understood some time ago, nobody had D2GS source and nobody knew, where it came from. Anyway, what I did on my server was: - grab wine 1.2 and apply patch from this bug (1.3 won't accept patch) - run D2GS.exe in current state The ugly hack possibly breaks other wine things, but on dedicated server it doesn't matter. Oleg -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Alexey Loukianov <mooroon2(a)mail.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mooroon2(a)mail.ru --- Comment #36 from Alexey Loukianov <mooroon2(a)mail.ru> 2011-09-23 19:04:09 CDT --- That's not the source code of D2GS that is widely used with PVPGN. Real D2GS source code (which is actually a pack of ugly hacks over the existing game DLL's utilizing built-in game engine functionality to be used as a Realm game server) along with binaries can be downloaded from http://www.pvpgn.pl/d2gs/ . -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Nick <dillybob92(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dillybob92(a)gmail.com --- Comment #37 from Nick <dillybob92(a)gmail.com> 2013-02-21 12:11:45 CST --- I applied the bug fix on the wine1.5.24 sock.c on 395. http://forum.winehq.org/viewtopic.php?p=83703#p83703 See my above thread ^^^, now it does not connect. This is really frustrating guys, there has to be a fix for this, see that thread for the massive amount of problems with it. Hope someone can help, maybe I applied the patch wrongly? Thanks, Nick -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #38 from Nick <dillybob92(a)gmail.com> 2013-02-21 19:30:02 CST --- FIX: http://forum.winehq.org/viewtopic.php?p=83720#p83720 1.3.6 working only, thanks all. Sad that the sock.c shit is not fixed in the stable or development released, it's been what almost 5 years since this bug was posted? In any event, if anyone ever finds this topic/bug check my link above and you should get it to work. Cheers -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10204 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx(a)gmail.com --- Comment #39 from Bruno Jesus <00cpxxx(a)gmail.com> 2013-09-03 12:25:57 CDT --- Still in wine 1.7.1. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=10204 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man(a)post.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=10204 joaopa <jeremielapuree(a)yahoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree(a)yahoo.fr --- Comment #40 from joaopa <jeremielapuree(a)yahoo.fr> --- Does the bug still occur with wine-4.19? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=10204 Kirill <b14b14(a)yandex.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |b14b14(a)yandex.ru --- Comment #41 from Kirill <b14b14(a)yandex.ru> --- Still exists in 4.0.3 ;/ -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #42 from Damjan Jovanovic <damjan.jov(a)gmail.com> --- Can someone please test this patch (against latest Git): https://source.winehq.org/patches/data/176049 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=10204 --- Comment #43 from Damjan Jovanovic <damjan.jov(a)gmail.com> --- (In reply to Damjan Jovanovic from comment #42)
Can someone please test this patch (against latest Git): https://source.winehq.org/patches/data/176049
Or test 5.0-rc2, or later, as that patch was committed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=10204 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fgouget(a)codeweavers.com Keywords| |source -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=10204 GriffOn <failffon(a)163.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |failffon(a)163.com --- Comment #44 from GriffOn <failffon(a)163.com> --- (In reply to Damjan Jovanovic from comment #43)
(In reply to Damjan Jovanovic from comment #42)
Can someone please test this patch (against latest Git): https://source.winehq.org/patches/data/176049
Or test 5.0-rc2, or later, as that patch was committed.
6.0 still has this problem. I test 6.0 with this patch and it works. I also try test 6.9, the code changed too much to use this patch. But it seems 6.9 already fixed this bug. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla