[Bug 57474] New: Windows disappear irreversibly when are not shown on a virtual desktop
https://bugs.winehq.org/show_bug.cgi?id=57474 Bug ID: 57474 Summary: Windows disappear irreversibly when are not shown on a virtual desktop Product: Wine Version: 9.22 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: major Priority: P2 Component: winex11.drv Assignee: wine-bugs(a)winehq.org Reporter: oleh.nyk(a)gmail.com CC: rbernon(a)codeweavers.com Distribution: --- Created attachment 77482 --> https://bugs.winehq.org/attachment.cgi?id=77482 Log of WINEDEBUG=+x11drv,+event wine notepad 2>&1 With the introduction of new window handling functions in window.c since 9.21 Wine is unusable in virtual desktop configurations. I use a virtual desktop 2 rows by 3 columns in FVWM, and, as a window is no more shown because it is not on an active page, it is unmapped and disappears from the list of active windows in FVWM, and there is no way to get it back. Steps to reproduce: start FVWM with a virtual desktop with >1 page, start "wine notepad", move to another page and then back. The notepad.exe window is not shown both on the screen and in the window list, although the program is running. Log of WINEDEBUG=+x11drv,+event wine notepad 2>&1 is attached. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57474 --- Comment #1 from O. Nykyforchyn <oleh.nyk(a)gmail.com> --- A quick and dirty hack (commenting out the is_window_rect_mapped() check) makes things work. --- window.c.orig 2024-11-27 14:51:32.649671271 +0200 +++ window.c 2024-11-27 14:59:49.405653933 +0200 @@ -2945,8 +2945,7 @@ if (old_style & WS_VISIBLE) { - if (((swp_flags & SWP_HIDEWINDOW) && !(new_style & WS_VISIBLE)) || - (!(new_style & WS_MINIMIZE) && !is_window_rect_mapped( &new_rects->window ) && is_window_rect_mapped( &old_rects.window ))) + if ((swp_flags & SWP_HIDEWINDOW) && !(new_style & WS_VISIBLE)) { release_win_data( data ); unmap_window( hwnd ); What is interesting, adding !is_virtual_desktop() to the second line does not help, it seems that this function returns FALSE. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57474 --- Comment #2 from Rafał Mużyło <galtgendo(a)o2.pl> --- Are we talking about wine's virtual desktop or wm's virtual desktop ? Cause in the later case, 9.22 actually seemed to improve that handling (with openbox), as it no longer minimizes the windows on a desktop switch... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57474 --- Comment #3 from O. Nykyforchyn <oleh.nyk(a)gmail.com> --- About WM's desktop. It seems like Wine does not notice virtual desktop FVWM provides. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57474 mrdeathjr28(a)yahoo.es changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mrdeathjr28(a)yahoo.es -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57474 --- Comment #4 from Rémi Bernon <rbernon(a)codeweavers.com> --- Wine virtual desktop setting is completely unrelated, it corresponds to the "Emulate a virtual desktop" setting in winecfg. The issue here is probably that we now more accurately match the Win32 window position with the X window manager positions, whereas the re-entry guards before allowed them to sometimes get out of sync. I suspect that FVWM virtual desktop mode works by having different coordinate spaces for each desktop, but Wine is not aware of that and it believes that windows on the non-active desktops are being moved off screen. Off-screen windows have historically been hidden, perhaps because it is allowed to have visible windows outside of the virtual screen on Windows (although that needs to be confirmed), and probably to avoid triggering WM-specific mechanisms that would try to move them back on screen. We would need to remove that workaround to fix this, or perhaps to make it optional, so that it can be opted-in in use cases similar to FVWM virtual desktops. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57474 Rémi Bernon <rbernon(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |895ca2eda64f506b936999cdd8f | |14e224eef6a7f Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #5 from Rémi Bernon <rbernon(a)codeweavers.com> --- I believe 895ca2eda64f506b936999cdd8f14e224eef6a7f fixes this as well. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57474 --- Comment #6 from O. Nykyforchyn <oleh.nyk(a)gmail.com> --- 895ca2eda64f506b936999cdd8f14e224eef6a7f seems to have fixed the problem. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57474 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 10.0-rc1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57474 Richard Thier <u9vata(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |u9vata(a)gmail.com --- Comment #8 from Richard Thier <u9vata(a)gmail.com> --- *** Bug 57616 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla