[Bug 53583] New: the Reimplemented FindNLSStringEx has bug
https://bugs.winehq.org/show_bug.cgi?id=53583 Bug ID: 53583 Summary: the Reimplemented FindNLSStringEx has bug Product: Wine Version: 7.15 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: kernel32 Assignee: wine-bugs(a)winehq.org Reporter: 398063392(a)qq.com Distribution: --- Created attachment 72966 --> https://bugs.winehq.org/attachment.cgi?id=72966 the code project #include "stdafx.h" #include <windows.h> #include <assert.h> int _tmain(int argc, _TCHAR* argv[]) { DWORD flags = NORM_LINGUISTIC_CASING|FIND_STARTSWITH; int nResult = FindNLSStringEx(L"en-US",flags,L"x-oss-security-token",0xe,L"x-oss-",0x6,0,0,0,0); printf("FindNLSStringEx Result = %d \r\n", nResult); assert(nResult == 0); return 0; } the code in Windows print: "FindNLSStringEx Result = 0" but in Wine print: "FindNLSStringEx Result = -1 Assertion failed: nResult == 0, file .\FindNLSStringEx.cpp, line 13 " FindNLSStringEx is very important for C#, because it is the basis of the String class, StartsWith, EndsWith, IndexOf all rely on it to achieve. So hopefully you guys can test it rigorously, thanks a lot. In addition, I found a lot of bugs and fixed them myself, how can I submit these PRs? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53583 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zzhang(a)codeweavers.com --- Comment #1 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- You can submit them via GitLab merge requests. See https://gitlab.winehq.org/wine/wine. Thanks. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53583 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, testcase -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53583 --- Comment #2 from JK_STAR <398063392(a)qq.com> --- But when I use my accounts in https://gitlab.winehq.org/users/sign_in, I got the message: "Invalid login or password." -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53583 --- Comment #3 from Jactry Zeng <jactry92(a)gmail.com> --- (In reply to JK_STAR from comment #2)
But when I use my accounts in https://gitlab.winehq.org/users/sign_in, I got the message: "Invalid login or password."
I guess you will need to wait until your registration is approved. Here is a guide about the process: https://wiki.winehq.org/Git_Wine_Tutorial#Creating_a_fork_on_Gitlab -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53583 --- Comment #4 from JK_STAR <398063392(a)qq.com> --- (In reply to Jactry Zeng from comment #3)
(In reply to JK_STAR from comment #2)
But when I use my accounts in https://gitlab.winehq.org/users/sign_in, I got the message: "Invalid login or password."
I guess you will need to wait until your registration is approved. Here is a guide about the process: https://wiki.winehq.org/Git_Wine_Tutorial#Creating_a_fork_on_Gitlab
OK,thanks. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53583 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #5 from Nikolay Sivov <bunglehead(a)gmail.com> --- Weirdly enough this is not about flags, or explicit string lengths. It starts failing for me on trailing dash, so comparing "x-oss-security" to "x-oss" works, but with "x-oss-" it doesn't. Confirming. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53583 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|the Reimplemented |FindNLSStringEx |FindNLSStringEx has bug |reimplementation doesn't | |match native -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53583 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Fixed by SHA1| |448e68ab5b937d168f5d091d8f6 | |5a7de534a9891 Resolution|--- |FIXED --- Comment #6 from Alexandre Julliard <julliard(a)winehq.org> --- Fixed by 448e68ab5b937d168f5d091d8f65a7de534a9891. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53583 --- Comment #7 from JK_STAR <398063392(a)qq.com> --- Very thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53583 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #8 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 8.0-rc4. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla