[Bug 18130] New: VB APPS: Using edit controls context menu crashes application.
http://bugs.winehq.org/show_bug.cgi?id=18130 Summary: VB APPS: Using edit controls context menu crashes application. Product: Wine Version: 1.1.19 Platform: Other OS/Version: other Status: UNCONFIRMED Severity: normal Priority: P2 Component: user32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: martinmnet(a)hotmail.com Vb applications crash when I click on any selection from edit windows context menu. Reason: menu control is sending WM_COMMAND msg to edit control and shouldnt be. The VB runtime subclass' the edit control and dies when receiving WM_COMMAND with the sent wParam. Solution. Change menu.c approx line 2561 to check if window is appropriate before sending WM_COMMAND, i.e. not edit class windows. Replace edit.c function EDIT_WM_Command static void EDIT_WM_MenuSelect(EDITSTATE *es, INT code, INT id, HWND control) { static INT SelectedItem; if (id != 0) { /* Save the currently selected item and return */ SelectedItem = id; return; } switch (SelectedItem) { case EM_UNDO: SendMessageW(es->hwndSelf, WM_UNDO, 0, 0); break; case WM_CUT: SendMessageW(es->hwndSelf, WM_CUT, 0, 0); break; case WM_COPY: SendMessageW(es->hwndSelf, WM_COPY, 0, 0); break; case WM_PASTE: SendMessageW(es->hwndSelf, WM_PASTE, 0, 0); break; case WM_CLEAR: SendMessageW(es->hwndSelf, WM_CLEAR, 0, 0); break; case EM_SETSEL: EDIT_EM_SetSel(es, 0, (UINT)-1, FALSE); EDIT_EM_ScrollCaret(es); break; default: ERR("unknown menu item, please report\n"); break; } } and change edit.c line 5195 case WM_COMMAND: EDIT_WM_Command(es, HIWORD(wParam), LOWORD(wParam),(HWND)lParam); to case WM_MENUSELECT: EDIT_WM_MenuSelect(es, HIWORD(wParam), LOWORD(wParam),(HWND)lParam); -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18130 --- Comment #1 from Austin English <austinenglish(a)gmail.com> 2009-04-20 22:04:39 --- Please send a patch to wine-patches(a)winehq.org -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18130 --- Comment #2 from martinmnet <martinmnet(a)hotmail.com> 2009-04-20 23:55:30 --- Done -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18130 --- Comment #3 from martinmnet <martinmnet(a)hotmail.com> 2009-05-01 09:45:39 --- Created an attachment (id=20855) --> (http://bugs.winehq.org/attachment.cgi?id=20855) Test demonstrating problem with edit control implementation in wine Attachment demonstrates vb application crashes with WINE. The application uses PostMessage to simulate doing a clipboard paste on the edit control. Running with no command line argument or 1 the application crashes. Any value higher than 1 the edit control is subclassed and will catch the bogus WM_COMMAND message and prevent the crash. Application uses stdout for displaying information. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18130 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, testcase -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18130 --- Comment #4 from martinmnet <martinmnet(a)hotmail.com> 2009-06-06 09:47:38 --- Bump. May i please get the status on this? Was the patch sent to mailing list rejected? Martin -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18130 --- Comment #5 from Austin English <austinenglish(a)gmail.com> 2009-06-06 14:19:02 --- (In reply to comment #4)
Bump. May i please get the status on this? Was the patch sent to mailing list rejected?
Hmm, looks like it. Try resending and ask for comments. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18130 --- Comment #6 from martinmnet <martinmnet(a)hotmail.com> 2009-06-08 03:04:14 --- Created an attachment (id=21639) --> (http://bugs.winehq.org/attachment.cgi?id=21639) Fixes crash when using edit context menu for application linked to vb6 runtime The above application demonstrates problem. Mike -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18130 martinmnet <martinmnet(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21639|0 |1 is obsolete| | --- Comment #7 from martinmnet <martinmnet(a)hotmail.com> 2009-10-04 00:49:37 --- Created an attachment (id=23903) --> (http://bugs.winehq.org/attachment.cgi?id=23903) c++ source for demonstrating problem in Windows the edit control's context menu does not send WM_COMMAND messages to the edit control wndproc. Wine implementation does, which is the cause of this bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18130 Gabriele Moabiti <gabmoa(a)yahoo.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gabmoa(a)yahoo.it --- Comment #8 from Gabriele Moabiti <gabmoa(a)yahoo.it> 2009-11-10 08:58:06 ---
in Windows the edit control's context menu does not send WM_COMMAND messages to the edit control wndproc. Wine implementation does, which is the cause of this bug.
I can confirm then behaviour. I have two VB6 utility affected by this problem (they crashed). We should test in the different windows versions what happen. The patch works fine for me! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18130 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |nerv(a)dawncrow.de Ever Confirmed|0 |1 --- Comment #9 from André H. <nerv(a)dawncrow.de> 2010-01-26 12:46:03 --- confirming in Wine-1.1.37 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18130 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx(a)gmail.com --- Comment #10 from Bruno Jesus <00cpxxx(a)gmail.com> 2011-09-07 22:18:36 CDT --- Still present in 1.3.27. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18130 --- Comment #11 from Bruno Jesus <00cpxxx(a)gmail.com> 2012-05-10 22:38:31 CDT --- Seems fixed in wine 1.5.3. The demo application no longer crashes, although the context menu operations do not work as seen in bug 29379. Can anyone else retest? The compiled test is attached and it's very small. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18130 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #12 from Austin English <austinenglish(a)gmail.com> 2012-05-11 12:29:27 CDT --- Doesn't crash here either in wine-1.5.3-278-gcf89638 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18130 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #13 from Alexandre Julliard <julliard(a)winehq.org> 2012-05-11 13:21:54 CDT --- Closing bugs fixed in 1.5.4. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org