[Bug 9676] New: pedantic type errors on osx
http://bugs.winehq.org/show_bug.cgi?id=9676 Summary: pedantic type errors on osx Product: Wine Version: unspecified Platform: Macintosh OS/Version: Mac OS X 10.4 Status: UNCONFIRMED Severity: blocker Priority: P2 Component: wine-gui AssignedTo: wine-bugs(a)winehq.org ReportedBy: daniel(a)danieloberhoff.de Hi, Just built wine from..err..git :). Had a few build errors in wgl.c due to missing or undefined (and redundant) typecasts. Here is the diff as how I fixed them (a few are just warnings, specifically the printf format related ones). diff --git a/dlls/opengl32/wgl.c b/dlls/opengl32/wgl.c index 029f361..f6e2012 100644 --- a/dlls/opengl32/wgl.c +++ b/dlls/opengl32/wgl.c @@ -348,7 +348,7 @@ static void tess_callback_vertex(GLvoid *vertex) static void tess_callback_begin(GLenum which) { - TRACE("%d\n", which); + TRACE("%d\n", (int)which); glBegin(which); } @@ -387,8 +387,8 @@ static BOOL WINAPI wglUseFontOutlines_common(HDC hdc, tess = gluNewTess(); if(tess) { - gluTessCallback(tess, GLU_TESS_VERTEX, (_GLUfuncptr)tess_callback_vertex); - gluTessCallback(tess, GLU_TESS_BEGIN, (_GLUfuncptr)tess_callback_begin); + gluTessCallback(tess, GLU_TESS_VERTEX, tess_callback_vertex); + gluTessCallback(tess, GLU_TESS_BEGIN, tess_callback_begin); gluTessCallback(tess, GLU_TESS_END, tess_callback_end); } LEAVE_GL(); @@ -573,7 +573,7 @@ BOOL WINAPI wglUseFontOutlinesW(HDC hdc, */ void WINAPI wine_glEnable( GLenum cap ) { - TRACE("(%d)\n", cap ); + TRACE("(%d)\n", (int)cap ); wine_wgl.p_wglEnable(cap); } @@ -582,7 +582,7 @@ void WINAPI wine_glEnable( GLenum cap ) */ GLboolean WINAPI wine_glIsEnabled( GLenum cap ) { - TRACE("(%d)\n", cap ); + TRACE("(%d)\n", (int)cap ); return wine_wgl.p_wglIsEnabled(cap); } @@ -591,7 +591,7 @@ GLboolean WINAPI wine_glIsEnabled( GLenum cap ) */ void WINAPI wine_glDisable( GLenum cap ) { - TRACE("(%d)\n", cap ); + TRACE("(%d)\n", (int)cap ); wine_wgl.p_wglDisable(cap); } @@ -600,7 +600,7 @@ void WINAPI wine_glDisable( GLenum cap ) */ void WINAPI wine_glScissor( GLint x, GLint y, GLsizei width, GLsizei height ) { - TRACE("(%d, %d, %d, %d)\n", x, y, width, height ); + TRACE("(%d, %d, %d, %d)\n", (int)x, (int)y, (int)width, (int)height ); wine_wgl.p_wglScissor(x, y, width, height); } @@ -609,7 +609,7 @@ void WINAPI wine_glScissor( GLint x, GLint y, GLsizei width, GLsizei height ) */ void WINAPI wine_glViewport( GLint x, GLint y, GLsizei width, GLsizei height ) { - TRACE("(%d, %d, %d, %d)\n", x, y, width, height ); + TRACE("(%d, %d, %d, %d)\n", (int)x, (int)y, (int)width, (int)height ); wine_wgl.p_wglViewport(x, y, width, height); } -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9676 Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID --- Comment #1 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2007-09-15 17:11:47 --- Invalid. If you want to provide path, there is an "ADD AN ATTACHMENT" link / button! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9676 Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #2 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2007-09-15 17:12:05 --- Closing invalid -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9676 --- Comment #3 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2007-09-15 17:12:57 --- IF you want to send your patches - use wine-patches(a)winehq.org mailing list! And specify which exactly errors are you trying to fix? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9676 --- Comment #4 from daniel oberhoff <daniel(a)danieloberhoff.de> 2007-09-15 17:16:58 --- Created an attachment (id=8096) --> (http://bugs.winehq.org/attachment.cgi?id=8096) path as separate file patch as separate file -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9676 --- Comment #5 from daniel oberhoff <daniel(a)danieloberhoff.de> 2007-09-15 17:24:24 --- sorry, wrong file... but anyhow, I moved it to the list as suggested. I assumed it was ok to send patches here since there is an explicit "append patch" checkbox :). The errors are about a redundant (at least here) typedef to an undefined type (->error) and usage of texture rectangle extensions through _NV constants which are equivalent to _EXT constants on osx (where the _NV ones are undefined). Fixed it through a conditional redefinition of the NV constants (i.e. when the are undefined). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9676 James Hawkins <truiken(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|_obsolete_gui |-unknown -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9676 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish(a)gmail.com Platform|Macintosh |PC -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9676 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- OS/Version|Mac OS X 10.4 |Mac OS X -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org