[Bug 45243] New: Wrong cast in some HANDLE_MSG_WM_* macros produces errors when compiling with wineg++
https://bugs.winehq.org/show_bug.cgi?id=45243 Bug ID: 45243 Summary: Wrong cast in some HANDLE_MSG_WM_* macros produces errors when compiling with wineg++ Product: Wine Version: 3.8 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: winelib Assignee: wine-bugs(a)winehq.org Reporter: sacrom(a)gmail.com Distribution: --- Created attachment 61481 --> https://bugs.winehq.org/attachment.cgi?id=61481 Simple event handler function with HANDLE_MSG macro Compiling a message handler with some HANDLE_MSG() Macros (defined in windowsx.h) with wineg++ a cast error is produced. I attached a test.c simple example and the compile results can be seen in wineg++.err file -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45243 --- Comment #1 from Marcos Gutiérrez Batz <sacrom(a)gmail.com> --- Created attachment 61482 --> https://bugs.winehq.org/attachment.cgi?id=61482 wineg++ compilation line with the error result -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45243 Marcos Gutiérrez Batz <sacrom(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|x86 |x86-64 --- Comment #2 from Marcos Gutiérrez Batz <sacrom(a)gmail.com> --- Is important to note Using the Windows windowsx.h file I've modified the UINT -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45243 --- Comment #3 from Marcos Gutiérrez Batz <sacrom(a)gmail.com> --- It's important to note that the cast error is generated because it is a 64bit compilation. Using as a reference the Windows windowx.h file I've changed UINT casts with UINT_PTR so that it must now work in 32 and 64 bit applications. I'm going to add a "diff -up" patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45243 Marcos Gutiérrez Batz <sacrom(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sacrom(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45243 --- Comment #4 from Marcos Gutiérrez Batz <sacrom(a)gmail.com> --- Created attachment 61483 --> https://bugs.winehq.org/attachment.cgi?id=61483 Changes to windowsx.h to fix the macro casts -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45243 Marcos Gutiérrez Batz <sacrom(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61483|0 |1 is obsolete| | --- Comment #5 from Marcos Gutiérrez Batz <sacrom(a)gmail.com> --- Created attachment 61484 --> https://bugs.winehq.org/attachment.cgi?id=61484 Currected diff -up file to to fix the macro casts -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45243 tokktokk <fdsfgs(a)krutt.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fdsfgs(a)krutt.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45243 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zzhang(a)codeweavers.com --- Comment #6 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Confirmed. You can send a patch to wine-devel. Thanks. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45243 --- Comment #7 from Marcos Gutiérrez Batz <sacrom(a)gmail.com> --- I've just submitted a patch to wine-devel. As this is my first patch submitted I hope it to be correctly "produced" -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45243 --- Comment #8 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- (In reply to Marcos Gutiérrez Batz from comment #7) Your patch was committed as https://source.winehq.org/git/wine.git/commit/62f253b592b51f4f3515267f956e00... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45243 Marcos Gutiérrez Batz <sacrom(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #9 from Marcos Gutiérrez Batz <sacrom(a)gmail.com> --- Yes you´re right, I guess the bug status must be changed to resolved/fixed then. Thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45243 Józef Kucia <joseph.kucia(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joseph.kucia(a)gmail.com Fixed by SHA1| |62f253b592b51f4f3515267f956 | |e00d8e7b00937 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45243 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #10 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 3.10. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45243 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45243 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|3.0.x |--- --- Comment #11 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 3.0.x milestone from bugs included in 3.0.3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org