[Bug 57748] New: #include w/o newline makes no effect
https://bugs.winehq.org/show_bug.cgi?id=57748 Bug ID: 57748 Summary: #include w/o newline makes no effect Product: vkd3d Version: 1.14 Hardware: x86-64 OS: MacOS Status: UNCONFIRMED Severity: normal Priority: P2 Component: hlsl Assignee: wine-bugs(a)winehq.org Reporter: igelbox(a)gmail.com STALKER Anomaly Custom game fails to launch due to shader compilation errors: 1. Expected T_NEWLINE, example: ``` //================================================================================================= #include "pbr_settings.h" //load settings files #define PI 3.14159265359 ``` 2 The "tonemap_srgb.h" did't included at all when it locates at the eof without a trailing newline: ``` // some srgb.h file content #include "tonemap_srgb.h" ``` so the error is `vkd3d:05f4:trace:vkd3d_shader_compile :800:16: E5005: Function "tonemap_sRGB" is not defined.` but it actually is in the "tonemap_srgb.h" file -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57748 --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> --- Are you talking about newlines at the end of the file? We have special case for that, and it seems to work. Could you please attach a set of files that show this problem. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57748 --- Comment #2 from igelbox(a)gmail.com --- Created attachment 77998 --> https://bugs.winehq.org/attachment.cgi?id=77998 My own simple example cases coz I'm not sure of original shaders license Sorry for being late, Crossover lost my license and locked the bottle. Yes, I'm talking about lack of a new line at the end of the file. Not sure if I have rights to attach game shaders here coz I don't know what a license they use. So I created and attached my own simple example of 2 cases: 0. include via proxy header with no newline at the end [failing] 1. direct include - [working] (actually failing but due to other game shaders) I just checked those cases on CrossOver 24.0.7.37107. Also, they're reproducing on [my custom wined3d.dll](https://github.com/igelbox/wine/pull/2/commits) (build with vkd3d from 5bfcd811824e9ca03c09a54204bff645225c3408 commit) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57748 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #3 from Nikolay Sivov <bunglehead(a)gmail.com> --- Yes, I think I can reproduce, thanks. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla