[Bug 21502] New: missing valgrind annotation in mark_block_free
http://bugs.winehq.org/show_bug.cgi?id=21502 Summary: missing valgrind annotation in mark_block_free Product: Wine Version: 1.1.37 Platform: x86 OS/Version: Linux Status: NEW Keywords: download, patch, source Severity: normal Priority: P2 Component: ntdll AssignedTo: wine-bugs(a)winehq.org ReportedBy: dank(a)kegel.com Running any test with +heap and valgrind, e.g. WINEDEBUG=+heap WINETEST_WRAPPER=valgrind make atom.ok generates warnings like this: Invalid write of size 4 at mark_block_free (heap.c:175) by heap_set_debug_flags (heap.c:1382) by RtlCreateHeap (heap.c:1446) by virtual_init (virtual.c:1354) by thread_init (thread.c:203) by __wine_process_init (loader.c:2850) by wine_init (loader.c:711) by main (main.c:218) Address 0xbfa60138 is not stack'd, malloc'd or (recently) free'd This is due to a missing annotation in mark_block_free. The attached patch makes the warning go away. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21502 --- Comment #1 from Austin English <austinenglish(a)gmail.com> 2011-01-13 15:30:05 CST --- Forgot the patch. In any case, I didn't get any of them in yesterday's git: http://austinenglish.com/logs/valgrind/2011-01-12/2011-01-12-18.50.log -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21502 --- Comment #2 from Austin English <austinenglish(a)gmail.com> 2011-01-13 15:35:50 CST --- Hm, that wasn't with +heap. I tried dlls/msxml3/tests/domdoc.c with +heap and valgrind though, works fine in today's git. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21502 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WONTFIX --- Comment #3 from Dan Kegel <dank(a)kegel.com> 2011-01-13 15:43:52 CST --- I don't think you need to do +heap anymore, wine senses it's running under valgrind and turns the appropriate stuff on (and off). The check that complained may have been disabled by a75ae7936eb2581cdc6a7a5050ae79add0cb4ab1 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=21502 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Austin English <austinenglish(a)gmail.com> 2011-01-13 17:42:31 CST --- Closing. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org