[Bug 18779] New: HttpAddRequestHeaders() doesn't handle whitespace correctly
http://bugs.winehq.org/show_bug.cgi?id=18779 Summary: HttpAddRequestHeaders() doesn't handle whitespace correctly Product: Wine Version: unspecified Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: wininet AssignedTo: wine-bugs(a)winehq.org ReportedBy: yann(a)droneaud.fr Created an attachment (id=21550) --> (http://bugs.winehq.org/attachment.cgi?id=21550) Tests case for whitespace in HTTP headers After some research for bug #17914 it seems that HttpAddRequestHeaders() doesn't parse correctly headers regarding to whitespace. Some whitespaces are not removed. Additionnaly, I found that wininet.dll from IE8 doesn't allow retrieving some headers with HttpQueryInfo() if they have whitespace in them, while wine does. Here is a patch which add some tests for whitespace. Thoses new test works with wininet.dll from IE8. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18779 --- Comment #1 from Austin English <austinenglish(a)gmail.com> 2009-06-04 12:36:15 --- Please send the patch to wine-patches(a)winehq.org. Be sure to wrap failing test in todo_wine. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18779 Paul Vriens <Paul.Vriens.Wine(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Paul.Vriens.Wine(a)gmail.com --- Comment #2 from Paul Vriens <Paul.Vriens.Wine(a)gmail.com> 2009-06-04 12:59:00 --- Do these new tests also work on anything earlier then IE8? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18779 --- Comment #3 from Yann Droneaud <yann(a)droneaud.fr> 2009-06-05 03:21:08 --- (In reply to comment #1)
Please send the patch to wine-patches(a)winehq.org. Be sure to wrap failing test in todo_wine.
I will provide a patch to wininet too, see bug #17914. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18779 --- Comment #4 from Yann Droneaud <yann(a)droneaud.fr> 2009-06-05 03:49:06 --- (In reply to comment #2)
Do these new tests also work on anything earlier then IE8?
Tested against wininet.dll version 7.00.5730.13 (IE8 ?) and 7.00.6000.16827 (IE7). I'm now not sure this was IE8. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18779 --- Comment #5 from Paul Vriens <Paul.Vriens.Wine(a)gmail.com> 2009-06-05 03:57:41 --- IE7 uses wininet 7.* and IE8 uses 8.* AFAIK (looking at my own boxes). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18779 Ken Sharp <kennybobs(a)o2.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, patch, source Version|unspecified |1.1.22 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18779 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx(a)gmail.com --- Comment #6 from Bruno Jesus <00cpxxx(a)gmail.com> 2011-11-19 17:34:13 CST --- Friendly reminder of 2 years without posts. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=18779 --- Comment #7 from austinenglish(a)gmail.com --- I rebased the patches, made a couple minor fixes and resent: https://source.winehq.org/patches/data/104012 though if there's not an application that this bug is targeting, I'd say to close it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=18779 --- Comment #8 from Bruno Jesus <00cpxxx(a)gmail.com> --- (In reply to Austin English from comment #7)
I rebased the patches, made a couple minor fixes and resent: https://source.winehq.org/patches/data/104012
though if there's not an application that this bug is targeting, I'd say to close it.
I can't find the patch in git. Seems it was not commited even if they were only tests. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=18779 --- Comment #9 from Bruno Jesus <00cpxxx(a)gmail.com> --- (In reply to Bruno Jesus from comment #8)
(In reply to Austin English from comment #7)
I rebased the patches, made a couple minor fixes and resent: https://source.winehq.org/patches/data/104012
though if there's not an application that this bug is targeting, I'd say to close it.
I can't find the patch in git. Seems it was not commited even if they were only tests.
Austin, care to resend? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=18779 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man(a)post.com --- Comment #10 from super_man(a)post.com --- (In reply to Bruno Jesus from comment #9)
(In reply to Bruno Jesus from comment #8)
(In reply to Austin English from comment #7)
I rebased the patches, made a couple minor fixes and resent: https://source.winehq.org/patches/data/104012
though if there's not an application that this bug is targeting, I'd say to close it.
I can't find the patch in git. Seems it was not commited even if they were only tests.
Austin, care to resend?
patching file dlls/wininet/tests/http.c Hunk #1 succeeded at 1627 (offset 84 lines). Hunk #2 succeeded at 1947 (offset 86 lines). against wine-git -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=18779 winetest(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest(a)luukku.com --- Comment #11 from winetest(a)luukku.com --- (In reply to super_man from comment #10)
(In reply to Bruno Jesus from comment #9)
(In reply to Bruno Jesus from comment #8)
(In reply to Austin English from comment #7)
I rebased the patches, made a couple minor fixes and resent: https://source.winehq.org/patches/data/104012
though if there's not an application that this bug is targeting, I'd say to close it.
I can't find the patch in git. Seems it was not commited even if they were only tests.
Austin, care to resend?
patching file dlls/wininet/tests/http.c Hunk #1 succeeded at 1627 (offset 84 lines). Hunk #2 succeeded at 1947 (offset 86 lines).
against wine-git
patching file dlls/wininet/tests/http.c Hunk #1 succeeded at 1652 (offset 109 lines). Hunk #2 succeeded at 1972 (offset 111 lines). against wine 2.8-git. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org