[Bug 38881] New: listview control sends messages before updating items
https://bugs.winehq.org/show_bug.cgi?id=38881 Bug ID: 38881 Summary: listview control sends messages before updating items Product: Wine Version: unspecified Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: comctl32 Assignee: wine-bugs(a)winehq.org Reporter: aeikum(a)codeweavers.com Distribution: --- Wine's listview control sends LVN_ITEMCHANGED notifications as items are updated. For example, when changing the selected item, it sends a notification that the old item was deselected, and then sends a notification that the new item has been selected. If an application queries the current selection during the first notification, it will appear that no items are selected. This is different from how Windows behaves, which appears to send notifications only after updating all item states. This breaks the Ancestral Quest program's Changelog feature, though this requires the program to be purchased. It shouldn't be too hard to write tests demonstrating this, either. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38881 --- Comment #1 from Andrew Eikum <aeikum(a)codeweavers.com> --- Created attachment 51815 --> https://bugs.winehq.org/attachment.cgi?id=51815 Tests for LVM_GETSELECTIONMARK during notifications This is a set of tests showing that LVM_GETSELECTIONMARK should be updated before notifications are sent. The item's state (LVM_GETITEMSTATE) should also be updated, though these tests don't demonstrate that. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38881 Sergey Lisitski <lisitski.segrey(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisitski.segrey(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38881 Sergey Lisitski <lisitski.segrey(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|lisitski.segrey(a)gmail.com | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38881 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38881 temp82(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |temp82(a)luukku.com --- Comment #2 from temp82(a)luukku.com --- merges almost cleanly patching file dlls/comctl32/tests/listview.c Hunk #1 succeeded at 57 (offset 2 lines). Hunk #2 succeeded at 540 (offset 33 lines). Hunk #3 succeeded at 1112 (offset 21 lines). Hunk #4 succeeded at 1212 (offset 21 lines). Hunk #5 succeeded at 1241 with fuzz 2 (offset 22 lines). Hunk #6 succeeded at 1392 (offset 24 lines). Hunk #7 FAILED at 2312. Hunk #8 succeeded at 2450 (offset 106 lines). Hunk #9 succeeded at 2619 (offset 112 lines). Hunk #10 succeeded at 2641 (offset 112 lines). Hunk #11 succeeded at 2657 (offset 112 lines). Hunk #12 succeeded at 2681 (offset 112 lines). Hunk #13 succeeded at 2719 (offset 112 lines). Hunk #14 succeeded at 3237 (offset 60 lines). Hunk #15 succeeded at 3478 (offset 60 lines). Hunk #16 succeeded at 3584 (offset 82 lines). Hunk #17 succeeded at 4056 (offset 64 lines). Hunk #18 succeeded at 4321 (offset 48 lines). Hunk #19 succeeded at 5390 with fuzz 2 (offset 320 lines). Hunk #20 succeeded at 5585 (offset 189 lines). Hunk #21 succeeded at 5956 (offset 241 lines). Hunk #22 succeeded at 6003 (offset 241 lines). 1 out of 22 hunks FAILED -- saving rejects to file dlls/comctl32/tests/listview.c.rej against wine (HEAD is now at 6fe37b46564) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38881 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4(a)web.de --- Comment #3 from Fabian Maurer <dark.shadow4(a)web.de> --- Any news on upstreaming this? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=38881 KRosUser <kyle.kcsoftwares(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.kcsoftwares(a)gmail.com --- Comment #4 from KRosUser <kyle.kcsoftwares(a)gmail.com> --- May be the cause for https://bugs.winehq.org/show_bug.cgi?id=40416 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=38881 --- Comment #5 from KRosUser <kyle.kcsoftwares(a)gmail.com> --- Maybe the cause for https://bugs.winehq.org/show_bug.cgi?id=58365 too -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs@winehq.org -
WineHQ Bugzilla