[Bug 57632] New: fallout 3 radio broke with gstreamer 1.24.10 (9.22 silent, 10rc4 stalls)
https://bugs.winehq.org/show_bug.cgi?id=57632 Bug ID: 57632 Summary: fallout 3 radio broke with gstreamer 1.24.10 (9.22 silent, 10rc4 stalls) Product: Wine Version: 10.0-rc4 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: quartz Assignee: wine-bugs(a)winehq.org Reporter: zlice(a)crtdrift.us Distribution: --- old similar bug https://bugs.winehq.org/show_bug.cgi?id=42033 (i'm sure there's more but this should be the latest) recently updated to gstreamer 1.24.10 which had security patches wine 9.22 the radio does not work, nor in 10rc4 but it does have less output errors and crash/stall in 10rc4. 9.22 is just silent, no radio but you keep playing. the last line in terminal (without WINEDEBUG) is different for 9.22 and 10rc4 01c8:err:quartz:DSoundRender_SendSampleData WaitForSingleObject() returned 0. ^^^ 9.22 vvv 10.0rc4 0024:err:quartz:BaseMemAllocator_Decommit Waiting: 1 since these were mostly security fixes i assumed it's something wine may have to update? if it doesn't seem that way let me know and i can go make a bug over there -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 --- Comment #1 from zlice <zlice(a)crtdrift.us> --- Created attachment 77759 --> https://bugs.winehq.org/attachment.cgi?id=77759 wine922-dbglog -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 --- Comment #2 from zlice <zlice(a)crtdrift.us> --- Created attachment 77760 --> https://bugs.winehq.org/attachment.cgi?id=77760 wine10rc4-dbglog -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 --- Comment #3 from Rafał Mużyło <galtgendo(a)o2.pl> --- Given the amount of changes made in winegstreamer/quartz since bug 42033 was filed, I strongly doubt that one is still relevant here. However, some significant changes were made to DSoundRender just before wine went into code freeze, so just to clarify: did things work in 9.21 ? Also, attach whole output, not just the lines *you* think are relevant. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 --- Comment #4 from Rafał Mużyło <galtgendo(a)o2.pl> --- There's a chance though you've simply failed to install the relevant gstreamer plugins during that update... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 --- Comment #5 from zlice <zlice(a)crtdrift.us> --- Created attachment 77761 --> https://bugs.winehq.org/attachment.cgi?id=77761 winedbg-foe-10rc4-full -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 --- Comment #6 from zlice <zlice(a)crtdrift.us> --- Created attachment 77762 --> https://bugs.winehq.org/attachment.cgi?id=77762 winedbg-fo3-922-full -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 --- Comment #7 from zlice <zlice(a)crtdrift.us> --- double checked gst-plugins-bad and other 32bit plugins are up to date on 10.24.10 uploaded full WINEDEBUG output i can't say for sure that new gstreamer worked with 9.21 as it was just updated before the new year and i was already on 9.22 will try to downgrade and see what/if anything changes -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 --- Comment #8 from zlice <zlice(a)crtdrift.us> --- well, i downgraded, things worked, then re-upgrade, things work. not entirely sure what it is. i did wait for a new song to start playing and toggled on/off/on world + pipboy radios. i'll try to sit there and let it play just to see if it's a specific file or something weird. probably a botched update though? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 --- Comment #9 from zlice <zlice(a)crtdrift.us> --- the real problem seems to be 'when a new song plays' if you have a song that is ABOUT to play, and you turn off the radio, and wait some time for it to start, then turn the pipboy radio on, it seems to play fine. wine 10 still hard freezes when a new song starts and you have to kill it. (gstreamer 1.24.9 or 1.24.10) wine 9.12, 9.13, 9.14, 9.18, 9.19 - may have a higher chance to actually play a song at start? at least sometimes they will play a song at start. 9.20, 9.21, 9.22 i don't think i got a radio song to play at start at all -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 --- Comment #10 from zlice <zlice(a)crtdrift.us> --- Created attachment 77763 --> https://bugs.winehq.org/attachment.cgi?id=77763 fallout_3_save save outside 101 with "inkspots - maybe" about to come on -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 Béla Gyebrószki <gyebro69(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |gyebro69(a)gmail.com, | |z.figura12(a)gmail.com Regression SHA1| |e6b8e9ee20937f12dbf19145a9f | |2ca1ca3364da3 --- Comment #11 from Béla Gyebrószki <gyebro69(a)gmail.com> --- I can reproduce the problem using the savegame from comment #10. The game locks up immediately after the game was loaded as soon as music begins to play. 0024:err:sync:RtlpWaitForCriticalSection section 003F2C98 "../wine-git/dlls/winegstreamer/quartz_parser.c: pin.flushing_cs" wait timed out in thread 0024, blocked by 01bc, retrying (60 sec) This is a regression from Wine-10.0-rc1: commit e6b8e9ee20937f12dbf19145a9f2ca1ca3364da3 quartz/dsoundrender: Use send_sample_data() to fill the buffer with silence at EOS. Reverting the patch fixes the problem for me. The other issue the bug reporter mentioned: the savegame loads but music doesn't start to play with Wine-9.22. That seems to be another possible regression somewhere between Wine 9.5 and 9.8 which yet to be found. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 --- Comment #12 from zlice <zlice(a)crtdrift.us> --- i still had random radio playback on wine 9.5, although it seems more likely to play the further back you go. up to 9.11 i was able to get the next song playing, then i tried 9.12 and it seemed to break everything and reduce the chances...then i rebooted and experienced more or less the same. hard to tell since it's random. i can try to go back further but i'm not really sure that will lead to anything. the last thing i remember fixing/breaking a radio issue for Fallout 3 was apparently 2 years ago between 7.3 and 7.4. anything before 9.0 looks like wow64 may be missing so it doubles build time -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 --- Comment #13 from zlice <zlice(a)crtdrift.us> --- looks like between b87f35898d22b90e36970e0b1fce1172ba64eb15 and 63e25f9edaf319529e87b380d01bff5cafa17f06 (9.11 and 9.12) not sure why/how running 9.12 affects lower versions but after a reboot everything i tried between 8.18 and 9.11 played the next radio song a few times in a row love bisecting commits -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 --- Comment #14 from zlice <zlice(a)crtdrift.us> --- i have no clue what's going on or how to debug at this point started bisecting, nothing made sense, some things stopped working then started working. tried the commits for releases 9.11 and 9.12 and both worked, reinstall 9.12, rebuild release 9.12 from tar and not commits, everything's fine. source files from 9.12 and the commit release of 9.12 were identical. obviously the 10rc4 crash is real. at least the 9.x no radio song playing happens for more than just me...but it's random and i'm not sure what could be causing random versions to randomly work or not. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 --- Comment #15 from Béla Gyebrószki <gyebro69(a)gmail.com> --- MR7122 <https://gitlab.winehq.org/wine/wine/-/merge_requests/7122> fixes the stalling issue for me. However I hear only crackling noise instead of music from the pipboy radio with the patch. Ambient music or voices, speech from pipboy plays properly, but not pipboy music. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 Connor McAdams <cmcadams(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmcadams(a)codeweavers.com --- Comment #16 from Connor McAdams <cmcadams(a)codeweavers.com> --- This should probably split into two separate bugs, one for the hang (which should now be fixed by 1eb5c884f735d0669fe5c02e9d000b517154dc15, and another for the silent radio music. Or just move the silent radio bug discussion to 42033. FWIW, I have a patch that seems to fix the radio silence bug, although it might be incorrect. There are two separate issues, one related to negative values returned from IMediaSample_GetTime() and another related to the filtergraph receiving EC_COMPLETE after EOS and `got_ec_complete` not being cleared before starting the next audio stream. I'm attaching a diff for this if others want to test it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 --- Comment #17 from Connor McAdams <cmcadams(a)codeweavers.com> --- Created attachment 77809 --> https://bugs.winehq.org/attachment.cgi?id=77809 Radio silence diff -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 mata <sutupud(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sutupud(a)yahoo.com --- Comment #18 from mata <sutupud(a)yahoo.com> --- I could reproduce the freeze with 10.0-rc4, but now with wine-10.0-rc5 it works again. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 --- Comment #19 from zlice <zlice(a)crtdrift.us> --- since this was marked for 10 and rc5 fixed the crash, i think it was confirmed and can be closed. i can pick up the silence issue in 42033. it's marked for wine version 2.0-rc1 but has been ongoing for years now. i even see a comment from 2023 there. as for Bela's crackling, i have in the past with different gstreamer versions, had to lower the bitrate of files through extracting them and then "load loose files" (also known as bArchiveInvalidate or some setting) - however in this case, the radio just chooses not to play sometimes 10 was silent, 9.22 was silent, and then installing 8.18 the radio played, going back to 9.22 was silent again (like i said before, i have no clue what the different versions are so random for) your patches seem to work on 10rc5 Connor -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 Béla Gyebrószki <gyebro69(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |1eb5c884f735d0669fe5c02e9d0 | |00b517154dc15 --- Comment #20 from Béla Gyebrószki <gyebro69(a)gmail.com> --- (In reply to zlice from comment #19)
since this was marked for 10 and rc5 fixed the crash, i think it was confirmed and can be closed.
Marking fixed then. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57632 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #21 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 10.0-rc6. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla