[Bug 16164] New: Sketchup 7 crashes when you click "Start using Sketchup"
http://bugs.winehq.org/show_bug.cgi?id=16164 Summary: Sketchup 7 crashes when you click "Start using Sketchup" Product: Wine Version: 1.1.9 Platform: Other URL: http://sketchup.google.com OS/Version: other Status: NEW Keywords: download Severity: normal Priority: P2 Component: mshtml AssignedTo: wine-bugs(a)winehq.org ReportedBy: dank(a)kegel.com This is the first bug people run into. (The next one is bug 14045.) When you start SketchUp, it puts up a dialog saying "Welcome to Sketchup". When you click "Start using Sketchup", it crashes before putting up the main window. You can work around it by checking "Don't show this again", and then running the app again, but it would be nice if that wasn't needed. Mike Hearn said the cause was mshtml wasn't refcounted properly, so I checked... and he's right. Hacking DLLCanUnloadNow in mshtml to always return S_FALSE, like this, diff --git a/dlls/mshtml/main.c b/dlls/mshtml/main.c @@ -231,7 +231,7 @@ HRESULT WINAPI DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID *ppv) HRESULT WINAPI DllCanUnloadNow(void) { TRACE("() ref=%d\n", module_ref); - return module_ref ? S_FALSE : S_OK; + return S_FALSE; //module_ref ? S_FALSE : S_OK; gets you past the crash. So presumably it's an mshtml bug. (In honor of this bug, I created an mshtml category in bugzilla finally...) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16164 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Sketchup 7 crashes when you |Google Sketchup 7 crashes |click "Start using Sketchup"|when you click "Start using | |Sketchup" -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16164 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #1 from Dan Kegel <dank(a)kegel.com> 2008-11-23 21:41:56 --- The workaround (checking the box) is not available for Sketchup Pro, at least in trial mode. Fortunately, the hack to DllCanUnloadNow still works there. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16164 Mike Hearn <mike(a)plan99.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mike(a)plan99.net --- Comment #2 from Mike Hearn <mike(a)plan99.net> 2008-11-24 02:05:20 --- Specifically the DLL allows itself to be unloaded whilst the Internet Explorer_Hidden window is still running. General question - why do we even bother refcounting DLLs in Wine? The resource savings are tiny in comparison to the human cost of debugging mistakes like this. DllCanUnloadNow might have made sense in Windows 95 but I doubt it's worth the hassle these days -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16164 --- Comment #3 from Dan Kegel <dank(a)kegel.com> 2008-11-25 23:51:55 --- Patch sent, http://www.winehq.org/pipermail/wine-patches/2008-November/065146.html Thanks! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16164 Alex Balut <alexandru.balut(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexandru.balut(a)gmail.com --- Comment #4 from Alex Balut <alexandru.balut(a)gmail.com> 2008-12-04 14:14:29 --- I'm working on removing the reference counting code. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16164 --- Comment #5 from Alex Balut <alexandru.balut(a)gmail.com> 2008-12-09 07:14:15 --- The bug is fixed by this patch: http://source.winehq.org/git/wine.git/?a=commit;h=fdac425f7fbd7d17ece4dec57b... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16164 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #6 from Austin English <austinenglish(a)gmail.com> 2008-12-09 11:42:47 --- Fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16164 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Alexandre Julliard <julliard(a)winehq.org> 2008-12-20 09:05:56 --- Closing bugs fixed in 1.1.11. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=16164 pjgalvin71(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pjgalvin71(a)gmail.com --- Comment #8 from pjgalvin71(a)gmail.com --- Created attachment 66408 --> https://bugs.winehq.org/attachment.cgi?id=66408 Bug report -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=16164 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- OS|other |Linux Fixed by SHA1| |fdac425f7fbd7d17ece4dec57bd | |6986192fb0b97 CC| |focht(a)gmx.net Hardware|Other |x86 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=16164 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|http://sketchup.google.com |https://web.archive.org/web | |/20120726023942/http://dl.g | |oogle.com/sketchup/gsu7/PW- | |2-1-6860-EN.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla